You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/09/28 13:53:24 UTC

[GitHub] [kafka] ijuma commented on a diff in pull request #12229: MINOR: Include the inner exception stack trace when re-throwing an exception

ijuma commented on code in PR #12229:
URL: https://github.com/apache/kafka/pull/12229#discussion_r982437499


##########
clients/src/main/java/org/apache/kafka/common/protocol/types/TaggedFields.java:
##########
@@ -165,7 +165,7 @@ public Map<Integer, Object> validate(Object item) {
             }
             return objects;
         } catch (ClassCastException e) {
-            throw new SchemaException("Not a NavigableMap.");
+            throw new SchemaException("Not a NavigableMap.", e);

Review Comment:
   Is this similar to the CompactArrayOf? Generally, if we can provide the right information without having a long chain of exceptions, it's better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org