You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/10/26 22:53:10 UTC
Review Request 63340: Moved Java build code to `java/CMakeLists.txt`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63340/
-----------------------------------------------------------
Review request for mesos, Jeff Coffler, John Kordich, and Joseph Wu.
Repository: mesos
Description
-------
Moved Java build code to `java/CMakeLists.txt`.
Diffs
-----
src/CMakeLists.txt 219252f6f82b2d62d024b2ab876fa0ba2f5c8e6c
src/java/CMakeLists.txt PRE-CREATION
Diff: https://reviews.apache.org/r/63340/diff/1/
Testing
-------
Built with `-DENABLE_JAVA=ON` and attached Marathon framework to `master` (which requries Java bindings). Also built and ran `mesos-tests` with the ZooKeeper unit tests (which use the Java components).
Had to add `mesos-protobufs` as a dependency to `mesos-jar` to be totally correct.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 63340: Moved Java build code to
`java/CMakeLists.txt`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63340/
-----------------------------------------------------------
(Updated Oct. 26, 2017, 3:55 p.m.)
Review request for mesos, Jeff Coffler, John Kordich, and Joseph Wu.
Changes
-------
Add dependency (I moved `mesos-fetcher` which #60628 enabled).
Repository: mesos
Description
-------
Moved Java build code to `java/CMakeLists.txt`.
Diffs
-----
src/CMakeLists.txt 219252f6f82b2d62d024b2ab876fa0ba2f5c8e6c
src/java/CMakeLists.txt PRE-CREATION
Diff: https://reviews.apache.org/r/63340/diff/1/
Testing
-------
Built with `-DENABLE_JAVA=ON` and attached Marathon framework to `master` (which requries Java bindings). Also built and ran `mesos-tests` with the ZooKeeper unit tests (which use the Java components).
Had to add `mesos-protobufs` as a dependency to `mesos-jar` to be totally correct.
Thanks,
Andrew Schwartzmeyer