You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/08/16 12:07:03 UTC
Review Request 68378: Changed vector of requests to be mutable.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68378/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Changed the `batchedRequest` vector inside the `Master::Http`
class to be mutable, in order to be able to restore the
`const` qualifier to the `/state`-handler.
While this may be a debatable benefit for this
endpoint alone, the subsequent commits introduce
additional work to extend this mechanism to all
read-only endpoint of `Master`.
Without this change, this would create a paradoxical
situation where all mutating endpoints are marked as
const and all read-only endpoints are marked as
non-const.
Diffs
-----
src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
Diff: https://reviews.apache.org/r/68378/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 68378: Changed vector of requests to be mutable.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68378/
-----------------------------------------------------------
(Updated Aug. 21, 2018, 6:45 a.m.)
Review request for mesos.
Bugs: MESOS-9158
https://issues.apache.org/jira/browse/MESOS-9158
Repository: mesos
Description
-------
Changed the `batchedRequest` vector inside the `Master::Http`
class to be mutable, in order to be able to restore the
`const` qualifier to the `/state`-handler.
While this may be a debatable benefit for this
endpoint alone, the subsequent commits introduce
additional work to extend this mechanism to all
read-only endpoint of `Master`.
Without this change, this would create a paradoxical
situation where all mutating endpoints are marked as
const and all read-only endpoints are marked as
non-const.
Diffs
-----
src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
Diff: https://reviews.apache.org/r/68378/diff/2/
Testing (updated)
-------
See https://reviews.apache.org/r/68296/
Thanks,
Benno Evers
Re: Review Request 68378: Changed vector of requests to be mutable.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68378/
-----------------------------------------------------------
(Updated Aug. 17, 2018, 7:05 p.m.)
Review request for mesos.
Repository: mesos
Description
-------
Changed the `batchedRequest` vector inside the `Master::Http`
class to be mutable, in order to be able to restore the
`const` qualifier to the `/state`-handler.
While this may be a debatable benefit for this
endpoint alone, the subsequent commits introduce
additional work to extend this mechanism to all
read-only endpoint of `Master`.
Without this change, this would create a paradoxical
situation where all mutating endpoints are marked as
const and all read-only endpoints are marked as
non-const.
Diffs (updated)
-----
src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
Diff: https://reviews.apache.org/r/68378/diff/2/
Changes: https://reviews.apache.org/r/68378/diff/1-2/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 68378: Changed vector of requests to be mutable.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68378/#review207408
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Aug. 16, 2018, 12:07 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68378/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2018, 12:07 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changed the `batchedRequest` vector inside the `Master::Http`
> class to be mutable, in order to be able to restore the
> `const` qualifier to the `/state`-handler.
>
> While this may be a debatable benefit for this
> endpoint alone, the subsequent commits introduce
> additional work to extend this mechanism to all
> read-only endpoint of `Master`.
>
> Without this change, this would create a paradoxical
> situation where all mutating endpoints are marked as
> const and all read-only endpoints are marked as
> non-const.
>
>
> Diffs
> -----
>
> src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
> src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
>
>
> Diff: https://reviews.apache.org/r/68378/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>