You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Kristen Legacy <kr...@gmail.com> on 2012/06/27 20:27:02 UTC
Review Request: RAVE-683: Revamp like/dislike display
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5617/
-----------------------------------------------------------
Review request for rave.
Description
-------
Restyled buttons & like counts to mimic Stan's proposal. Added JS to handle button/count sizing instead of reconfiguring how button & count function, which has the handy side effect of preventing the button from being substantially smaller than the like count text above it.
https://issues.apache.org/jira/browse/RAVE-683
Diffs
-----
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1354473
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1354473
trunk/rave-portal-resources/src/main/webapp/static/css/bootstrap/img/glyphicons-halflings-white.png 1354473
trunk/rave-portal-resources/src/main/webapp/static/css/bootstrap/img/glyphicons-halflings.png 1354473
trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1354473
trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js 1354473
Diff: https://reviews.apache.org/r/5617/diff/
Testing
-------
Thanks,
Kristen Legacy
Re: Review Request: RAVE-683: Revamp like/dislike display
Posted by Anthony Carlucci <ac...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5617/#review8966
-----------------------------------------------------------
Kristen, I'm unable to apply the patch in either IntelliJ or TortoiseSVN, I think because the patch contains both text and binary changes. Can you try breaking this patch up into two .patch files - one with just the text changes and one with just the binary image changes?
- Anthony Carlucci
On June 27, 2012, 6:27 p.m., Kristen Legacy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5617/
> -----------------------------------------------------------
>
> (Updated June 27, 2012, 6:27 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Restyled buttons & like counts to mimic Stan's proposal. Added JS to handle button/count sizing instead of reconfiguring how button & count function, which has the handy side effect of preventing the button from being substantially smaller than the like count text above it.
>
> https://issues.apache.org/jira/browse/RAVE-683
>
>
> Diffs
> -----
>
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1354473
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1354473
> trunk/rave-portal-resources/src/main/webapp/static/css/bootstrap/img/glyphicons-halflings-white.png 1354473
> trunk/rave-portal-resources/src/main/webapp/static/css/bootstrap/img/glyphicons-halflings.png 1354473
> trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1354473
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js 1354473
>
> Diff: https://reviews.apache.org/r/5617/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kristen Legacy
>
>
Re: Review Request: RAVE-683: Revamp like/dislike display
Posted by Anthony Carlucci <ac...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5617/#review9033
-----------------------------------------------------------
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp
<https://reviews.apache.org/r/5617/#comment19191>
remove if no longer needed
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp
<https://reviews.apache.org/r/5617/#comment19192>
Please replace hard-coded English language text with fmt:message tags that use the message bundles
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp
<https://reviews.apache.org/r/5617/#comment19193>
remove if no longer needed
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp
<https://reviews.apache.org/r/5617/#comment19194>
Please replace hard-coded English language text with fmt:message tags that use the message bundles
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp
<https://reviews.apache.org/r/5617/#comment19195>
Please replace hard-coded English language text with fmt:message tags that use the message bundles
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp
<https://reviews.apache.org/r/5617/#comment19196>
Please replace hard-coded English language text with fmt:message tags that use the message bundles
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp
<https://reviews.apache.org/r/5617/#comment19187>
remove if no longer needed
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp
<https://reviews.apache.org/r/5617/#comment19186>
Please replace hard-coded English language text with fmt:message tags that use the message bundles
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp
<https://reviews.apache.org/r/5617/#comment19188>
remove if no longer needed
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp
<https://reviews.apache.org/r/5617/#comment19189>
Please replace hard-coded English language text with fmt:message tags that use the message bundles
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp
<https://reviews.apache.org/r/5617/#comment19190>
Please replace hard-coded English language text with fmt:message tags that use the message bundles
- Anthony Carlucci
On July 9, 2012, 3 p.m., Kristen Legacy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5617/
> -----------------------------------------------------------
>
> (Updated July 9, 2012, 3 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Restyled buttons & like counts to mimic Stan's proposal. Added JS to handle button/count sizing instead of reconfiguring how button & count function, which has the handy side effect of preventing the button from being substantially smaller than the like count text above it.
>
> https://issues.apache.org/jira/browse/RAVE-683
>
>
> Diffs
> -----
>
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1354473
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1354473
> trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1354473
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js 1354473
>
> Diff: https://reviews.apache.org/r/5617/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kristen Legacy
>
>
Re: Review Request: RAVE-683: Revamp like/dislike display
Posted by Anthony Carlucci <ac...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5617/#review9075
-----------------------------------------------------------
Ship it!
LGTM - will make a couple minor changes with patch:
1) change .entityId property references to .id (now that we are using interface based model pattern, no guarantee of .entityId field existing)
2) page.widget.rate.likebtn message key was being used twice, instead of .dislikebtn
- Anthony Carlucci
On July 11, 2012, 5:17 p.m., Kristen Legacy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5617/
> -----------------------------------------------------------
>
> (Updated July 11, 2012, 5:17 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Restyled buttons & like counts to mimic Stan's proposal. Added JS to handle button/count sizing instead of reconfiguring how button & count function, which has the handy side effect of preventing the button from being substantially smaller than the like count text above it.
>
> https://issues.apache.org/jira/browse/RAVE-683
>
>
> Diffs
> -----
>
> trunk/rave-portal-resources/src/main/resources/messages.properties 1360225
> trunk/rave-portal-resources/src/main/resources/messages_es.properties 1360225
> trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1360225
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1360225
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1360225
> trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1360225
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js 1360225
>
> Diff: https://reviews.apache.org/r/5617/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kristen Legacy
>
>
Re: Review Request: RAVE-683: Revamp like/dislike display
Posted by Kristen Legacy <kr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5617/
-----------------------------------------------------------
(Updated July 11, 2012, 5:17 p.m.)
Review request for rave.
Changes
-------
Moved button text and thumbs-up text to fmt:message tags & removed commented out spans.
Description
-------
Restyled buttons & like counts to mimic Stan's proposal. Added JS to handle button/count sizing instead of reconfiguring how button & count function, which has the handy side effect of preventing the button from being substantially smaller than the like count text above it.
https://issues.apache.org/jira/browse/RAVE-683
Diffs (updated)
-----
trunk/rave-portal-resources/src/main/resources/messages.properties 1360225
trunk/rave-portal-resources/src/main/resources/messages_es.properties 1360225
trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1360225
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1360225
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1360225
trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1360225
trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js 1360225
Diff: https://reviews.apache.org/r/5617/diff/
Testing
-------
Thanks,
Kristen Legacy
Re: Review Request: RAVE-683: Revamp like/dislike display
Posted by Kristen Legacy <kr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5617/
-----------------------------------------------------------
(Updated July 9, 2012, 3 p.m.)
Review request for rave.
Changes
-------
Hey Tony, I removed the image binary from the diff, uploaded the two new images to the Jira ticket and put the target directory in the comments.
Description
-------
Restyled buttons & like counts to mimic Stan's proposal. Added JS to handle button/count sizing instead of reconfiguring how button & count function, which has the handy side effect of preventing the button from being substantially smaller than the like count text above it.
https://issues.apache.org/jira/browse/RAVE-683
Diffs (updated)
-----
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1354473
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1354473
trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1354473
trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js 1354473
Diff: https://reviews.apache.org/r/5617/diff/
Testing
-------
Thanks,
Kristen Legacy
Re: Review Request: RAVE-683: Revamp like/dislike display
Posted by Anthony Carlucci <ac...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5617/#review8968
-----------------------------------------------------------
Actually Kristen, let's do this: please create a patch file of only the text changes, and attach your new image files to the Jira ticket. I will add them as part of the commit since SVN seems to have problems with binary diffs
- Anthony Carlucci
On June 27, 2012, 6:27 p.m., Kristen Legacy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5617/
> -----------------------------------------------------------
>
> (Updated June 27, 2012, 6:27 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Restyled buttons & like counts to mimic Stan's proposal. Added JS to handle button/count sizing instead of reconfiguring how button & count function, which has the handy side effect of preventing the button from being substantially smaller than the like count text above it.
>
> https://issues.apache.org/jira/browse/RAVE-683
>
>
> Diffs
> -----
>
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1354473
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1354473
> trunk/rave-portal-resources/src/main/webapp/static/css/bootstrap/img/glyphicons-halflings-white.png 1354473
> trunk/rave-portal-resources/src/main/webapp/static/css/bootstrap/img/glyphicons-halflings.png 1354473
> trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1354473
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js 1354473
>
> Diff: https://reviews.apache.org/r/5617/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kristen Legacy
>
>
Re: Review Request: RAVE-683: Revamp like/dislike display
Posted by Kristen Legacy <kr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5617/
-----------------------------------------------------------
(Updated June 27, 2012, 6:27 p.m.)
Review request for rave.
Description
-------
Restyled buttons & like counts to mimic Stan's proposal. Added JS to handle button/count sizing instead of reconfiguring how button & count function, which has the handy side effect of preventing the button from being substantially smaller than the like count text above it.
https://issues.apache.org/jira/browse/RAVE-683
Diffs
-----
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1354473
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1354473
trunk/rave-portal-resources/src/main/webapp/static/css/bootstrap/img/glyphicons-halflings-white.png 1354473
trunk/rave-portal-resources/src/main/webapp/static/css/bootstrap/img/glyphicons-halflings.png 1354473
trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1354473
trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js 1354473
Diff: https://reviews.apache.org/r/5617/diff/
Testing
-------
Thanks,
Kristen Legacy