You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/12/18 20:17:26 UTC
[GitHub] [incubator-kyuubi] dnskr opened a new pull request, #4004: [K8S][HELM] Add configuration files support to helm chart
dnskr opened a new pull request, #4004:
URL: https://github.com/apache/incubator-kyuubi/pull/4004
### _Why are the changes needed?_
The changes allow to:
1. set Kyuubi configuration files:
- `kyuubi-env.sh`
- `kyuubi-defaults.conf`
- `log4j2.xml`
2. restart (recreate) Kyuubi server pods if configuration files have changed
- this probably should be revisited after https://github.com/apache/incubator-kyuubi/pull/3983
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #4004: [K8S][HELM] Add configuration files support to helm chart
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4004:
URL: https://github.com/apache/incubator-kyuubi/pull/4004#issuecomment-1356879758
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/4004?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4004](https://codecov.io/gh/apache/incubator-kyuubi/pull/4004?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8367825) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c577dc7e0685656fb2b6a22d997a9dd5e78744a4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c577dc7) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #4004 +/- ##
============================================
- Coverage 52.11% 52.08% -0.03%
Complexity 13 13
============================================
Files 541 541
Lines 29468 29468
Branches 3938 3938
============================================
- Hits 15357 15349 -8
- Misses 12709 12712 +3
- Partials 1402 1407 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/4004?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/4004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvY21kL2xvZy9Mb2dCYXRjaENvbW1hbmQuc2NhbGE=) | `60.00% <0.00%> (-7.70%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/4004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `80.00% <0.00%> (-2.67%)` | :arrow_down: |
| [...he/kyuubi/ha/client/etcd/EtcdDiscoveryClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/4004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9ldGNkL0V0Y2REaXNjb3ZlcnlDbGllbnQuc2NhbGE=) | `68.50% <0.00%> (-0.56%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/4004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `97.45% <0.00%> (-0.07%)` | :arrow_down: |
| [...org/apache/kyuubi/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/4004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `78.48% <0.00%> (ø)` | |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/4004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `79.56% <0.00%> (+0.72%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4004: [K8S][HELM] Add configuration files support to helm chart
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on PR #4004:
URL: https://github.com/apache/kyuubi/pull/4004#issuecomment-1370526926
@dnskr Hi, https://github.com/apache/kyuubi/issues/3982 is closed, while I am afraid that it won't help in your case since it was refactored to refresh users' default configs only as dissucssed in PR 3983.
But you can still consider follow the similar pattern to achieve it as the following as 3982 does,
- add REST API to apply config changes and implement related method in server
- add command or config type for refreshing configs in `kyuubi-admin`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #4004: [K8S][HELM] Add configuration files support to helm chart
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #4004:
URL: https://github.com/apache/incubator-kyuubi/pull/4004#issuecomment-1361265532
Merged to master, thanks @dnskr for your contribution and passion. The team is suffering from COVID-19, and may not be able to reply in time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #4004: [K8S][HELM] Add configuration files support to helm chart
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #4004:
URL: https://github.com/apache/incubator-kyuubi/pull/4004#discussion_r1051745271
##########
docker/helm/templates/kyuubi-configmap.yaml:
##########
@@ -18,39 +18,30 @@
apiVersion: v1
kind: ConfigMap
metadata:
- name: {{ .Release.Name }}-kyuubi-defaults
+ name: {{ .Release.Name }}
labels:
helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version }}
app.kubernetes.io/name: {{ .Chart.Name }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/version: {{ .Values.image.tag | default .Chart.AppVersion | quote }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
data:
+ {{- with .Values.server.conf.kyuubiEnv }}
+ kyuubi-env.sh: |
+ #!/usr/bin/env bash
+ {{- tpl . $ | nindent 4 }}
+ {{- end }}
kyuubi-defaults.conf: |
- #
- # Licensed to the Apache Software Foundation (ASF) under one or more
- # contributor license agreements. See the NOTICE file distributed with
- # this work for additional information regarding copyright ownership.
- # The ASF licenses this file to You under the Apache License, Version 2.0
- # (the "License"); you may not use this file except in compliance with
- # the License. You may obtain a copy of the License at
- #
- # http://www.apache.org/licenses/LICENSE-2.0
- #
- # Unless required by applicable law or agreed to in writing, software
- # distributed under the License is distributed on an "AS IS" BASIS,
- # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- # See the License for the specific language governing permissions and
- # limitations under the License.
- #
-
- ## Kyuubi Configurations
-
- #
- # kyuubi.authentication NONE
- #
+ ## Helm chart provided Kyuubi configurations
kyuubi.frontend.bind.host={{ .Values.server.bind.host }}
kyuubi.frontend.bind.port={{ .Values.server.bind.port }}
kyuubi.kubernetes.namespace={{ .Release.Namespace }}
- # Details in https://kyuubi.apache.org/docs/latest/deployment/settings.html
Review Comment:
~~can we reserve this link so that users can find all available configurations?~~
Forget it, I see you moved it to `value.yaml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #4004: [K8S][HELM] Add configuration files support to helm chart
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #4004:
URL: https://github.com/apache/incubator-kyuubi/pull/4004#issuecomment-1356997381
Thanks @dnskr
> 1. I can't find `kyuubi.kubernetes.namespace` config both documentation and source code, so I deleted it.
You can find it in the [master branch doc(unreleased)](https://kyuubi.readthedocs.io/en/latest/index.html), the [latest doc](https://kyuubi.apache.org/docs/latest) represents the latest stable release doc.
> 2. I found that `kyuubi.frontend.bind.host` and `kyuubi.frontend.bind.port` marked as deprecated in the [doc](https://kyuubi.apache.org/docs/latest/deployment/settings.html#frontend), but I can't find what should be used instead.
Sorry for confusing, I opened https://github.com/apache/incubator-kyuubi/pull/4005 to explain and fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #4004: [K8S][HELM] Add configuration files support to helm chart
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #4004:
URL: https://github.com/apache/incubator-kyuubi/pull/4004#discussion_r1051745271
##########
docker/helm/templates/kyuubi-configmap.yaml:
##########
@@ -18,39 +18,30 @@
apiVersion: v1
kind: ConfigMap
metadata:
- name: {{ .Release.Name }}-kyuubi-defaults
+ name: {{ .Release.Name }}
labels:
helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version }}
app.kubernetes.io/name: {{ .Chart.Name }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/version: {{ .Values.image.tag | default .Chart.AppVersion | quote }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
data:
+ {{- with .Values.server.conf.kyuubiEnv }}
+ kyuubi-env.sh: |
+ #!/usr/bin/env bash
+ {{- tpl . $ | nindent 4 }}
+ {{- end }}
kyuubi-defaults.conf: |
- #
- # Licensed to the Apache Software Foundation (ASF) under one or more
- # contributor license agreements. See the NOTICE file distributed with
- # this work for additional information regarding copyright ownership.
- # The ASF licenses this file to You under the Apache License, Version 2.0
- # (the "License"); you may not use this file except in compliance with
- # the License. You may obtain a copy of the License at
- #
- # http://www.apache.org/licenses/LICENSE-2.0
- #
- # Unless required by applicable law or agreed to in writing, software
- # distributed under the License is distributed on an "AS IS" BASIS,
- # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- # See the License for the specific language governing permissions and
- # limitations under the License.
- #
-
- ## Kyuubi Configurations
-
- #
- # kyuubi.authentication NONE
- #
+ ## Helm chart provided Kyuubi configurations
kyuubi.frontend.bind.host={{ .Values.server.bind.host }}
kyuubi.frontend.bind.port={{ .Values.server.bind.port }}
kyuubi.kubernetes.namespace={{ .Release.Namespace }}
- # Details in https://kyuubi.apache.org/docs/latest/deployment/settings.html
Review Comment:
can we reserve this link so that users can find all available configurations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #4004: [K8S][HELM] Add configuration files support to helm chart
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #4004:
URL: https://github.com/apache/incubator-kyuubi/pull/4004#discussion_r1051747514
##########
docker/helm/templates/kyuubi-deployment.yaml:
##########
@@ -36,6 +36,8 @@ spec:
labels:
app.kubernetes.io/name: {{ .Chart.Name }}
app.kubernetes.io/instance: {{ .Release.Name }}
+ annotations:
+ checksum/conf: {{ include (print $.Template.BasePath "/kyuubi-configmap.yaml") . | sha256sum }}
Review Comment:
I'm not really familiar w/ helm, is it recommended? where can I find docs on that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] dnskr commented on pull request #4004: [K8S][HELM] Add configuration files support to helm chart
Posted by GitBox <gi...@apache.org>.
dnskr commented on PR #4004:
URL: https://github.com/apache/incubator-kyuubi/pull/4004#issuecomment-1361253969
> How about change `server` to `kyuubi`? And we may need a similar part of `spark` and `hadoop`
>
> For "bind" part, the port is not sufficient since Kyuubi supports multi protocols, not only thrift binary now.
Agree with both suggestions. I left it as is just because I'm quite new in Kyuubi and don't fully understand all moving pieces. But I have enthusiasm to continue exploring it and creating PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] dnskr commented on pull request #4004: [K8S][HELM] Add configuration files support to helm chart
Posted by GitBox <gi...@apache.org>.
dnskr commented on PR #4004:
URL: https://github.com/apache/incubator-kyuubi/pull/4004#issuecomment-1356867823
I'm not sure about default values for `kyuubi-defaults.conf`:
1. I can't find `kyuubi.kubernetes.namespace` config both documentation and source code, so I deleted it.
2. I found that `kyuubi.frontend.bind.host` and `kyuubi.frontend.bind.port` marked as deprecated in the [doc](https://kyuubi.apache.org/docs/latest/deployment/settings.html#frontend), but I can't find what should be used instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #4004: [K8S][HELM] Add configuration files support to helm chart
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #4004: [K8S][HELM] Add configuration files support to helm chart
URL: https://github.com/apache/incubator-kyuubi/pull/4004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] dnskr commented on a diff in pull request #4004: [K8S][HELM] Add configuration files support to helm chart
Posted by GitBox <gi...@apache.org>.
dnskr commented on code in PR #4004:
URL: https://github.com/apache/incubator-kyuubi/pull/4004#discussion_r1052603127
##########
docker/helm/templates/kyuubi-deployment.yaml:
##########
@@ -36,6 +36,8 @@ spec:
labels:
app.kubernetes.io/name: {{ .Chart.Name }}
app.kubernetes.io/instance: {{ .Release.Name }}
+ annotations:
+ checksum/conf: {{ include (print $.Template.BasePath "/kyuubi-configmap.yaml") . | sha256sum }}
Review Comment:
Yes, it's official helm recommended [Chart Development Tips and Tricks](https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments) which actually sounds funny.
It's used in Apache Airflow [helm chart](https://github.com/apache/airflow/blob/672264b0af4874274bd130ba42a78e8e72f3d3ff/chart/templates/webserver/webserver-deployment.yaml#L79-L86) for example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #4004: [K8S][HELM] Add configuration files support to helm chart
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #4004:
URL: https://github.com/apache/incubator-kyuubi/pull/4004#issuecomment-1361095262
@hddong @dnskr some thoughts about the schema of `values.yaml`
```
server:
bind:
host: 0.0.0.0
port: 10009
confDir:
conf:
kyuubiEnv:
kyuubiDefaults:
log4j2:
```
How about change `server` to `kyuubi`? And we may need a similar part of `spark` and `hadoop`
For "bind" part, the port is not sufficient since Kyuubi supports multi protocols, not only thrift binary now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org