[GitHub] [helix] mgao0 commented on issue #849: Add REST APIs for get, set, update RestConfig

[GitBox <gi...@apache.org>]

mgao0 commented on issue #849: Add REST APIs for get, set, update RestConfig
URL: https://github.com/apache/helix/pull/849#issuecomment-597309014
 
 
   > Please fix/improve the code where change is possible. The fact that existing code is doing it in a certain suboptimal way doesn't justify us making the same mistake. I am fine, however, with creating a separate issue for refactoring work that will involve changes in existing logic though.
   
   Rolling out functional service for our customers at the earliest to unblock them is our top priority. We proved the current way works fine, and the new way although is clearer in code, it bears the risk of breaking things for our customers. Therefore, I considered it sub-priority for us. Also, refactoring for one thing all together is easier for us to track and debug if anything goes wrong in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org