You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/01/26 00:02:06 UTC
Review Request 42755: Added documentation for labeled reserved
resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
Added documentation for labeled reserved resources.
Diffs
-----
docs/reservation.md 8d2d33a6518c73542cbfb3a5ee36da1c00c6ff1a
Diff: https://reviews.apache.org/r/42755/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review117674
-----------------------------------------------------------
docs/reservation.md (line 65)
<https://reviews.apache.org/r/42755/#comment178953>
Should we highlight `labelfree reservation`? As it is not true for dynamic reservations in general anymore.
docs/reservation.md (line 80)
<https://reviews.apache.org/r/42755/#comment178952>
s/agent/slave.In the rest of this document we use slave. Alternatively we can change all others to agent, but should be consistent.
docs/reservation.md (line 81)
<https://reviews.apache.org/r/42755/#comment178951>
into a single reservation despite having the same role.
- Joerg Schad
On Feb. 3, 2016, 5:51 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 5:51 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for labeled reserved resources.
>
>
> Diffs
> -----
>
> docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956
>
> Diff: https://reviews.apache.org/r/42755/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review117729
-----------------------------------------------------------
Fix it, then Ship it!
docs/reservation.md (line 84)
<https://reviews.apache.org/r/42755/#comment179008>
Add newline.
- Michael Park
On Feb. 3, 2016, 10:40 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 10:40 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for labeled reserved resources.
>
>
> Diffs
> -----
>
> docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956
>
> Diff: https://reviews.apache.org/r/42755/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review117723
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42750, 42751, 42752, 42753, 42754, 42755]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 3, 2016, 10:40 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 10:40 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for labeled reserved resources.
>
>
> Diffs
> -----
>
> docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956
>
> Diff: https://reviews.apache.org/r/42755/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review117973
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43239, 42751, 42752, 42753, 42754, 42755]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 5, 2016, 2:18 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 2:18 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for labeled reserved resources.
>
>
> Diffs
> -----
>
> docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956
>
> Diff: https://reviews.apache.org/r/42755/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/
-----------------------------------------------------------
(Updated Feb. 5, 2016, 2:18 a.m.)
Review request for mesos and Michael Park.
Changes
-------
Rebase.
Repository: mesos
Description
-------
Added documentation for labeled reserved resources.
Diffs (updated)
-----
docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956
Diff: https://reviews.apache.org/r/42755/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/
-----------------------------------------------------------
(Updated Feb. 3, 2016, 10:40 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Address review comments from Joerg.
Repository: mesos
Description
-------
Added documentation for labeled reserved resources.
Diffs (updated)
-----
docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956
Diff: https://reviews.apache.org/r/42755/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review117652
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42750, 42751, 42752, 42753, 42754, 42755]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 3, 2016, 5:51 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 5:51 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for labeled reserved resources.
>
>
> Diffs
> -----
>
> docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956
>
> Diff: https://reviews.apache.org/r/42755/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review117675
-----------------------------------------------------------
Ship it!
After previous issues are resolved :-).
- Joerg Schad
On Feb. 3, 2016, 5:51 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 5:51 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for labeled reserved resources.
>
>
> Diffs
> -----
>
> docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956
>
> Diff: https://reviews.apache.org/r/42755/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/
-----------------------------------------------------------
(Updated Feb. 3, 2016, 5:51 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Rebase.
Repository: mesos
Description
-------
Added documentation for labeled reserved resources.
Diffs (updated)
-----
docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956
Diff: https://reviews.apache.org/r/42755/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Neil Conway <ne...@gmail.com>.
> On Jan. 29, 2016, 1:25 a.m., Qian Zhang wrote:
> > docs/reservation.md, lines 80-81
> > <https://reviews.apache.org/r/42755/diff/1/?file=1220234#file1220234line80>
> >
> > I understand the two reservations with different labels will not be combined. But what about the two reservation with same label? Do we need to describe its behavior here too?
> >
> > I think the latter is a bit complex, e.g., one reservation made by framework with a label and another reservation made by operator with the same label. Will we combine them into one reservation? In this case, the principle of the two reservations could be different, right? So we will end up with two separate reservations with same label?
Hi Qian -- good points. If two reservations have different labels, they will not be merged. Similarly, if two reservations have the same label but different principals or roles, they will also not be merged. You basically need _all_ the metadata about two reservations (role, slave-id, principal, labels, etc.) to be the same for them to be merged.
Your point made me realize we don't have unit tests for the case where two reservations have the same role but different principals -- I opened https://issues.apache.org/jira/browse/MESOS-4590 to track that.
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review116861
-----------------------------------------------------------
On Feb. 3, 2016, 5:51 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 5:51 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for labeled reserved resources.
>
>
> Diffs
> -----
>
> docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956
>
> Diff: https://reviews.apache.org/r/42755/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review116861
-----------------------------------------------------------
docs/reservation.md (lines 80 - 81)
<https://reviews.apache.org/r/42755/#comment177962>
I understand the two reservations with different labels will not be combined. But what about the two reservation with same label? Do we need to describe its behavior here too?
I think the latter is a bit complex, e.g., one reservation made by framework with a label and another reservation made by operator with the same label. Will we combine them into one reservation? In this case, the principle of the two reservations could be different, right? So we will end up with two separate reservations with same label?
- Qian Zhang
On Jan. 26, 2016, 7:02 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 7:02 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for labeled reserved resources.
>
>
> Diffs
> -----
>
> docs/reservation.md 8d2d33a6518c73542cbfb3a5ee36da1c00c6ff1a
>
> Diff: https://reviews.apache.org/r/42755/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review116846
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Jan. 26, 2016, 7:02 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 7:02 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for labeled reserved resources.
>
>
> Diffs
> -----
>
> docs/reservation.md 8d2d33a6518c73542cbfb3a5ee36da1c00c6ff1a
>
> Diff: https://reviews.apache.org/r/42755/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review116317
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 一月 25, 2016, 11:02 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> -----------------------------------------------------------
>
> (Updated 一月 25, 2016, 11:02 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for labeled reserved resources.
>
>
> Diffs
> -----
>
> docs/reservation.md 8d2d33a6518c73542cbfb3a5ee36da1c00c6ff1a
>
> Diff: https://reviews.apache.org/r/42755/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42755: Added documentation for labeled reserved
resources.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review116248
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42750, 42751, 42752, 42753, 42754, 42755]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 25, 2016, 11:02 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 11:02 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for labeled reserved resources.
>
>
> Diffs
> -----
>
> docs/reservation.md 8d2d33a6518c73542cbfb3a5ee36da1c00c6ff1a
>
> Diff: https://reviews.apache.org/r/42755/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>