You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/04/10 00:07:27 UTC
[kudu-CR] tool: fixes for kudu local replica dump rowset
Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12976
Change subject: tool: fixes for kudu local_replica dump rowset
......................................................................
tool: fixes for kudu local_replica dump rowset
This patch makes several adjustments to 'kudu local_replica dump rowset':
- The existing 'metadata_only' and 'nrows' controls were being ignored.
- The existing 'rowset_index' control wasn't working properly.
- I changed the "what to dump" contols to 'dump_all_columns' and
'dump_metadata'. When 'dump_all_columns' is false, the row keys are dumped
in a format that's comparable and ASCII-compatible (currently hex).
This functionality helped me dump a tablet's keys (grouped by rowset), which
I then used for a series of MergeIterator experiments.
Change-Id: Ib50ab4e7b2aa0fec60ce0718d16823945a05cb7f
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_local_replica.cc
2 files changed, 155 insertions(+), 57 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/12976/1
--
To view, visit http://gerrit.cloudera.org:8080/12976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib50ab4e7b2aa0fec60ce0718d16823945a05cb7f
Gerrit-Change-Number: 12976
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
[kudu-CR] tool: fixes for kudu local replica dump rowset
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12976
to look at the new patch set (#2).
Change subject: tool: fixes for kudu local_replica dump rowset
......................................................................
tool: fixes for kudu local_replica dump rowset
This patch makes several adjustments to 'kudu local_replica dump rowset':
- The existing 'metadata_only' and 'nrows' controls were being ignored.
- The existing 'rowset_index' control wasn't working properly.
- I changed the "what to dump" contols to 'dump_all_columns' and
'dump_metadata'. When 'dump_all_columns' is false, the row keys are dumped
in a format that's comparable and ASCII-compatible (currently hex).
This functionality helped me dump a tablet's keys (grouped by rowset), which
I then used for a series of MergeIterator experiments.
Change-Id: Ib50ab4e7b2aa0fec60ce0718d16823945a05cb7f
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_local_replica.cc
2 files changed, 161 insertions(+), 57 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/12976/2
--
To view, visit http://gerrit.cloudera.org:8080/12976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib50ab4e7b2aa0fec60ce0718d16823945a05cb7f
Gerrit-Change-Number: 12976
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] tool: fixes for kudu local replica dump rowset
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12976 )
Change subject: tool: fixes for kudu local_replica dump rowset
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib50ab4e7b2aa0fec60ce0718d16823945a05cb7f
Gerrit-Change-Number: 12976
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Apr 2019 01:23:45 +0000
Gerrit-HasComments: No
[kudu-CR] tool: fixes for kudu local replica dump rowset
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12976 )
Change subject: tool: fixes for kudu local_replica dump rowset
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12976/2/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/12976/2/src/kudu/tools/kudu-tool-test.cc@1978
PS2, Line 1978: switch (i) {
: case 0: exp_val = 1; break;
: case 1: exp_val = 9; break;
: case 2: exp_val = 5; break;
: default: LOG(FATAL) << "Unreachable code";
: }
> Mind adding a comment explaining the significance of these values? I know i
I rejiggered the test to cover the case where nrows causes us to print partial rowsets. That uncovered a bug in how I was inserting rows, and after fixing that, the values here went back to being static again.
http://gerrit.cloudera.org:8080/#/c/12976/2/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:
http://gerrit.cloudera.org:8080/#/c/12976/2/src/kudu/tools/tool_action_local_replica.cc@685
PS2, Line 685: != -1
> This should probably be >= 0 to match L679, in which case the default seman
Done
--
To view, visit http://gerrit.cloudera.org:8080/12976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib50ab4e7b2aa0fec60ce0718d16823945a05cb7f
Gerrit-Change-Number: 12976
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Apr 2019 03:47:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] tool: fixes for kudu local replica dump rowset
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12976
to look at the new patch set (#3).
Change subject: tool: fixes for kudu local_replica dump rowset
......................................................................
tool: fixes for kudu local_replica dump rowset
This patch makes several adjustments to 'kudu local_replica dump rowset':
- The existing 'metadata_only' and 'nrows' controls were being ignored.
- The existing 'rowset_index' control wasn't working properly.
- I changed the "what to dump" contols to 'dump_all_columns' and
'dump_metadata'. When 'dump_all_columns' is false, the row keys are dumped
in a format that's comparable and ASCII-compatible (currently hex).
This functionality helped me dump a tablet's keys (grouped by rowset), which
I then used for a series of MergeIterator experiments.
Change-Id: Ib50ab4e7b2aa0fec60ce0718d16823945a05cb7f
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_local_replica.cc
2 files changed, 162 insertions(+), 57 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/12976/3
--
To view, visit http://gerrit.cloudera.org:8080/12976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib50ab4e7b2aa0fec60ce0718d16823945a05cb7f
Gerrit-Change-Number: 12976
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] tool: fixes for kudu local replica dump rowset
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12976 )
Change subject: tool: fixes for kudu local_replica dump rowset
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12976/2/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/12976/2/src/kudu/tools/kudu-tool-test.cc@1978
PS2, Line 1978: switch (i) {
: case 0: exp_val = 1; break;
: case 1: exp_val = 9; break;
: case 2: exp_val = 5; break;
: default: LOG(FATAL) << "Unreachable code";
: }
Mind adding a comment explaining the significance of these values? I know it's not what you're testing, but I think this clearer by eg naming 'i' 'rowset_idx', documenting why 1,9,5, etc.
http://gerrit.cloudera.org:8080/#/c/12976/2/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:
http://gerrit.cloudera.org:8080/#/c/12976/2/src/kudu/tools/tool_action_local_replica.cc@685
PS2, Line 685: != -1
This should probably be >= 0 to match L679, in which case the default semantics extend to all negative numbers, rather than just -1, in which case nrows should be updated too.
--
To view, visit http://gerrit.cloudera.org:8080/12976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib50ab4e7b2aa0fec60ce0718d16823945a05cb7f
Gerrit-Change-Number: 12976
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Apr 2019 01:09:15 +0000
Gerrit-HasComments: Yes
[kudu-CR] tool: fixes for kudu local replica dump rowset
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12976
to look at the new patch set (#4).
Change subject: tool: fixes for kudu local_replica dump rowset
......................................................................
tool: fixes for kudu local_replica dump rowset
This patch makes several adjustments to 'kudu local_replica dump rowset':
- The existing 'metadata_only' and 'nrows' controls were being ignored.
- The existing 'rowset_index' control wasn't working properly.
- I changed the "what to dump" contols to 'dump_all_columns' and
'dump_metadata'. When 'dump_all_columns' is false, the row keys are dumped
in a format that's comparable and ASCII-compatible (currently hex).
This functionality helped me dump a tablet's keys (grouped by rowset), which
I then used for a series of MergeIterator experiments.
Change-Id: Ib50ab4e7b2aa0fec60ce0718d16823945a05cb7f
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_local_replica.cc
2 files changed, 163 insertions(+), 57 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/12976/4
--
To view, visit http://gerrit.cloudera.org:8080/12976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib50ab4e7b2aa0fec60ce0718d16823945a05cb7f
Gerrit-Change-Number: 12976
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] tool: fixes for kudu local replica dump rowset
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12976 )
Change subject: tool: fixes for kudu local_replica dump rowset
......................................................................
tool: fixes for kudu local_replica dump rowset
This patch makes several adjustments to 'kudu local_replica dump rowset':
- The existing 'metadata_only' and 'nrows' controls were being ignored.
- The existing 'rowset_index' control wasn't working properly.
- I changed the "what to dump" contols to 'dump_all_columns' and
'dump_metadata'. When 'dump_all_columns' is false, the row keys are dumped
in a format that's comparable and ASCII-compatible (currently hex).
This functionality helped me dump a tablet's keys (grouped by rowset), which
I then used for a series of MergeIterator experiments.
Change-Id: Ib50ab4e7b2aa0fec60ce0718d16823945a05cb7f
Reviewed-on: http://gerrit.cloudera.org:8080/12976
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_local_replica.cc
2 files changed, 163 insertions(+), 57 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib50ab4e7b2aa0fec60ce0718d16823945a05cb7f
Gerrit-Change-Number: 12976
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>