You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by gregh3269 <gi...@git.apache.org> on 2016/08/04 07:33:59 UTC
[GitHub] struts pull request #108: ConversionErrorInterceptor to extend MethodFilterI...
GitHub user gregh3269 opened a pull request:
https://github.com/apache/struts/pull/108
ConversionErrorInterceptor to extend MethodFilterIntercept
See WW-4676
Cheers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gregh3269/struts master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/struts/pull/108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #108
----
commit 5e07b9574c66110b9a44338c6c7290a65be276f3
Author: gregh3269 <gr...@gmail.com>
Date: 2016-08-03T09:50:44Z
ConversionErrorInterceptor to extend MethodFilterIntercept. See WW-4676
commit 50fa26533a43295e70db7eca6f4f7d8c69e0d2fe
Author: gregh3269 <gr...@gmail.com>
Date: 2016-08-04T07:31:32Z
Add java doc for MethodFilterInterceptor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts issue #108: ConversionErrorInterceptor to extend MethodFilterIntercep...
Posted by gregh3269 <gi...@git.apache.org>.
Github user gregh3269 commented on the issue:
https://github.com/apache/struts/pull/108
Great thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts issue #108: ConversionErrorInterceptor to extend MethodFilterIntercep...
Posted by cnenning <gi...@git.apache.org>.
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/108
> How would this be fixed now?
I fixed it already just by running `git cherry-pick`. (there is a jira comment about it)
I feared that monstrous issue ([WW-4628](https://issues.apache.org/jira/browse/WW-4628)) would get another round of discussion and was relieved that it was just an accident :wink:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts issue #108: ConversionErrorInterceptor to extend MethodFilterIntercep...
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/108
@gregh3269 the best options is to not perform those reverse merges (like b6be359) if there is no conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts issue #108: ConversionErrorInterceptor to extend MethodFilterIntercep...
Posted by gregh3269 <gi...@git.apache.org>.
Github user gregh3269 commented on the issue:
https://github.com/apache/struts/pull/108
OK, looks like it needs a doIntercept(..) rather than in Intercept().
On 4 August 2016 at 09:22, Lukasz Lenart <no...@github.com> wrote:
> Some tests failed
> https://builds.apache.org/job/Struts-JDK7-pull-request/209/org.apache.struts$struts2-core/testReport/
>
> \u2014
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/struts/pull/108#issuecomment-237486069>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ADwEt8Q9RTCp3xIs6DlBp2n5UJfNHMoxks5qcaFMgaJpZM4JcazT>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts issue #108: ConversionErrorInterceptor to extend MethodFilterIntercep...
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/108
Some tests failed https://builds.apache.org/job/Struts-JDK7-pull-request/209/org.apache.struts$struts2-core/testReport/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request #108: ConversionErrorInterceptor to extend MethodFilterI...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/struts/pull/108
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts issue #108: ConversionErrorInterceptor to extend MethodFilterIntercep...
Posted by gregh3269 <gi...@git.apache.org>.
Github user gregh3269 commented on the issue:
https://github.com/apache/struts/pull/108
Revert "WW-4628: proper decoding of parameters in query-string"
Sorry, this was a bad by not really understanding git and git making
automatic commits, it should not have modified any other code. Especially not the revert.
How would this be fixed now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts issue #108: ConversionErrorInterceptor to extend MethodFilterIntercep...
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/108
Still two tests are failing ... I think it would be better to setup `excludeMethods`/`includeMethods` in test and call`intercept()`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org