You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by nrchandan <gi...@git.apache.org> on 2014/08/01 16:51:05 UTC
[GitHub] spark pull request: [SPARK-1170] Add histogram method
GitHub user nrchandan opened a pull request:
https://github.com/apache/spark/pull/1716
[SPARK-1170] Add histogram method
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nrchandan/spark pull_121
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1716.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1716
----
commit 681fecd702b7bc4a99f70504f6dd411b3af9c34e
Author: Dan McClary <da...@gmail.com>
Date: 2014-03-11T06:58:32Z
added histogram method, added max and min to statscounter
commit fca370020cfb9fcb56810080ba001b4661a14c16
Author: Prashant Sharma <pr...@imaginea.com>
Date: 2014-03-11T07:51:22Z
SPARK-1170 Added histogram(buckets) to pyspark and not histogram(noOfBuckets).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1170] Add histogram method
Posted by nrchandan <gi...@git.apache.org>.
Github user nrchandan commented on the pull request:
https://github.com/apache/spark/pull/1716#issuecomment-50893157
More test cases need to added. More thorough testing needs to be performed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1170] Add histogram method
Posted by nrchandan <gi...@git.apache.org>.
Github user nrchandan closed the pull request at:
https://github.com/apache/spark/pull/1716
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1170] Add histogram method
Posted by nrchandan <gi...@git.apache.org>.
Github user nrchandan commented on the pull request:
https://github.com/apache/spark/pull/1716#issuecomment-50895807
Also, returned data structure needs to be reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---