You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:44:07 UTC

[GitHub] [helix] kaisun2000 commented on pull request #1492: fix TestCleanupExternalView.test

kaisun2000 commented on pull request #1492:
URL: https://github.com/apache/helix/pull/1492#issuecomment-720752400


   This diff is approved. Please help to merge
   
   >Flaky test with 10 * 100ms. This may not be enough when there is
   logging or Zk is slow in github. Fix with TestHelper.verify();


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org