You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Daniel John Debrunner (JIRA)" <de...@db.apache.org> on 2005/12/22 17:05:31 UTC
[jira] Commented: (DERBY-100) Add support for insert functionality using JDBC 2.0 updatable resultset apis
[ http://issues.apache.org/jira/browse/DERBY-100?page=comments#action_12361115 ]
Daniel John Debrunner commented on DERBY-100:
---------------------------------------------
Looks good generally, some minor comments:
In EmbedResultSet.moveToInsertRow you always generate a new blank row, such a holder could be re-used across multiple insertRow operations from the same ResultSet
The SQL state you added is CANNOT_INSERT_AT_CURRENT_POSITION, which in my thinking is a little misleading.
The text of the message describes the error better, so I wonder if the constant should be:
NOT_POSITIONED_ON_INSERT_ROW
There seems to be potential for code sharing in EmbedResultSet with the updateRow and deleteRow case, maybe once this patch is in that could be a further improvement.
Typically for tests when an expected exception is caught, its message and sql state are displayed to ensure the correct message is being returned.
And in all cases when you catch and display a SQL exception you should display the SQLState and the message, and walk down the SQLException chain using getNextException reporting all of them.
> Add support for insert functionality using JDBC 2.0 updatable resultset apis
> ----------------------------------------------------------------------------
>
> Key: DERBY-100
> URL: http://issues.apache.org/jira/browse/DERBY-100
> Project: Derby
> Type: New Feature
> Components: JDBC
> Versions: 10.1.1.0
> Reporter: Mamta A. Satoor
> Assignee: Fernanda Pizzorno
> Attachments: DERBY-100.diff, DERBY-100.stat
>
> The JDBC 2.0 API introduced the ability to update/delete/insert rows from a resultset using methods in the Java programming language rather than having to send an SQL command. This Jira entry is to track the insert rows functionality using JDBC 2.0 apis.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira