You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/07 01:09:32 UTC
[GitHub] [spark] Yikun opened a new pull request, #38138: [SPARK-40694][INFRA] Add permission to recover label job
Yikun opened a new pull request, #38138:
URL: https://github.com/apache/spark/pull/38138
### What changes were proposed in this pull request?
Add permission to recover label job
### Why are the changes needed?
I notice that some apache projects [added the `permissons` explictly](https://github.com/apache/beam/blob/master/.github/workflows/label_prs.yml#L26-L28), it doesn't be impacted by github action flaky.
In princinple, the default github action token permissons already [contains enough permissions](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token), but looks like it failed due to some reason recently (but I didn't notice any github official changes log yet and apache infra notification)
### Does this PR introduce _any_ user-facing change?
No, dev only
### How was this patch tested?
Frankly, we couldn't test it before merge because it not happened in fork repo, and also `pull_request_target` is only work after this merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #38138: [SPARK-40694][INFRA] Add permission to recover label job
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #38138:
URL: https://github.com/apache/spark/pull/38138#issuecomment-1270987576
local test: https://github.com/Yikun/spark/pull/176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #38138: [SPARK-40694][INFRA] Add permission to recover label job
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #38138:
URL: https://github.com/apache/spark/pull/38138#issuecomment-1270992261
https://github.com/apache/spark/pull/38140
<img width="914" alt="image" src="https://user-images.githubusercontent.com/1736354/194447032-8b240e9d-8dd1-4140-8417-2741ac3a4014.png">
label works as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38138: [SPARK-40694][INFRA] Add permission to recover label job
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38138:
URL: https://github.com/apache/spark/pull/38138#issuecomment-1270972315
Let's merge and see how it gose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #38138: [SPARK-40694][INFRA] Add permission to recover label job
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #38138:
URL: https://github.com/apache/spark/pull/38138#issuecomment-1270972891
I think label job / notify job / docker push job may also related this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #38138: [SPARK-40694][INFRA] Add permission to recover label job
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #38138:
URL: https://github.com/apache/spark/pull/38138#issuecomment-1270976566
Other useful PR: https://github.com/apache/beam/pull/23521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #38138: [SPARK-40694][INFRA] Add permission to recover label job
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #38138:
URL: https://github.com/apache/spark/pull/38138#issuecomment-1270974672
<img width="849" alt="image" src="https://user-images.githubusercontent.com/1736354/194445476-da3c5d37-ed1e-4321-b1f7-a44c933f6a7d.png">
We couldn't get pass result before pr merged (pull_request_target), so just let this merge first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38138: [SPARK-40694][INFRA] Add permission to recover label job
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38138: [SPARK-40694][INFRA] Add permission to recover label job
URL: https://github.com/apache/spark/pull/38138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38138: [SPARK-40694][INFRA] Add permission to recover label job
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38138:
URL: https://github.com/apache/spark/pull/38138#issuecomment-1270990367
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org