You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/02/20 02:19:39 UTC

[GitHub] [nifi] alopresto commented on a change in pull request #4062: NIFI-7030 Add Kerberos principal and password properties to Solr proc…

alopresto commented on a change in pull request #4062: NIFI-7030 Add Kerberos principal and password properties to Solr proc…
URL: https://github.com/apache/nifi/pull/4062#discussion_r381675449
 
 

 ##########
 File path: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrUtils.java
 ##########
 @@ -149,6 +151,25 @@
             .required(false)
             .build();
 
+    public static final PropertyDescriptor KERBEROS_PRINCIPAL = new PropertyDescriptor.Builder()
+            .name("Kerberos Principal")
 
 Review comment:
   Minor issue but I would use `.name("kerberos-principal")` and `.displayName("Kerberos Principal")` here. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services