You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/02 01:44:25 UTC
[GitHub] [pulsar] codelipenghui opened a new pull request, #16338: [improve][broker] Use shared broker client scheduled executor provider
codelipenghui opened a new pull request, #16338:
URL: https://github.com/apache/pulsar/pull/16338
### Motivation
#16334 supports passing scheduled executor to the client. Use a shared scheduled executor
for the broker clients which used by replicator and system topics.
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16338: [improve][broker] Use shared broker client scheduled executor provider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16338:
URL: https://github.com/apache/pulsar/pull/16338#issuecomment-1172810569
@codelipenghui Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on a diff in pull request #16338: [improve][broker] Use shared broker client scheduled executor provider
Posted by GitBox <gi...@apache.org>.
Jason918 commented on code in PR #16338:
URL: https://github.com/apache/pulsar/pull/16338#discussion_r912334996
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -543,6 +547,7 @@ public CompletableFuture<Void> closeAsync() {
brokerClientSharedExternalExecutorProvider.shutdownNow();
brokerClientSharedInternalExecutorProvider.shutdownNow();
+ brokerClientSharedExternalExecutorProvider.shutdownNow();
Review Comment:
```suggestion
brokerClientSharedScheduledExecutorProvider.shutdownNow();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #16338: [improve][broker] Use shared broker client scheduled executor provider
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #16338:
URL: https://github.com/apache/pulsar/pull/16338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org