You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "bkietz (via GitHub)" <gi...@apache.org> on 2023/06/22 12:15:23 UTC
[GitHub] [arrow] bkietz opened a new issue, #36240: [Python] Refactor CumulativeSumOptions to a separate class for independent deprecation
bkietz opened a new issue, #36240:
URL: https://github.com/apache/arrow/issues/36240
### Describe the enhancement requested
CumulativeSumOptions are renamed to CumulativeOptions in https://github.com/apache/arrow/pull/36020 after the introduction of cumulative functions other than `cumulative_sum` which reuse those options. For backward compatibility, [an alias](https://github.com/apache/arrow/pull/36020/commits/c61d6cf2df5a7c83a8aa4cbf51ed01c5d18165b6#diff-3d08757408024228c4443730cc3536ab39c9436cd2e4cb63e5da34c69c18962fR37) was added so that the name CumulativeSumOptions is still usable. However [per discussion on that PR](https://github.com/apache/arrow/pull/36020#discussion_r1238433064) the old name should be deprecated, which requires an explicit separate class.
### Component(s)
Python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] R-JunmingChen commented on issue #36240: [Python] Refactor CumulativeSumOptions to a separate class for independent deprecation
Posted by "R-JunmingChen (via GitHub)" <gi...@apache.org>.
R-JunmingChen commented on issue #36240:
URL: https://github.com/apache/arrow/issues/36240#issuecomment-1660193769
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF closed issue #36240: [Python] Refactor CumulativeSumOptions to a separate class for independent deprecation
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF closed issue #36240: [Python] Refactor CumulativeSumOptions to a separate class for independent deprecation
URL: https://github.com/apache/arrow/issues/36240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] R-JunmingChen commented on issue #36240: [Python] Refactor CumulativeSumOptions to a separate class for independent deprecation
Posted by "R-JunmingChen (via GitHub)" <gi...@apache.org>.
R-JunmingChen commented on issue #36240:
URL: https://github.com/apache/arrow/issues/36240#issuecomment-1643548812
Hi, I am not sure I am understand well. It seems that what we need to do is copy-paste `CumulativeOptions` and rename it to `CumulativeSumOptions`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org