You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@nutch.apache.org by "Sebastian Nagel (Jira)" <ji...@apache.org> on 2021/12/03 08:19:00 UTC

[jira] [Resolved] (NUTCH-2911) Add cleanup call in Fetcher.java

     [ https://issues.apache.org/jira/browse/NUTCH-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebastian Nagel resolved NUTCH-2911.
------------------------------------
    Resolution: Fixed

Thanks, [~prakharchaube]!

> Add cleanup call in Fetcher.java
> --------------------------------
>
>                 Key: NUTCH-2911
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2911
>             Project: Nutch
>          Issue Type: Improvement
>          Components: fetcher
>    Affects Versions: 1.18
>            Reporter: Prakhar Chaube
>            Priority: Minor
>              Labels: improvement
>             Fix For: 1.19
>
>
> Fetcher's inner class, FetcherRun overrides Hadoop Mapper's run().
> Even though Nutch's FetcherRun doesn't need an explicit call the Mapper's cleanup() (Which is a blank function), it would increase the readability and completeness of the run Method to do so.
> Ideally, every implementation of Mapper is supposed to do the following tasks:
> 1. Perform Setup
> 2.  Call map on the data set
> 3. Perform cleanups.
> Moreover, in case a custom Fetcher is written extending Fetcher.java cleanup could get easily missed out.
> PR for Fix: [here|https://github.com/apache/nutch/pull/708]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)