You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Brian Geffon <br...@gmail.com> on 2011/08/19 15:00:45 UTC

Please consider switching to hex thread IDs

Hi,
Currently when using TSDebug or Debug it will output integer thread
IDs, these are not helpful at all. Please consider switching to hex
thread ids, on the basis that GDB and valgrind will both represent
threads in hex. Attached is a patch.

Best,
Brian


--- lib/ts/Diags.cc	2011-08-16 13:32:12.982036370 -0700
+++ lib/ts/Diags.cc	2011-08-19 05:21:42.036238573 -0700
@@ -211,7 +211,7 @@

   // add the thread id
   pthread_t id = pthread_self();
-  end_of_format += snprintf(end_of_format, sizeof(format_buf), "{%"
PRIu64 "} ", (uint64_t) id);
+  end_of_format += snprintf(end_of_format, sizeof(format_buf), "{0x%"
PRIx64 "} ", (uint64_t) id);

   ////////////////////////////////
   // start with the user prefix //