You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Dmitry Zhuk <dz...@twopensource.com> on 2017/12/07 17:33:35 UTC
Review Request 64416: Moved tasks from completed frameworks during
agent reregistration.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64416/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Michael Park.
Repository: mesos
Description
-------
Moved tasks from completed frameworks during agent reregistration.
Diffs
-----
src/master/master.hpp 2658312b0d10a72fefda68c7d3137b94afbd8249
src/master/master.cpp 2fd66c072e9a194680d7653c664bd8a68ea1d2f0
Diff: https://reviews.apache.org/r/64416/diff/1/
Testing
-------
make check
Thanks,
Dmitry Zhuk
Re: Review Request 64416: Moved tasks from completed frameworks
during agent reregistration.
Posted by Dmitry Zhuk <dz...@twopensource.com>.
> On Dec. 7, 2017, 7:58 p.m., Benjamin Mahler wrote:
> > I also have a patch I was going to send out to eliminate these copies along with some others. I had taken an rvalue reference here, did you avoid that in order to support both callers that move and callers that do not?
Yes, this was the reason. Rvalue reference should also work here.
- Dmitry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64416/#review193154
-----------------------------------------------------------
On Dec. 7, 2017, 5:33 p.m., Dmitry Zhuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64416/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2017, 5:33 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved tasks from completed frameworks during agent reregistration.
>
>
> Diffs
> -----
>
> src/master/master.hpp 2658312b0d10a72fefda68c7d3137b94afbd8249
> src/master/master.cpp 2fd66c072e9a194680d7653c664bd8a68ea1d2f0
>
>
> Diff: https://reviews.apache.org/r/64416/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dmitry Zhuk
>
>
Re: Review Request 64416: Moved tasks from completed frameworks
during agent reregistration.
Posted by Benjamin Mahler <bm...@apache.org>.
> On Dec. 7, 2017, 7:58 p.m., Benjamin Mahler wrote:
> > I also have a patch I was going to send out to eliminate these copies along with some others. I had taken an rvalue reference here, did you avoid that in order to support both callers that move and callers that do not?
>
> Dmitry Zhuk wrote:
> Yes, this was the reason. Rvalue reference should also work here.
Here's where I used an rvalue reference and eliminated some other copies: https://reviews.apache.org/r/64428/
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64416/#review193154
-----------------------------------------------------------
On Dec. 7, 2017, 5:33 p.m., Dmitry Zhuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64416/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2017, 5:33 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved tasks from completed frameworks during agent reregistration.
>
>
> Diffs
> -----
>
> src/master/master.hpp 2658312b0d10a72fefda68c7d3137b94afbd8249
> src/master/master.cpp 2fd66c072e9a194680d7653c664bd8a68ea1d2f0
>
>
> Diff: https://reviews.apache.org/r/64416/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dmitry Zhuk
>
>
Re: Review Request 64416: Moved tasks from completed frameworks
during agent reregistration.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64416/#review193154
-----------------------------------------------------------
I also have a patch I was going to send out to eliminate these copies along with some others. I had taken an rvalue reference here, did you avoid that in order to support both callers that move and callers that do not?
- Benjamin Mahler
On Dec. 7, 2017, 5:33 p.m., Dmitry Zhuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64416/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2017, 5:33 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved tasks from completed frameworks during agent reregistration.
>
>
> Diffs
> -----
>
> src/master/master.hpp 2658312b0d10a72fefda68c7d3137b94afbd8249
> src/master/master.cpp 2fd66c072e9a194680d7653c664bd8a68ea1d2f0
>
>
> Diff: https://reviews.apache.org/r/64416/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dmitry Zhuk
>
>