You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "oneby-wang (via GitHub)" <gi...@apache.org> on 2026/06/06 14:24:45 UTC

[PR] KAFKA-20668: Add --checkpoint option to kafka-metadata-shell [kafka]

oneby-wang opened a new pull request, #22494:
URL: https://github.com/apache/kafka/pull/22494

   The metadata shell currently exposes `--snapshot` for selecting the metadata file to read, but the files users should pass to this tool use the `.checkpoint` suffix. This adds `--checkpoint` as the preferred option while keeping `--snapshot` and `-s` as deprecated aliases for compatibility.
   
   The command-line parsing is now factored into package-private helpers so that the CLI behavior can be tested without invoking `main`, `Exit.exit`, or loading a real checkpoint. The new tests cover parsing the new option, preserving shell commands, accepting the deprecated aliases with a warning, rejecting simultaneous new and old options, and failing when no checkpoint option is provided.
   
   The KRaft operations documentation now shows `--checkpoint` in the metadata shell example.
   
   Testing:
   
   - `./gradlew :shell:test --tests org.apache.kafka.shell.MetadataShellTest`
   - `./gradlew :shell:test --tests org.apache.kafka.shell.MetadataShellIntegrationTest`
   - `./gradlew :shell:check`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20668: Add --checkpoint option to kafka-metadata-shell [kafka]

Posted by "oneby-wang (via GitHub)" <gi...@apache.org>.
oneby-wang commented on PR #22494:
URL: https://github.com/apache/kafka/pull/22494#issuecomment-4704069943

   Hi @lianetm ,
   
   Thanks for the guidance. I have already applied for a Wiki account, but I currently don't have edit permissions.
   
   My account details are:
   
   - Username: onebywang
   - Full Name: Oneby Wang
   - Email: oneby-wang@qq.com
   
   Could you please help grant me the necessary Wiki edit permissions so that I can follow the KIP process? Thanks a lot!
   
   Best!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20668: Add --checkpoint option to kafka-metadata-shell [kafka]

Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on PR #22494:
URL: https://github.com/apache/kafka/pull/22494#issuecomment-4721629536

   All set now @oneby-wang


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20668: Add --checkpoint option to kafka-metadata-shell [kafka]

Posted by "oneby-wang (via GitHub)" <gi...@apache.org>.
oneby-wang commented on PR #22494:
URL: https://github.com/apache/kafka/pull/22494#issuecomment-4901259788

   Hi @lianetm ,
   
   Sorry for the late update, and thanks for the guidance. I created KIP-1363 and started the DISCUSS thread on the dev mailing list.
   
   KIP: https://cwiki.apache.org/confluence/spaces/KAFKA/pages/440303769/KIP-1363+Add+--checkpoint+option+to+kafka-metadata-shell+and+deprecate+--snapshot
   DISCUSS thread: https://lists.apache.org/thread/4v956z757qyyylnp1zf2bvkm8kyzlghl
   
   Best,
   Oneby Wang


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20668: Add --checkpoint option to kafka-metadata-shell [kafka]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22494:
URL: https://github.com/apache/kafka/pull/22494#issuecomment-4850295467

   A label of 'needs-attention' was automatically added to this PR in order to raise the
   attention of the committers. Once this issue has been triaged, the `triage` label
   should be removed to prevent this automation from happening again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20668: Add --checkpoint option to kafka-metadata-shell [kafka]

Posted by "oneby-wang (via GitHub)" <gi...@apache.org>.
oneby-wang commented on PR #22494:
URL: https://github.com/apache/kafka/pull/22494#issuecomment-4714246576

   Hi @lianetm, I received the password reset email last Friday, completed the password reset, and have been able to log in to Confluence successfully.
   
   Is there any additional action required from my side? I'm not sure why the account is still not showing as active. Here is the profile screenshot.
   
   <img width="526" height="362" alt="image" src="https://github.com/user-attachments/assets/23944472-d2da-43df-adc3-607c3e8da0a5" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20668: Add --checkpoint option to kafka-metadata-shell [kafka]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22494:
URL: https://github.com/apache/kafka/pull/22494#issuecomment-4738064758

   A label of 'needs-attention' was automatically added to this PR in order to raise the
   attention of the committers. Once this issue has been triaged, the `triage` label
   should be removed to prevent this automation from happening again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20668: Add --checkpoint option to kafka-metadata-shell [kafka]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22494:
URL: https://github.com/apache/kafka/pull/22494#issuecomment-4700706144

   A label of 'needs-attention' was automatically added to this PR in order to raise the
   attention of the committers. Once this issue has been triaged, the `triage` label
   should be removed to prevent this automation from happening again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20668: Add --checkpoint option to kafka-metadata-shell [kafka]

Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on PR #22494:
URL: https://github.com/apache/kafka/pull/22494#issuecomment-4709153313

   Hey @oneby-wang , I see your Confluence account was approved Thu (but I don't see it active yet indeed). You should have an email to follow this step, could you check?
   > An email has been sent to the email address provided and this new user will
   need to reset their password before logging in for the first time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20668: Add --checkpoint option to kafka-metadata-shell [kafka]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22494:
URL: https://github.com/apache/kafka/pull/22494#issuecomment-4715039094

   A label of 'needs-attention' was automatically added to this PR in order to raise the
   attention of the committers. Once this issue has been triaged, the `triage` label
   should be removed to prevent this automation from happening again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20668: Add --checkpoint option to kafka-metadata-shell [kafka]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22494:
URL: https://github.com/apache/kafka/pull/22494#issuecomment-4921555516

   A label of 'needs-attention' was automatically added to this PR in order to raise the
   attention of the committers. Once this issue has been triaged, the `triage` label
   should be removed to prevent this automation from happening again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20668: Add --checkpoint option to kafka-metadata-shell [kafka]

Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on PR #22494:
URL: https://github.com/apache/kafka/pull/22494#issuecomment-4662521574

   Hi @oneby-wang , this would need a KIP (changes a command line tool argument, public API). Here are the steps https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals#KafkaImprovementProposals-Process
   Best!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org