You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2025/05/23 12:49:02 UTC
(superset) 06/08: fix(table): table sort by fix (#33540)
This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch 5.0
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 405fcfc5b1491b9fa69df8d7c77cf5e22f2d55f8
Author: amaannawab923 <am...@gmail.com>
AuthorDate: Wed May 21 18:30:25 2025 +0530
fix(table): table sort by fix (#33540)
Co-authored-by: Amaan Nawab <ne...@gmail.com>
Co-authored-by: Geido <60...@users.noreply.github.com>
---
.../plugin-chart-table/src/controlPanel.tsx | 35 ++++++++++++----------
1 file changed, 20 insertions(+), 15 deletions(-)
diff --git a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
index ef3a8e700c..ee3c43a0ec 100644
--- a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
+++ b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
@@ -326,6 +326,26 @@ const config: ControlPanelConfig = {
},
},
],
+ [
+ {
+ name: 'order_desc',
+ config: {
+ type: 'CheckboxControl',
+ label: t('Sort descending'),
+ default: true,
+ description: t(
+ 'If enabled, this control sorts the results/values descending, otherwise it sorts the results ascending.',
+ ),
+ visibility: ({ controls }: ControlPanelsContainerProps) => {
+ const hasSortMetric = Boolean(
+ controls?.timeseries_limit_metric?.value,
+ );
+ return hasSortMetric && isAggMode({ controls });
+ },
+ resetOnHide: false,
+ },
+ },
+ ],
[
{
name: 'server_pagination',
@@ -362,21 +382,6 @@ const config: ControlPanelConfig = {
},
},
],
- [
- {
- name: 'order_desc',
- config: {
- type: 'CheckboxControl',
- label: t('Sort descending'),
- default: true,
- description: t(
- 'If enabled, this control sorts the results/values descending, otherwise it sorts the results ascending.',
- ),
- visibility: isAggMode,
- resetOnHide: false,
- },
- },
- ],
[
{
name: 'show_totals',