You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hys9958 <gi...@git.apache.org> on 2015/03/13 15:09:55 UTC

[GitHub] tajo pull request: TAJO-1400: Add TajoStatement::setMaxRows method...

GitHub user hys9958 opened a pull request:

    https://github.com/apache/tajo/pull/421

    TAJO-1400: Add TajoStatement::setMaxRows method support

    I implemented the setMaxRows and getMaxRows method support.
    Please review my patch.
    
    thanks.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hys9958/tajo TAJO-1400

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/421.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #421
    
----
commit b1d30b577ab68f8beac85ed447094c464064e938
Author: HANYOUNSU <ha...@hanyounsuui-macbook-pro.local>
Date:   2015-03-13T14:00:54Z

    TAJO-1400: Add TajoStatement::setMaxRows method support

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1400: Add TajoStatement::setMaxRows method...

Posted by hys9958 <gi...@git.apache.org>.
Github user hys9958 commented on the pull request:

    https://github.com/apache/tajo/pull/421#issuecomment-88016070
  
    Hi @jihoonson ,
    Query return value is 'java.sql.ResultSet' interfase in TajoStatement. It need to many refactoring.
    And i'll also another patch about getMoreResults. When the getMoreResults patch time, i update maxRows.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1400: Add TajoStatement::setMaxRows method...

Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:

    https://github.com/apache/tajo/pull/421#issuecomment-89543503
  
    Ok. Here is my +1.
    If there are no objections, I'll commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1400: Add TajoStatement::setMaxRows method...

Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:

    https://github.com/apache/tajo/pull/421#issuecomment-87570820
  
    +1
    Thanks for your contribution!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1400: Add TajoStatement::setMaxRows method...

Posted by hys9958 <gi...@git.apache.org>.
Github user hys9958 commented on the pull request:

    https://github.com/apache/tajo/pull/421#issuecomment-84359409
  
    Ok, jihoonson,
    I'll update the TestTajoJDBC for unit tests of this issue soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1400: Add TajoStatement::setMaxRows method...

Posted by hys9958 <gi...@git.apache.org>.
Github user hys9958 commented on the pull request:

    https://github.com/apache/tajo/pull/421#issuecomment-87581798
  
    @jinossy Ok, It's better idea.
    I'll re-patch the implementation of maxRows(). :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1400: Add TajoStatement::setMaxRows method...

Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:

    https://github.com/apache/tajo/pull/421#issuecomment-87576081
  
    @jinossy thanks for the good suggestion.
    It would be a better implementation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1400: Add TajoStatement::setMaxRows method...

Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:

    https://github.com/apache/tajo/pull/421#issuecomment-87574590
  
    @hys9958 
    How do you think that move the setMaxRows() to TajoStatement ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1400: Add TajoStatement::setMaxRows method...

Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:

    https://github.com/apache/tajo/pull/421#issuecomment-87582032
  
    @hys9958 thanks. I'll wait for the next patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1400: Add TajoStatement::setMaxRows method...

Posted by hys9958 <gi...@git.apache.org>.
Github user hys9958 closed the pull request at:

    https://github.com/apache/tajo/pull/421


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1400: Add TajoStatement::setMaxRows method...

Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/421#issuecomment-82117286
  
    Thank you for your contribution.
    I'll review the patch today. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1400: Add TajoStatement::setMaxRows method...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/421


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1400: Add TajoStatement::setMaxRows method...

Posted by hys9958 <gi...@git.apache.org>.
GitHub user hys9958 reopened a pull request:

    https://github.com/apache/tajo/pull/421

    TAJO-1400: Add TajoStatement::setMaxRows method support

    I implemented the setMaxRows and getMaxRows method support.
    Please review my patch.
    
    thanks.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hys9958/tajo TAJO-1400

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/421.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #421
    
----
commit b1d30b577ab68f8beac85ed447094c464064e938
Author: HANYOUNSU <ha...@hanyounsuui-macbook-pro.local>
Date:   2015-03-13T14:00:54Z

    TAJO-1400: Add TajoStatement::setMaxRows method support

commit 75cc76ae3ae64a6415449eb6e4a22288467fd529
Author: Yeonsu Han <ha...@gmail.com>
Date:   2015-03-28T06:32:08Z

    TAJO-1400: Add TajoStatement::setMaxRows method support(add unit test)

commit 4e99550e15a84dac9ee9606eb735741b5c9626a2
Author: Yeonsu Han <ha...@gmail.com>
Date:   2015-03-28T07:09:12Z

    TAJO-1400: Add TajoStatement::setMaxRows method support(add unit test)

commit 6e22369e1db1c4e7562770a6721182170fe167a1
Author: Yeonsu Han <ha...@gmail.com>
Date:   2015-03-30T05:48:33Z

    TAJO-1400: Add TajoStatement::setMaxRows method support(add unit test)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1400: Add TajoStatement::setMaxRows method...

Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:

    https://github.com/apache/tajo/pull/421#issuecomment-84292092
  
    Would you add some unit tests?
    TestTajoJDBC will be good to add tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---