You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/12 19:39:11 UTC

[GitHub] [arrow] vfraga opened a new pull request #12135: ARROW-15315: [Java] [FlightRPC] FlightSqlProducer#doAction always throws INVALID_ARGUMENT

vfraga opened a new pull request #12135:
URL: https://github.com/apache/arrow/pull/12135


   Even if the Action exists, since there is a missing return/else block, an exception is always thrown.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] vfraga commented on pull request #12135: ARROW-15315: [Java] [FlightRPC] FlightSqlProducer#doAction always throws INVALID_ARGUMENT

Posted by GitBox <gi...@apache.org>.
vfraga commented on pull request #12135:
URL: https://github.com/apache/arrow/pull/12135#issuecomment-1011396404


   @lidavidm I couldn't get the assignee on Jira. Can you have a quick look on this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12135: ARROW-15315: [Java] [FlightRPC] FlightSqlProducer#doAction always throws INVALID_ARGUMENT

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12135:
URL: https://github.com/apache/arrow/pull/12135#issuecomment-1012548470


   Benchmark runs are scheduled for baseline = 270416b0d071030bc2ce64adde40df83356c3d2f and contender = b4143d309c71c0247c056471a27fa7f03034cc76. b4143d309c71c0247c056471a27fa7f03034cc76 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/00f7cfae45ca41c0bd8d53f920a6c935...6e68d610ae43427c8f36c0777c01220a/)
   [Failed :arrow_down:0.0% :arrow_up:0.9%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/148ccc0978f74e40b63e7ed9ae2cb822...f5d2c165ca544080b808c14abbf339ca/)
   [Finished :arrow_down:0.35% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/904cfa2e1ed14df38503752220a92bc6...95d95eb34121477b93c80ca66e5f4bbf/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] vfraga commented on pull request #12135: ARROW-15315: [Java] [FlightRPC] FlightSqlProducer#doAction always throws INVALID_ARGUMENT

Posted by GitBox <gi...@apache.org>.
vfraga commented on pull request #12135:
URL: https://github.com/apache/arrow/pull/12135#issuecomment-1012458189


   > Hmm, why was this not caught in either unit tests or integration tests? Can we make sure this is covered by one of the two?
   
   @lidavidm Seems like [this](https://github.com/apache/arrow/blob/master/java/flight/flight-core/src/main/java/org/apache/arrow/flight/FlightService.java#L128) was the probable cause, since our test producer isn't asynchronous. I've updated our tests to ensure a proper doAction().
   We have 7 tests that can properly ensure this now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm closed pull request #12135: ARROW-15315: [Java] [FlightRPC] FlightSqlProducer#doAction always throws INVALID_ARGUMENT

Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #12135:
URL: https://github.com/apache/arrow/pull/12135


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #12135: ARROW-15315: [Java] [FlightRPC] FlightSqlProducer#doAction always throws INVALID_ARGUMENT

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12135:
URL: https://github.com/apache/arrow/pull/12135#issuecomment-1012548470


   Benchmark runs are scheduled for baseline = 270416b0d071030bc2ce64adde40df83356c3d2f and contender = b4143d309c71c0247c056471a27fa7f03034cc76. b4143d309c71c0247c056471a27fa7f03034cc76 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/00f7cfae45ca41c0bd8d53f920a6c935...6e68d610ae43427c8f36c0777c01220a/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/148ccc0978f74e40b63e7ed9ae2cb822...f5d2c165ca544080b808c14abbf339ca/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/904cfa2e1ed14df38503752220a92bc6...95d95eb34121477b93c80ca66e5f4bbf/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm commented on pull request #12135: ARROW-15315: [Java] [FlightRPC] FlightSqlProducer#doAction always throws INVALID_ARGUMENT

Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12135:
URL: https://github.com/apache/arrow/pull/12135#issuecomment-1011426960


   (I've given you Jira permissions, you should be able to self-assign issues from now on.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12135: ARROW-15315: [Java] [FlightRPC] FlightSqlProducer#doAction always throws INVALID_ARGUMENT

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12135:
URL: https://github.com/apache/arrow/pull/12135#issuecomment-1012548470


   Benchmark runs are scheduled for baseline = 270416b0d071030bc2ce64adde40df83356c3d2f and contender = b4143d309c71c0247c056471a27fa7f03034cc76. b4143d309c71c0247c056471a27fa7f03034cc76 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/00f7cfae45ca41c0bd8d53f920a6c935...6e68d610ae43427c8f36c0777c01220a/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/148ccc0978f74e40b63e7ed9ae2cb822...f5d2c165ca544080b808c14abbf339ca/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/904cfa2e1ed14df38503752220a92bc6...95d95eb34121477b93c80ca66e5f4bbf/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12135: ARROW-15315: [Java] [FlightRPC] FlightSqlProducer#doAction always throws INVALID_ARGUMENT

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12135:
URL: https://github.com/apache/arrow/pull/12135#issuecomment-1012548470


   Benchmark runs are scheduled for baseline = 270416b0d071030bc2ce64adde40df83356c3d2f and contender = b4143d309c71c0247c056471a27fa7f03034cc76. b4143d309c71c0247c056471a27fa7f03034cc76 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/00f7cfae45ca41c0bd8d53f920a6c935...6e68d610ae43427c8f36c0777c01220a/)
   [Failed :arrow_down:0.0% :arrow_up:0.9%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/148ccc0978f74e40b63e7ed9ae2cb822...f5d2c165ca544080b808c14abbf339ca/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/904cfa2e1ed14df38503752220a92bc6...95d95eb34121477b93c80ca66e5f4bbf/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #12135: ARROW-15315: [Java] [FlightRPC] FlightSqlProducer#doAction always throws INVALID_ARGUMENT

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12135:
URL: https://github.com/apache/arrow/pull/12135#issuecomment-1011388796






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org