[GitHub] [pulsar] merlimat commented on a change in pull request #13057: [Producer] Change the time units from ns to ms

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #13057:
URL: https://github.com/apache/pulsar/pull/13057#discussion_r759579222



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##########
@@ -1223,13 +1223,13 @@ void sendComplete(final Exception e) {
                 if (finalEx != null && finalEx instanceof TimeoutException) {
                     TimeoutException te = (TimeoutException) e;
                     long sequenceId = te.getSequenceId();
-                    long ns = System.nanoTime();
+                    long ms = System.currentTimeMillis();
                     String errMsg = String.format(
-                        "%s : createdAt %s ns ago, firstSentAt %s ns ago, lastSentAt %s ns ago, retryCount %s",
+                        "%s : createdAt %s ms ago, firstSentAt %s ms ago, lastSentAt %s ms ago, retryCount %s",

Review comment:
       We should actually present this in seconds here. eg: `created 30.001 sec ago`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org