You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "izveigor (via GitHub)" <gi...@apache.org> on 2023/05/04 11:44:22 UTC
[GitHub] [arrow-rs] izveigor opened a new pull request, #4167: feat: support extended pow arithmetic
izveigor opened a new pull request, #4167:
URL: https://github.com/apache/arrow-rs/pull/4167
# Which issue does this PR close?
Closes #4166
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
Yes
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #4167: feat: support extended pow arithmetic
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4167:
URL: https://github.com/apache/arrow-rs/pull/4167#issuecomment-1540460221
Sorry for taking so long to get back to you on this, I'm honestly not sure about this. The current support for pow is pretty half-baked and I kind of feel rather than plowing on and piling on yet more complexity, it is worth taking a step back and reassessing how these kernels are currently setup (#3999).
I have filed #4187 to remove the powf_scalar kernel, as to be completely honest I'm not really sure why it is there at all :sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] izveigor closed pull request #4167: feat: support extended pow arithmetic
Posted by "izveigor (via GitHub)" <gi...@apache.org>.
izveigor closed pull request #4167: feat: support extended pow arithmetic
URL: https://github.com/apache/arrow-rs/pull/4167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org