You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Roger Whitcomb (Created) (JIRA)" <ji...@apache.org> on 2011/11/06 05:44:51 UTC
[jira] [Created] (PIVOT-817) Implement "borderThickness" style for
TerraPushButtonSkin
Implement "borderThickness" style for TerraPushButtonSkin
---------------------------------------------------------
Key: PIVOT-817
URL: https://issues.apache.org/jira/browse/PIVOT-817
Project: Pivot
Issue Type: Improvement
Components: wtk-terra
Affects Versions: 2.0.1
Environment: Windows XP SP3, JDK 1.6.0_16
Reporter: Roger Whitcomb
Assignee: Roger Whitcomb
Priority: Trivial
Fix For: 2.0.1
In order to somewhat simulate the appearance of the "default" button on Windows, which has a thicker border, it would be nice to be able to set the border thickness of a PushButton to something bigger than one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-817) Implement "borderThickness" style
for TerraPushButtonSkin
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285507#comment-13285507 ]
Sandro Martini commented on PIVOT-817:
--------------------------------------
Hi Roger, do you need this for 2.0.3 (as seen in the new Due Date) ?
> Implement "borderThickness" style for TerraPushButtonSkin
> ---------------------------------------------------------
>
> Key: PIVOT-817
> URL: https://issues.apache.org/jira/browse/PIVOT-817
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_16
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Labels: pushbutton,, thickness
> Fix For: 2.1
>
> Attachments: thick.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> In order to somewhat simulate the appearance of the "default" button on Windows, which has a thicker border, it would be nice to be able to set the border thickness of a PushButton to something bigger than one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-817) Implement "borderThickness" style
for TerraPushButtonSkin
Posted by "Roger Whitcomb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285802#comment-13285802 ]
Roger Whitcomb commented on PIVOT-817:
--------------------------------------
If it looked "right", that is, the same way Windows buttons do, then yes, I would use it. I don't "need" it by any particular date, since we just are releasing the product and it is unclear when the next release will be. I updated the due date just to get it off the top of the TO DO list. But, the due date could be erased, and it could be moved to 2.1 as well.
> Implement "borderThickness" style for TerraPushButtonSkin
> ---------------------------------------------------------
>
> Key: PIVOT-817
> URL: https://issues.apache.org/jira/browse/PIVOT-817
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_16
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Labels: pushbutton,, thickness
> Fix For: 2.1
>
> Attachments: thick.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> In order to somewhat simulate the appearance of the "default" button on Windows, which has a thicker border, it would be nice to be able to set the border thickness of a PushButton to something bigger than one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-817) Implement "borderThickness" style for
TerraPushButtonSkin
Posted by "Roger Whitcomb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Whitcomb updated PIVOT-817:
---------------------------------
Due Date: 31/Jul/12 (was: 30/Dec/11)
This needs a lot more thought. The simple "solution" looks terrible.
> Implement "borderThickness" style for TerraPushButtonSkin
> ---------------------------------------------------------
>
> Key: PIVOT-817
> URL: https://issues.apache.org/jira/browse/PIVOT-817
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_16
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Labels: pushbutton,, thickness
> Fix For: 2.1
>
> Attachments: thick.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> In order to somewhat simulate the appearance of the "default" button on Windows, which has a thicker border, it would be nice to be able to set the border thickness of a PushButton to something bigger than one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-817) Implement "borderThickness" style for
TerraPushButtonSkin
Posted by "Roger Whitcomb (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Whitcomb updated PIVOT-817:
---------------------------------
Due Date: 30/Dec/11 (was: 7/Nov/11)
Priority: Minor (was: Trivial)
Fix Version/s: (was: 2.0.1)
2.1
Remaining Estimate: 168h (was: 1h)
Original Estimate: 168h (was: 1h)
There appears to be a visual problem with this fix when width is 2 (maybe something to do with antialiasing?), and width of 3 or greater just doesn't look good, at least not the way the Windows buttons look that I was trying to emulate. So, I'm going to rethink the solution.
Postponing for a later release.
> Implement "borderThickness" style for TerraPushButtonSkin
> ---------------------------------------------------------
>
> Key: PIVOT-817
> URL: https://issues.apache.org/jira/browse/PIVOT-817
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_16
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Labels: pushbutton,, thickness
> Fix For: 2.1
>
> Attachments: thick.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> In order to somewhat simulate the appearance of the "default" button on Windows, which has a thicker border, it would be nice to be able to set the border thickness of a PushButton to something bigger than one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-817) Implement "borderThickness" style for
TerraPushButtonSkin
Posted by "Roger Whitcomb (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Whitcomb updated PIVOT-817:
---------------------------------
Attachment: thick.patch
This patch implements the functionality, but there may be drawing problems when the thickness is 2. A value of 3 seems to be fine (as is the default of 1). Also, the focus rectangle doesn't do what I thought it would with the thick border either (it is in the same relative position as with a default border).
So, someone should look over the changes to see if I've done something strange in the drawing code. Maybe all the + 2 and +1 and -1 values didn't all have to do with the border thickness...
> Implement "borderThickness" style for TerraPushButtonSkin
> ---------------------------------------------------------
>
> Key: PIVOT-817
> URL: https://issues.apache.org/jira/browse/PIVOT-817
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_16
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Trivial
> Labels: pushbutton,, thickness
> Fix For: 2.0.1
>
> Attachments: thick.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> In order to somewhat simulate the appearance of the "default" button on Windows, which has a thicker border, it would be nice to be able to set the border thickness of a PushButton to something bigger than one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-817) Implement "borderThickness" style for
TerraPushButtonSkin
Posted by "Roger Whitcomb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Whitcomb updated PIVOT-817:
---------------------------------
Due Date: (was: 31/Jul/12)
The idea was to be able to make buttons look more like Windows buttons (the "default button" look), but the timeframe was unrealistic.
> Implement "borderThickness" style for TerraPushButtonSkin
> ---------------------------------------------------------
>
> Key: PIVOT-817
> URL: https://issues.apache.org/jira/browse/PIVOT-817
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_16
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Labels: pushbutton,, thickness
> Fix For: 2.1
>
> Attachments: thick.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> In order to somewhat simulate the appearance of the "default" button on Windows, which has a thicker border, it would be nice to be able to set the border thickness of a PushButton to something bigger than one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira