You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/06/01 17:27:00 UTC
[jira] [Commented] (ARTEMIS-1892) Allow whitespace in
[ https://issues.apache.org/jira/browse/ARTEMIS-1892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498291#comment-16498291 ]
ASF GitHub Bot commented on ARTEMIS-1892:
-----------------------------------------
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2120
ARTEMIS-1892 allow whitespace in acceptor and connector URIs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1892
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2120.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2120
----
commit b3f9f51b1d507b4dea2894aeef78fd515c0fcf4e
Author: Justin Bertram <jb...@...>
Date: 2018-06-01T17:26:12Z
ARTEMIS-1892 allow whitespace in acceptor and connector URIs
----
> Allow whitespace in <acceptor>
> ------------------------------
>
> Key: ARTEMIS-1892
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1892
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Lionel Cons
> Priority: Minor
>
> When tuning the acceptors, the {{<acceptor>}} elements can quickly become very long and hard to read.
> Here is an example from the default configuration:
> {code}
> <!-- Acceptor for every supported protocol -->
> <acceptor name="artemis">tcp://0.0.0.0:61616?tcpSendBufferSize=1048576;tcpReceiveBufferSize=1048576;protocols=CORE,AMQP,STOMP,HORNETQ,MQTT,OPENWIRE;useEpoll=true;amqpCredits=1000;amqpLowCredits=300</acceptor>
> {code}
> It would be nice to be able to add whitespace to make the {{broker.xml}} easier to read and manage. For instance:
> {code}
> <!-- Acceptor for every supported protocol -->
> <acceptor name="artemis">
> tcp://0.0.0.0:61616?
> tcpSendBufferSize=1048576;
> tcpReceiveBufferSize=1048576;
> protocols=CORE,AMQP,STOMP,HORNETQ,MQTT,OPENWIRE;
> useEpoll=true;
> amqpCredits=1000;
> amqpLowCredits=300
> </acceptor>
> {code}
> It seems that stripping whitespace from the {{<acceptor>}} elements text should be enough to make it work...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)