You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by xi...@apache.org on 2021/12/15 00:10:35 UTC

[pinot] branch master updated: App assembler script should check that the correct delimiter is used for plugin related env vars (#7905)

This is an automated email from the ASF dual-hosted git repository.

xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new c8071f7  App assembler script should check that the correct delimiter is used for plugin related env vars (#7905)
c8071f7 is described below

commit c8071f79aec4a9cb2cab3a09c7a6ade97fd3ae01
Author: priyen <pr...@mail.utoronto.ca>
AuthorDate: Tue Dec 14 19:10:18 2021 -0500

    App assembler script should check that the correct delimiter is used for plugin related env vars (#7905)
    
    Co-authored-by: Priyen Patel <pr...@stripe.com>
---
 pinot-tools/src/main/resources/appAssemblerScriptTemplate | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/pinot-tools/src/main/resources/appAssemblerScriptTemplate b/pinot-tools/src/main/resources/appAssemblerScriptTemplate
index 03e7ab7..e3e35e3 100644
--- a/pinot-tools/src/main/resources/appAssemblerScriptTemplate
+++ b/pinot-tools/src/main/resources/appAssemblerScriptTemplate
@@ -115,6 +115,12 @@ fi
 if [ -z "$PLUGINS_CLASSPATH" ] ; then
   if [ -z "$PLUGINS_DIR" ] ; then
     PLUGINS_DIR="$BASEDIR"/plugins
+  else
+    if [[ "$PLUGINS_DIR" = *,* ]]
+    then
+        echo "\$PLUGINS_DIR should use ; as the delimiter"
+        exit 1
+    fi
   fi
 
   export IFS=';'
@@ -122,6 +128,11 @@ if [ -z "$PLUGINS_CLASSPATH" ] ; then
     if [ -d "$DIR" ] ; then
       unset IFS
       if [ -n "$PLUGINS_INCLUDE" ] ; then
+        if [[ "$PLUGINS_INCLUDE" = *,* ]]
+        then
+            echo "\$PLUGINS_INCLUDE should use ; as the delimiter"
+            exit 1
+        fi
         export IFS=';'
         for PLUGIN_JAR in $PLUGINS_INCLUDE; do
             PLUGIN_JAR_PATH=$(find "$DIR" -path \*/"$PLUGIN_JAR"/"$PLUGIN_JAR"-\*.jar)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org