You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by pm...@apache.org on 2013/05/03 18:20:46 UTC
weinre commit: [CB-3319] - Chrome is setting window properties which
now breaks Weinre
Updated Branches:
refs/heads/master 7b1aa6c3f -> e1370bae3
[CB-3319] - Chrome is setting window properties which now breaks Weinre
https://issues.apache.org/jira/browse/CB-3319
removed the code which places the Web Inspector domain interfaces
into properties of window
Project: http://git-wip-us.apache.org/repos/asf/cordova-weinre/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-weinre/commit/e1370bae
Tree: http://git-wip-us.apache.org/repos/asf/cordova-weinre/tree/e1370bae
Diff: http://git-wip-us.apache.org/repos/asf/cordova-weinre/diff/e1370bae
Branch: refs/heads/master
Commit: e1370bae3e067a7c23ae91fdfc337d45644d4dde
Parents: 7b1aa6c
Author: Patrick Mueller <pm...@apache.org>
Authored: Fri May 3 12:19:59 2013 -0400
Committer: Patrick Mueller <pm...@apache.org>
Committed: Fri May 3 12:19:59 2013 -0400
----------------------------------------------------------------------
weinre.doc/ChangeLog.body.html | 1 +
.../weinre/client/InspectorBackendImpl.coffee | 5 -----
2 files changed, 1 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-weinre/blob/e1370bae/weinre.doc/ChangeLog.body.html
----------------------------------------------------------------------
diff --git a/weinre.doc/ChangeLog.body.html b/weinre.doc/ChangeLog.body.html
index 1849d5a..6a0b4b3 100644
--- a/weinre.doc/ChangeLog.body.html
+++ b/weinre.doc/ChangeLog.body.html
@@ -53,6 +53,7 @@
<li><a href="https://issues.apache.org/jira/browse/CB-1193">CB-1193</a> - add Windows Phone support
<li><a href="https://issues.apache.org/jira/browse/CB-1800">CB-1800</a> - remove references to "incubator"
<li><a href="https://issues.apache.org/jira/browse/CB-1494">CB-1494</a> - Supports running server behind a proxy, such as Heroku Cedar
+<li><a href="https://issues.apache.org/jira/browse/CB-3319">CB-3319</a> - Chrome is setting window properties which now breaks Weinre
<li><a href="https://issues.apache.org/jira/browse/CB-3328">CB-3328</a> - chrome version >= 27 breaks flex-box usage
</ul>
http://git-wip-us.apache.org/repos/asf/cordova-weinre/blob/e1370bae/weinre.web/modules/weinre/client/InspectorBackendImpl.coffee
----------------------------------------------------------------------
diff --git a/weinre.web/modules/weinre/client/InspectorBackendImpl.coffee b/weinre.web/modules/weinre/client/InspectorBackendImpl.coffee
index 8a7cabb..ef5a70d 100644
--- a/weinre.web/modules/weinre/client/InspectorBackendImpl.coffee
+++ b/weinre.web/modules/weinre/client/InspectorBackendImpl.coffee
@@ -51,18 +51,13 @@ module.exports = class InspectorBackendImpl
for intfName in intfNames
proxy = Weinre.messageDispatcher.createProxy(intfName)
- if window[intfName]
- throw new Ex(arguments, "backend interface '#{intfName}' already created")
-
intf = IDLTools.getIDL(intfName)
unless intf
throw new Ex(arguments, "interface not registered: '#{intfName}'")
- window[intfName] = {}
for method in intf.methods
proxyMethod = InspectorBackendImpl.getProxyMethod(proxy, method)
InspectorBackendImpl::[method.name] = proxyMethod
- window[intfName][method.name] = proxyMethod
#---------------------------------------------------------------------------
@getProxyMethod: (proxy, method) ->