You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by "XiaoyuGeng (Jira)" <ji...@apache.org> on 2023/02/07 15:03:00 UTC

[jira] [Commented] (HUDI-5708) Make docker not a requirement for building metaserver

    [ https://issues.apache.org/jira/browse/HUDI-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685345#comment-17685345 ] 

XiaoyuGeng commented on HUDI-5708:
----------------------------------

Thanks Raymond for reporting and processing this issue. I have a proposal about how to load thrift to compile the thrift files developer-friendly.

Proposal 1: script for compile and then install  thrift.tar.gz

Proposal 2: provide thrift binary for fixed version OS i.e. centos7, unbantu 18.04, mac OS

For p1, thrift with a specific version will be installed permanently on a developer PC after run once, and the install process cloud have some unexpected problem like the lackness of dependencies.

For p2, it has limitations in usage. I'm not sure it can work, I need to verify a case.

Or does anyone else have a better suggestion about this?

 

> Make docker not a requirement for building metaserver
> -----------------------------------------------------
>
>                 Key: HUDI-5708
>                 URL: https://issues.apache.org/jira/browse/HUDI-5708
>             Project: Apache Hudi
>          Issue Type: Improvement
>          Components: dev-experience
>            Reporter: Raymond Xu
>            Assignee: XiaoyuGeng
>            Priority: Major
>             Fix For: 0.13.1
>
>
> currently to build hudi-platform-service profile, we need docker or a local native thrift binary. see logic related to hudi-platform-service/hudi-metaserver/src/main/thrift/bin/thrift_binary.sh
> Docker should not be a requirement for build a java project. Some other issue: the docker generated source files may lack of permission for current user to delete, which could result in mvn clean to fail. encountered this issue with GH actions CI. i have to change the ownership for generated folder with sudo, but this leaves a loophole in the dev build flow - people may run into permission issue when sudo was involved. See this PR https://github.com/apache/hudi/pull/7858/
> The goal is to remove the docker requirement for build hudi project, and make thrift generation smooth across different OSes



--
This message was sent by Atlassian Jira
(v8.20.10#820010)