[GitHub] spark pull request #18828: [SPARK-21619][SQL] Fail the execution of canonica...

[rxin <gi...@git.apache.org>]

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18828#discussion_r147544081
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SparkPlanSuite.scala ---
    @@ -0,0 +1,36 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.execution
    +
    +import org.apache.spark.sql.QueryTest
    +import org.apache.spark.sql.test.SharedSQLContext
    +
    +class SparkPlanSuite extends QueryTest with SharedSQLContext {
    +
    +  test("SPARK-21619 execution of a canonicalized plan should fail") {
    +    val plan = spark.range(10).queryExecution.executedPlan.canonicalized
    +
    +    intercept[IllegalStateException] { plan.execute() }
    +    intercept[IllegalStateException] { plan.executeCollect() }
    +    intercept[IllegalStateException] { plan.executeCollectPublic() }
    +    intercept[IllegalStateException] { plan.executeToIterator() }
    +    intercept[IllegalStateException] { plan.executeBroadcast() }
    +    intercept[IllegalStateException] { plan.executeTake(1) }
    --- End diff --
    
    That's not an issue with this test, is it? It's just how execution is done.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org