You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/27 22:11:36 UTC

[GitHub] [tvm] trevor-m edited a comment on pull request #7346: [Torch] More graph rewrites for Faster RCNN / MaskRCNN

trevor-m edited a comment on pull request #7346:
URL: https://github.com/apache/tvm/pull/7346#issuecomment-768611717


   > No, the `If` there is for guarding against the case where there is no boxes, see
   > 
   > https://github.com/pytorch/vision/blob/8ebfd2f5d5f1792ce2cf5a2329320f604530a68e/torchvision/ops/boxes.py#L78-L79
   > 
   > So applying topk to an empty tensor is nop anyway.
   
   Got it, thanks! I guess the pattern does not guarantee that the true branch is for that 0 box case, but since this rewrite is only meant to be used for this particular model it is fine.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org