[jira] [Commented] (HDFS-6671) Archival Storage: Consider block storage policy in replicaiton

["Vinayakumar B (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-6671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061933#comment-14061933 ] 

Vinayakumar B commented on HDFS-6671:
-------------------------------------

Thanks [~szetszwo],
I  have found following things
1. {code}
+            return new Iterator<StorageType>() {
+              final Iterator<DatanodeStorageInfo> i = chosen.iterator();
+              @Override
+              public boolean hasNext() {return i.hasNext();}
+              @Override
+              public StorageType next() {return i.next().getStorageType();}
+            };{code}
Here one more method remove() needs to be implemented to fix the compilation errors.

2. typo in TestBlockStoragePolicy.DEFAULT_STORAGE_POICY

3. As of now, BlockPlacementPolicyDefault#getStorageType() will result in NPE, since the storagePolicyId is set to 0 in INodeFile, and this will return null storagePolicy. Would it be better of default policy is returned if the policy with id is found null? 

> Archival Storage: Consider block storage policy in replicaiton
> --------------------------------------------------------------
>
>                 Key: HDFS-6671
>                 URL: https://issues.apache.org/jira/browse/HDFS-6671
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: h6671_20140714.patch
>
>
> In order to satisfy storage policy requirement, replication monitor in addition reads storage policy information from INodeFile when performing replication.  As before, it only adds replicas if a block is under replicated, and deletes replicas if a block is over replicated.  It will NOT move replicas around for satisfying storage policy requirement.



--
This message was sent by Atlassian JIRA
(v6.2#6252)