[GitHub] huijunwu commented on a change in pull request #3162: keep executor running when `heron update` adds containers

[GitBox <gi...@apache.org>]

huijunwu commented on a change in pull request #3162: keep executor running when `heron update` adds containers
URL: https://github.com/apache/incubator-heron/pull/3162#discussion_r249160721
 
 

 ##########
 File path: heron/executor/src/python/heron_executor.py
 ##########
 @@ -844,8 +844,11 @@ def _get_instance_plans(self, packing_plan, container_id):
       if container_plan.id == container_id:
         this_container_plan = container_plan
 
-    # make sure that our shard id is a valid one
-    assert this_container_plan is not None
+    # When the executor runs in newly added container by `heron update`,
+    # there is no plan for this container. In this situation,
+    # return None to bypass instance processes.
+    if this_container_plan is None:
+      return None
 
 Review comment:
   the new repacking plan triggers the executor to launch the actual instnaces

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services