[jira] [Commented] (AIRFLOW-2951) dag_run end_date Null after a dag is finished

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590912#comment-16590912 ] 

ASF GitHub Bot commented on AIRFLOW-2951:
-----------------------------------------

YingboWang opened a new pull request #3798: [AIRFLOW-2951] Update dag_run table end_date when state change
URL: https://github.com/apache/incubator-airflow/pull/3798
 
 
   The existing airflow only change dag_run table end_date value when
   a user teminate a dag in web UI. The end_date will not be updated
   if airflow detected a dag finished and updated its state.
   
   This commit add end_date update in DagRun's set_state function to
   make up tho problem mentioned above.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOWAIRFLOW-2951/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-2951
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [x] Any finished dag should have a valid `end_date` in `dag_run` table, however this feature was not fully implemented. The `end_date` only exists when user try to mark a dag as success or failed from UI. This PR change the `DagRun.set_state()` function to set `end_date` when a `DagRun` state is changed and redirect existing dag_run state assignment to `set_state` function. It also fix UI to make sure a cleared dag will reset `end_date` to NULL.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   tests/models.py:DagRunTest.test_dagrun_set_state_end_date
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   
   @yrqls21

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> dag_run end_date Null after a dag is finished
> ---------------------------------------------
>
>                 Key: AIRFLOW-2951
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2951
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: DagRun
>            Reporter: Yingbo Wang
>            Assignee: Yingbo Wang
>            Priority: Major
>
> dag_run table should have an end_date updated when a dag is finished. 
> Currently only user activated dag termination request coming from UI may change the "end_date" in dag_run table. All scheduled dags that are automatically running by airflow will leave a NULL value after they fall into a "success" or "failed" state. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)