You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/04 12:47:29 UTC

[GitHub] [beam] damccorm opened a new issue, #19708: Improve checkpoints documentation

damccorm opened a new issue, #19708:
URL: https://github.com/apache/beam/issues/19708

   UnboundedSource.CheckpointMark should mention that implementations it should be encodable (have an associated Coder). Also maybe it is a good idea to explain a bit more the checkpointing semantics on Beam.
   
   Imported from Jira [BEAM-7691](https://issues.apache.org/jira/browse/BEAM-7691). Original Jira may contain additional context.
   Reported by: iemejia.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm commented on issue #19708: Improve checkpoints documentation

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on issue #19708:
URL: https://github.com/apache/beam/issues/19708#issuecomment-1497684563

   Hey, this particular issue involves updating the javadoc for UnboundedSource.CheckpointMark (https://github.com/apache/beam/blob/aeebe56720be4bf0442e923618fc712431fb82b0/sdks/java/core/src/main/java/org/apache/beam/sdk/io/UnboundedSource.java#L104). It should require updating the comment there to mention that implementations should be encodable (have an associated Coder).
   
   @iemejia might be able to help more here as well


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] DevPJ9 commented on issue #19708: Improve checkpoints documentation

Posted by "DevPJ9 (via GitHub)" <gi...@apache.org>.
DevPJ9 commented on issue #19708:
URL: https://github.com/apache/beam/issues/19708#issuecomment-1496885049

   Hey @damccorm, I have not any previous experience with documentation, can you please guide me through the initial steps.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] DevPJ9 commented on issue #19708: Improve checkpoints documentation

Posted by "DevPJ9 (via GitHub)" <gi...@apache.org>.
DevPJ9 commented on issue #19708:
URL: https://github.com/apache/beam/issues/19708#issuecomment-1496883487

   .take-issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] DevPJ9 commented on issue #19708: Improve checkpoints documentation

Posted by "DevPJ9 (via GitHub)" <gi...@apache.org>.
DevPJ9 commented on issue #19708:
URL: https://github.com/apache/beam/issues/19708#issuecomment-1496419453

   Hello @damccorm. I would like to contribute to this task.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] DevPJ9 commented on issue #19708: Improve checkpoints documentation

Posted by "DevPJ9 (via GitHub)" <gi...@apache.org>.
DevPJ9 commented on issue #19708:
URL: https://github.com/apache/beam/issues/19708#issuecomment-1497693498

   Ok I Kind of understood the requirement, I have to add `<p>Note that: The implementations of this interface should be encodable (have an associated Coder)`. 
   Am I right @damccorm
   cc : @iemejia.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm commented on issue #19708: Improve checkpoints documentation

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on issue #19708:
URL: https://github.com/apache/beam/issues/19708#issuecomment-1496432579

   Hey @DevPJ9 sounds good - if you'd like to take this issue, just comment `.take-issue` and you will be autoassigned the issue (it may take a bit since its based on GitHub Actions with limited quota)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm commented on issue #19708: Improve checkpoints documentation

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on issue #19708:
URL: https://github.com/apache/beam/issues/19708#issuecomment-1499023632

   Yep, something like that should work!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] DevPJ9 commented on issue #19708: Improve checkpoints documentation

Posted by "DevPJ9 (via GitHub)" <gi...@apache.org>.
DevPJ9 commented on issue #19708:
URL: https://github.com/apache/beam/issues/19708#issuecomment-1499344947

   @damccorm. I have raised the PR please review.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm closed issue #19708: Improve checkpoints documentation

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm closed issue #19708: Improve checkpoints documentation
URL: https://github.com/apache/beam/issues/19708


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org