You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Simon Lessard (JIRA)" <ad...@incubator.apache.org> on 2006/07/11 19:10:48 UTC
[jira] Created: (ADFFACES-57) Add a new ouputDocument component to
print multi-paragraph text
Add a new ouputDocument component to print multi-paragraph text
---------------------------------------------------------------
Key: ADFFACES-57
URL: http://issues.apache.org/jira/browse/ADFFACES-57
Project: MyFaces ADF-Faces
Type: New Feature
Reporter: Simon Lessard
Priority: Minor
This looks like a fairly trivial component to make and it could be useful for some Web sites.
The component would mainly parse its value attribute and change \n and/or \r with <p>.
Possible facet could be "separator" that would be inserted between paragraph.
The whole text could be in a div and it could supports skin selectors like:
af|outputDocument
af|outputDocument::paragraph
af|outputDocument::separator
as well as derived CSS rules like:
af|outputDocument::paragraph:first-child
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-57) Add a new ouputDocument component
to print multi-paragraph text
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-57?page=comments#action_12422345 ]
Adam Winer commented on ADFFACES-57:
------------------------------------
Checked in patch, w/some changes:
- Width is not hardcoded at 100% in the styles - we don't default this on any other components.
- Added a demo page for the component
However, not closing the bug yet; outputDocument needs a renderkit testscript (see CoreRenderKitTest and the MyFaces ADF wiki page.) before this can be closed up.
> Add a new ouputDocument component to print multi-paragraph text
> ---------------------------------------------------------------
>
> Key: ADFFACES-57
> URL: http://issues.apache.org/jira/browse/ADFFACES-57
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Simon Lessard
> Assigned To: Adam Winer
> Priority: Minor
> Attachments: OutputDocument.patch, OutputDocument.patch
>
>
> This looks like a fairly trivial component to make and it could be useful for some Web sites.
> The component would mainly parse its value attribute and change \n and/or \r with <p>.
> Possible facet could be "separator" that would be inserted between paragraph.
> The whole text could be in a div and it could supports skin selectors like:
> af|outputDocument
> af|outputDocument::paragraph
> af|outputDocument::separator
> as well as derived CSS rules like:
> af|outputDocument::paragraph:first-child
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (ADFFACES-57) Add a new ouputDocument component to
print multi-paragraph text
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-57?page=all ]
Adam Winer reassigned ADFFACES-57:
----------------------------------
Assignee: Adam Winer
> Add a new ouputDocument component to print multi-paragraph text
> ---------------------------------------------------------------
>
> Key: ADFFACES-57
> URL: http://issues.apache.org/jira/browse/ADFFACES-57
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Simon Lessard
> Assigned To: Adam Winer
> Priority: Minor
> Attachments: OutputDocument.patch, OutputDocument.patch
>
>
> This looks like a fairly trivial component to make and it could be useful for some Web sites.
> The component would mainly parse its value attribute and change \n and/or \r with <p>.
> Possible facet could be "separator" that would be inserted between paragraph.
> The whole text could be in a div and it could supports skin selectors like:
> af|outputDocument
> af|outputDocument::paragraph
> af|outputDocument::separator
> as well as derived CSS rules like:
> af|outputDocument::paragraph:first-child
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-57) Add a new ouputDocument component to
print multi-paragraph text
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-57?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated ADFFACES-57:
---------------------------------------
Fix Version/s: 1.0.0-incubating-core
Affects Version/s: 1.0.0-incubating-core
> Add a new ouputDocument component to print multi-paragraph text
> ---------------------------------------------------------------
>
> Key: ADFFACES-57
> URL: https://issues.apache.org/jira/browse/ADFFACES-57
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Affects Versions: 1.0.0-incubating-core
> Reporter: Simon Lessard
> Assigned To: Adam Winer
> Priority: Minor
> Fix For: 1.0.0-incubating-core
>
> Attachments: OutputDocument-test.patch, OutputDocument.patch
>
>
> This looks like a fairly trivial component to make and it could be useful for some Web sites.
> The component would mainly parse its value attribute and change \n and/or \r with <p>.
> Possible facet could be "separator" that would be inserted between paragraph.
> The whole text could be in a div and it could supports skin selectors like:
> af|outputDocument
> af|outputDocument::paragraph
> af|outputDocument::separator
> as well as derived CSS rules like:
> af|outputDocument::paragraph:first-child
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-57) Add a new ouputDocument component to
print multi-paragraph text
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-57?page=all ]
Simon Lessard updated ADFFACES-57:
----------------------------------
Attachment: OutputDocument.patch
This patch includes a new component that split a String into various paragraph by detecting '\n' and '\r'.
It supports a title and a separator facet. Title is added before the first paragraph while separator is placed between each of them.
It also supports the following skin selectors:
af|outputDocument
af|outputDocument::paragraph
af|outputDocument::separator
af|outputDocument::title
The component does not yet supports PPR and a PDA renderer is not created at this time.
> Add a new ouputDocument component to print multi-paragraph text
> ---------------------------------------------------------------
>
> Key: ADFFACES-57
> URL: http://issues.apache.org/jira/browse/ADFFACES-57
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: OutputDocument.patch
>
>
> This looks like a fairly trivial component to make and it could be useful for some Web sites.
> The component would mainly parse its value attribute and change \n and/or \r with <p>.
> Possible facet could be "separator" that would be inserted between paragraph.
> The whole text could be in a div and it could supports skin selectors like:
> af|outputDocument
> af|outputDocument::paragraph
> af|outputDocument::separator
> as well as derived CSS rules like:
> af|outputDocument::paragraph:first-child
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-57) Add a new ouputDocument component to
print multi-paragraph text
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-57?page=all ]
Simon Lessard updated ADFFACES-57:
----------------------------------
Status: Patch Available (was: Open)
> Add a new ouputDocument component to print multi-paragraph text
> ---------------------------------------------------------------
>
> Key: ADFFACES-57
> URL: http://issues.apache.org/jira/browse/ADFFACES-57
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: OutputDocument.patch
>
>
> This looks like a fairly trivial component to make and it could be useful for some Web sites.
> The component would mainly parse its value attribute and change \n and/or \r with <p>.
> Possible facet could be "separator" that would be inserted between paragraph.
> The whole text could be in a div and it could supports skin selectors like:
> af|outputDocument
> af|outputDocument::paragraph
> af|outputDocument::separator
> as well as derived CSS rules like:
> af|outputDocument::paragraph:first-child
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-57) Add a new ouputDocument component
to print multi-paragraph text
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-57?page=comments#action_12422207 ]
Adam Winer commented on ADFFACES-57:
------------------------------------
"description" is a fairly esoteric attribute of outputText; I don't see
a deep need to support it here.
Also, I'm torn about supporting escape="false" here; I'd
be more inclined to support a mode (perhaps always
on?) where it use the same formatted text code as
outputFormatted, so common HTML constructs are
supported but no cross-site scripting attacks are possible.
Minor code comments:
- Use toString() instead of ComponentUtils.resolveString()
- Get facet constants directly off of CoreOutputDocument
- _isLineFeed() should probably be expanded out as "if..." instead of
iterating through the array, since it's such a critical path in the code
> Add a new ouputDocument component to print multi-paragraph text
> ---------------------------------------------------------------
>
> Key: ADFFACES-57
> URL: http://issues.apache.org/jira/browse/ADFFACES-57
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: OutputDocument.patch
>
>
> This looks like a fairly trivial component to make and it could be useful for some Web sites.
> The component would mainly parse its value attribute and change \n and/or \r with <p>.
> Possible facet could be "separator" that would be inserted between paragraph.
> The whole text could be in a div and it could supports skin selectors like:
> af|outputDocument
> af|outputDocument::paragraph
> af|outputDocument::separator
> as well as derived CSS rules like:
> af|outputDocument::paragraph:first-child
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-57) Add a new ouputDocument component to
print multi-paragraph text
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-57?page=all ]
Simon Lessard updated ADFFACES-57:
----------------------------------
Attachment: OutputDocument-test.patch
Renderkit test script patch. It does not include the renderer and component.
> Add a new ouputDocument component to print multi-paragraph text
> ---------------------------------------------------------------
>
> Key: ADFFACES-57
> URL: http://issues.apache.org/jira/browse/ADFFACES-57
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Simon Lessard
> Assigned To: Adam Winer
> Priority: Minor
> Attachments: OutputDocument-test.patch, OutputDocument.patch, OutputDocument.patch
>
>
> This looks like a fairly trivial component to make and it could be useful for some Web sites.
> The component would mainly parse its value attribute and change \n and/or \r with <p>.
> Possible facet could be "separator" that would be inserted between paragraph.
> The whole text could be in a div and it could supports skin selectors like:
> af|outputDocument
> af|outputDocument::paragraph
> af|outputDocument::separator
> as well as derived CSS rules like:
> af|outputDocument::paragraph:first-child
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-57) Add a new ouputDocument component to
print multi-paragraph text
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-57?page=all ]
Adam Winer updated ADFFACES-57:
-------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
Test checked in, thanks!
> Add a new ouputDocument component to print multi-paragraph text
> ---------------------------------------------------------------
>
> Key: ADFFACES-57
> URL: http://issues.apache.org/jira/browse/ADFFACES-57
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Simon Lessard
> Assigned To: Adam Winer
> Priority: Minor
> Attachments: OutputDocument-test.patch, OutputDocument.patch
>
>
> This looks like a fairly trivial component to make and it could be useful for some Web sites.
> The component would mainly parse its value attribute and change \n and/or \r with <p>.
> Possible facet could be "separator" that would be inserted between paragraph.
> The whole text could be in a div and it could supports skin selectors like:
> af|outputDocument
> af|outputDocument::paragraph
> af|outputDocument::separator
> as well as derived CSS rules like:
> af|outputDocument::paragraph:first-child
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-57) Add a new ouputDocument component to
print multi-paragraph text
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-57?page=all ]
Simon Lessard updated ADFFACES-57:
----------------------------------
Attachment: (was: OutputDocument.patch)
> Add a new ouputDocument component to print multi-paragraph text
> ---------------------------------------------------------------
>
> Key: ADFFACES-57
> URL: http://issues.apache.org/jira/browse/ADFFACES-57
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Simon Lessard
> Assigned To: Adam Winer
> Priority: Minor
> Attachments: OutputDocument-test.patch, OutputDocument.patch
>
>
> This looks like a fairly trivial component to make and it could be useful for some Web sites.
> The component would mainly parse its value attribute and change \n and/or \r with <p>.
> Possible facet could be "separator" that would be inserted between paragraph.
> The whole text could be in a div and it could supports skin selectors like:
> af|outputDocument
> af|outputDocument::paragraph
> af|outputDocument::separator
> as well as derived CSS rules like:
> af|outputDocument::paragraph:first-child
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-57) Add a new ouputDocument component
to print multi-paragraph text
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-57?page=comments#action_12422193 ]
Simon Lessard commented on ADFFACES-57:
---------------------------------------
Actually, the component supports PPR, but PDA is TBD.
> Add a new ouputDocument component to print multi-paragraph text
> ---------------------------------------------------------------
>
> Key: ADFFACES-57
> URL: http://issues.apache.org/jira/browse/ADFFACES-57
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: OutputDocument.patch
>
>
> This looks like a fairly trivial component to make and it could be useful for some Web sites.
> The component would mainly parse its value attribute and change \n and/or \r with <p>.
> Possible facet could be "separator" that would be inserted between paragraph.
> The whole text could be in a div and it could supports skin selectors like:
> af|outputDocument
> af|outputDocument::paragraph
> af|outputDocument::separator
> as well as derived CSS rules like:
> af|outputDocument::paragraph:first-child
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-57) Add a new ouputDocument component to
print multi-paragraph text
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-57?page=all ]
Simon Lessard updated ADFFACES-57:
----------------------------------
Attachment: OutputDocument.patch
Patch including changes related to Adam's comments:
- Removed description and escape attributes.
- Used toString(Object) instead of ComponentUtils.resolveString
- _isLineFeed works with direct if evaluation instead of looping
- Facet names are retrieved directly from CoreOutputDocument
- Content is now writen using the same code branch as outputFormatted, thus supporting some markup inside the text itself.
> Add a new ouputDocument component to print multi-paragraph text
> ---------------------------------------------------------------
>
> Key: ADFFACES-57
> URL: http://issues.apache.org/jira/browse/ADFFACES-57
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: OutputDocument.patch, OutputDocument.patch
>
>
> This looks like a fairly trivial component to make and it could be useful for some Web sites.
> The component would mainly parse its value attribute and change \n and/or \r with <p>.
> Possible facet could be "separator" that would be inserted between paragraph.
> The whole text could be in a div and it could supports skin selectors like:
> af|outputDocument
> af|outputDocument::paragraph
> af|outputDocument::separator
> as well as derived CSS rules like:
> af|outputDocument::paragraph:first-child
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira