You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/30 03:38:04 UTC
[GitHub] [iotdb] WilliamSong11 commented on a change in pull request #2939: [ISSUE-2730] Add the number of unseq merge times in TsFile name.
WilliamSong11 commented on a change in pull request #2939:
URL: https://github.com/apache/iotdb/pull/2939#discussion_r603757029
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/level/LevelCompactionTsFileManagement.java
##########
@@ -600,14 +601,13 @@ private void merge(
isSeqMerging = false;
merge(isForceFullMerge, getTsFileList(true), mergeResources.get(i), Long.MAX_VALUE);
} else {
- CompactionLogger compactionLogger =
- new CompactionLogger(storageGroupDir, storageGroupName);
+ compactionLogger = new CompactionLogger(storageGroupDir, storageGroupName);
// log source file list and target file for recover
for (TsFileResource mergeResource : mergeResources.get(i)) {
compactionLogger.logFile(SOURCE_NAME, mergeResource.getTsFile());
}
File newLevelFile =
- createNewTsFileName(mergeResources.get(i).get(0).getTsFile(), i + 1);
+ TsFileResource.modifyTsFileNameMergeCnt(mergeResources.get(i).get(0).getTsFile());
Review comment:
Thank you for reply，We really need level info to decide whether to compact the tsfile，<TsFileResource.modifyTsFileNameMergeCnt> This function increments the number of sequential merges by 1，level info taken from mergeResource。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org