[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #7324: Honor spark case sensitivity in ALTER TABLE.. ORDERED BY

["amogh-jahagirdar (via GitHub)" <gi...@apache.org>]

amogh-jahagirdar commented on code in PR #7324:
URL: https://github.com/apache/iceberg/pull/7324#discussion_r1163405199


##########
spark/v3.3/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/SetWriteDistributionAndOrderingExec.scala:
##########
@@ -47,6 +48,7 @@ case class SetWriteDistributionAndOrderingExec(
         val txn = iceberg.table.newTransaction()
 
         val orderBuilder = txn.replaceSortOrder()
+        orderBuilder.caseSensitive(session.conf.get(SQLConf.CASE_SENSITIVE, SQLConf.CASE_SENSITIVE.defaultValue.get))

Review Comment:
   I'm not sure it makes sense to add a `caseSensitive` API to the `SortOrderBuilder`, would it make more sense to add something to `Schema` itself and engines can use that how they want? I guess that would imply changes to ReplaceSortOrder to pass in a schema, which is also not a good option.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org