You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/29 11:22:20 UTC

[GitHub] [arrow-datafusion] novemberkilo commented on pull request #922: WIP Optimize hash_aggregate when there are no null group keys

novemberkilo commented on pull request #922:
URL: https://github.com/apache/arrow-datafusion/pull/922#issuecomment-907775115


   @alamb @Dandandan I've added a commit that tries to incorporate your suggestions and feedback. Did I understand them correctly ... can you please comment again on whether I am headed in the right direction?
   
   I've not added tests to cover the additional code paths yet - I am aware that I need to do that.
   
   Also, do you have any pointers in the direction of how best to measure the effects of the attempted optimisation? Thanks. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org