You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "ricardozanini (via GitHub)" <gi...@apache.org> on 2024/09/20 21:25:34 UTC
[I] Refactor SonataFlowPlatform Actions and Reconciler to avoid object updates during the reconciliation [incubator-kie-kogito-serverless-operator]
ricardozanini opened a new issue, #538:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/issues/538
### Description
Currently, we call the function `CreateOrUpdateWithDefaults` from actions called during the reconciliation algorithm.
This function updates the `SonataFlowPlatform` object in the cluster. By the end of the reconciliation phase, we will have updated the object again. This redundancy must be gone.
Additionally, the `Monitor` action will never be called since the `Service` action is called before it and doesn't change the object status to a phase where the monitor action can be performed.
### Implementation ideas
- Review the reconciliation logic to read the `status` field and set `Reason` and `Status` conditions aligned with each action
- Update the `SonataFlowPlatform` only by the end of the reconciliation logic
- Break and rename the services reconciliation logic accordingly. Today, everything is within the `k8s.go` file, which makes maintenance a pain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org