You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by tv...@apache.org on 2014/02/19 16:48:09 UTC
svn commit: r1569795 [26/35] - in
/tomee/tomee/trunk/container/openejb-core/src/main: config/pmd/
java/javax/xml/ws/ java/javax/xml/ws/wsaddressing/ java/org/apache/openejb/
java/org/apache/openejb/assembler/
java/org/apache/openejb/assembler/classic/ ...
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/HandlerData.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/HandlerData.java?rev=1569795&r1=1569794&r2=1569795&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/HandlerData.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/HandlerData.java Wed Feb 19 15:47:58 2014
@@ -30,7 +30,7 @@ public class HandlerData {
private final List<Method> postConstruct = new ArrayList<Method>();
private final List<Method> preDestroy = new ArrayList<Method>();
- public HandlerData(Class<?> handlerClass) {
+ public HandlerData(final Class<?> handlerClass) {
if (handlerClass == null) throw new NullPointerException("handlerClass is null");
this.handlerClass = handlerClass;
}
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/HandlerResolverImpl.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/HandlerResolverImpl.java?rev=1569795&r1=1569794&r2=1569795&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/HandlerResolverImpl.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/HandlerResolverImpl.java Wed Feb 19 15:47:58 2014
@@ -40,23 +40,23 @@ public class HandlerResolverImpl impleme
private final Context context;
private final List<InjectionProcessor<Handler>> handlerInstances = new ArrayList<InjectionProcessor<Handler>>();
- public HandlerResolverImpl(List<HandlerChainData> handlerChains, Collection<Injection> injections, Context context) {
+ public HandlerResolverImpl(final List<HandlerChainData> handlerChains, final Collection<Injection> injections, final Context context) {
this.handlerChains = handlerChains;
this.injections = injections;
this.context = context;
}
public void destroyHandlers() {
- List<InjectionProcessor<Handler>> handlerInstances = new ArrayList<InjectionProcessor<Handler>>(this.handlerInstances);
+ final List<InjectionProcessor<Handler>> handlerInstances = new ArrayList<InjectionProcessor<Handler>>(this.handlerInstances);
this.handlerInstances.clear();
- for (InjectionProcessor<Handler> handlerInstance : handlerInstances) {
+ for (final InjectionProcessor<Handler> handlerInstance : handlerInstances) {
handlerInstance.preDestroy();
}
}
- public List<Handler> getHandlerChain(PortInfo portInfo) {
+ public List<Handler> getHandlerChain(final PortInfo portInfo) {
List<Handler> chain = new ArrayList<Handler>();
- for (HandlerChainData handlerChain : handlerChains) {
+ for (final HandlerChainData handlerChain : handlerChains) {
List<Handler> handlers = buildHandlers(portInfo, handlerChain);
handlers = sortHandlers(handlers);
chain.addAll(handlers);
@@ -65,59 +65,59 @@ public class HandlerResolverImpl impleme
return chain;
}
- private List<Handler> buildHandlers(PortInfo portInfo, HandlerChainData handlerChain) {
+ private List<Handler> buildHandlers(final PortInfo portInfo, final HandlerChainData handlerChain) {
if (!matchServiceName(portInfo, handlerChain.getServiceNamePattern()) ||
!matchPortName(portInfo, handlerChain.getPortNamePattern()) ||
!matchBinding(portInfo, handlerChain.getProtocolBindings())) {
return Collections.emptyList();
}
- List<Handler> handlers = new ArrayList<Handler>(handlerChain.getHandlers().size());
- for (HandlerData handler : handlerChain.getHandlers()) {
+ final List<Handler> handlers = new ArrayList<Handler>(handlerChain.getHandlers().size());
+ for (final HandlerData handler : handlerChain.getHandlers()) {
try {
- Class<? extends Handler> handlerClass = handler.getHandlerClass().asSubclass(Handler.class);
- InjectionProcessor<Handler> processor = new InjectionProcessor<Handler>(handlerClass,
+ final Class<? extends Handler> handlerClass = handler.getHandlerClass().asSubclass(Handler.class);
+ final InjectionProcessor<Handler> processor = new InjectionProcessor<Handler>(handlerClass,
injections,
handler.getPostConstruct(),
handler.getPreDestroy(),
unwrap(context));
processor.createInstance();
processor.postConstruct();
- Handler handlerInstance = processor.getInstance();
+ final Handler handlerInstance = processor.getInstance();
handlers.add(handlerInstance);
handlerInstances.add(processor);
- } catch (Exception e) {
+ } catch (final Exception e) {
throw new WebServiceException("Failed to instantiate handler", e);
}
}
return handlers;
}
- private boolean matchServiceName(PortInfo info, QName namePattern) {
+ private boolean matchServiceName(final PortInfo info, final QName namePattern) {
return match(info == null ? null : info.getServiceName(), namePattern);
}
- private boolean matchPortName(PortInfo info, QName namePattern) {
+ private boolean matchPortName(final PortInfo info, final QName namePattern) {
return match(info == null ? null : info.getPortName(), namePattern);
}
- private boolean matchBinding(PortInfo info, List bindings) {
+ private boolean matchBinding(final PortInfo info, final List bindings) {
return match(info == null ? null : info.getBindingID(), bindings);
}
- private boolean match(String binding, List bindings) {
+ private boolean match(final String binding, final List bindings) {
if (binding == null) {
return bindings == null || bindings.isEmpty();
} else {
if (bindings == null || bindings.isEmpty()) {
return true;
} else {
- String actualBindingURI = JaxWsUtils.getBindingURI(binding);
- Iterator iter = bindings.iterator();
+ final String actualBindingURI = JaxWsUtils.getBindingURI(binding);
+ final Iterator iter = bindings.iterator();
while (iter.hasNext()) {
- String bindingToken = (String) iter.next();
- String bindingURI = JaxWsUtils.getBindingURI(bindingToken);
+ final String bindingToken = (String) iter.next();
+ final String bindingURI = JaxWsUtils.getBindingURI(bindingToken);
if (actualBindingURI.equals(bindingURI)) {
return true;
}
@@ -130,7 +130,7 @@ public class HandlerResolverImpl impleme
/**
* Performs basic localName matching
*/
- private boolean match(QName name, QName namePattern) {
+ private boolean match(final QName name, final QName namePattern) {
if (name == null) {
return namePattern == null || namePattern.getLocalPart().equals("*");
} else {
@@ -162,11 +162,11 @@ public class HandlerResolverImpl impleme
* @param handlers
* @return sorted list of handlers
*/
- private List<Handler> sortHandlers(List<Handler> handlers) {
- List<LogicalHandler> logicalHandlers = new ArrayList<LogicalHandler>();
- List<Handler> protocolHandlers = new ArrayList<Handler>();
+ private List<Handler> sortHandlers(final List<Handler> handlers) {
+ final List<LogicalHandler> logicalHandlers = new ArrayList<LogicalHandler>();
+ final List<Handler> protocolHandlers = new ArrayList<Handler>();
- for (Handler handler : handlers) {
+ for (final Handler handler : handlers) {
if (handler instanceof LogicalHandler) {
logicalHandlers.add((LogicalHandler) handler);
} else {
@@ -174,7 +174,7 @@ public class HandlerResolverImpl impleme
}
}
- List<Handler> sortedHandlers = new ArrayList<Handler>();
+ final List<Handler> sortedHandlers = new ArrayList<Handler>();
sortedHandlers.addAll(logicalHandlers);
sortedHandlers.addAll(protocolHandlers);
return sortedHandlers;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/JaxWsUtils.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/JaxWsUtils.java?rev=1569795&r1=1569794&r2=1569795&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/JaxWsUtils.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/JaxWsUtils.java Wed Feb 19 15:47:58 2014
@@ -43,23 +43,23 @@ public final class JaxWsUtils {
private JaxWsUtils() {
}
- public static QName getPortType(Class<?> seiClass) {
- WebService webService = seiClass.getAnnotation(WebService.class);
+ public static QName getPortType(final Class<?> seiClass) {
+ final WebService webService = seiClass.getAnnotation(WebService.class);
if (webService != null) {
String localName = webService.name();
if (localName == null || localName.length() == 0) {
localName = seiClass.getSimpleName();
}
- String namespace = webService.targetNamespace();
+ final String namespace = webService.targetNamespace();
return new QName(getNamespace(seiClass, namespace), localName);
}
return null;
}
- public static String getBindingURI(String token) {
+ public static String getBindingURI(final String token) {
if (token != null) {
if (token.startsWith("##")) {
- String uri = BINDING_MAP.get(token);
+ final String uri = BINDING_MAP.get(token);
if (uri == null) {
throw new IllegalArgumentException("Unsupported binding token: " + token);
}
@@ -70,20 +70,20 @@ public final class JaxWsUtils {
return BINDING_MAP.get("##SOAP11_HTTP");
}
- public static boolean isWebService(Class clazz) {
+ public static boolean isWebService(final Class clazz) {
return (clazz.isAnnotationPresent(WebService.class) || clazz.isAnnotationPresent(WebServiceProvider.class)) && isProperWebService(clazz);
}
- private static boolean isProperWebService(Class clazz) {
- int modifiers = clazz.getModifiers();
+ private static boolean isProperWebService(final Class clazz) {
+ final int modifiers = clazz.getModifiers();
return Modifier.isPublic(modifiers) && !Modifier.isFinal(modifiers) && !Modifier.isAbstract(modifiers);
}
- public static String getServiceName(Class clazz) {
+ public static String getServiceName(final Class clazz) {
return getServiceQName(clazz).getLocalPart();
}
- private static String getServiceName(Class clazz, String name) {
+ private static String getServiceName(final Class clazz, final String name) {
if (name == null || name.trim().length() == 0) {
return clazz.getSimpleName() + "Service";
} else {
@@ -91,7 +91,7 @@ public final class JaxWsUtils {
}
}
- private static String getPortName(Class clazz, String name, String portName) {
+ private static String getPortName(final Class clazz, final String name, final String portName) {
if (portName == null || portName.trim().length() == 0) {
if (name == null || name.trim().length() == 0) {
return clazz.getSimpleName() + "Port";
@@ -103,9 +103,9 @@ public final class JaxWsUtils {
}
}
- private static String getNamespace(Class clazz, String namespace) {
+ private static String getNamespace(final Class clazz, final String namespace) {
if (namespace == null || namespace.trim().length() == 0) {
- Package pkg = clazz.getPackage();
+ final Package pkg = clazz.getPackage();
if (pkg == null) {
return null;
} else {
@@ -116,12 +116,12 @@ public final class JaxWsUtils {
}
}
- private static String getNamespace(String packageName) {
+ private static String getNamespace(final String packageName) {
if (packageName == null || packageName.length() == 0) {
return null;
}
- StringTokenizer tokenizer = new StringTokenizer(packageName, ".");
- String[] tokens;
+ final StringTokenizer tokenizer = new StringTokenizer(packageName, ".");
+ final String[] tokens;
if (tokenizer.countTokens() == 0) {
tokens = new String[0];
} else {
@@ -130,7 +130,7 @@ public final class JaxWsUtils {
tokens[i] = tokenizer.nextToken();
}
}
- StringBuilder namespace = new StringBuilder("http://");
+ final StringBuilder namespace = new StringBuilder("http://");
String dot = "";
for (int i = 0; i < tokens.length; i++) {
if (i == 1) {
@@ -142,37 +142,37 @@ public final class JaxWsUtils {
return namespace.toString();
}
- private static QName getServiceQName(Class clazz, String namespace, String name) {
+ private static QName getServiceQName(final Class clazz, final String namespace, final String name) {
return new QName(getNamespace(clazz, namespace), getServiceName(clazz, name));
}
- public static QName getServiceQName(Class<?> clazz) {
- WebService webService = clazz.getAnnotation(WebService.class);
+ public static QName getServiceQName(final Class<?> clazz) {
+ final WebService webService = clazz.getAnnotation(WebService.class);
if (webService != null) {
return getServiceQName(clazz, webService.targetNamespace(), webService.serviceName());
}
- WebServiceProvider webServiceProvider = clazz.getAnnotation(WebServiceProvider.class);
+ final WebServiceProvider webServiceProvider = clazz.getAnnotation(WebServiceProvider.class);
if (webServiceProvider != null) {
return getServiceQName(clazz, webServiceProvider.targetNamespace(), webServiceProvider.serviceName());
}
- WebServiceClient webServiceClient = clazz.getAnnotation(WebServiceClient.class);
+ final WebServiceClient webServiceClient = clazz.getAnnotation(WebServiceClient.class);
if (webServiceClient != null) {
return getServiceQName(clazz, webServiceClient.targetNamespace(), webServiceClient.name());
}
throw new IllegalArgumentException("The " + clazz.getName() + " is not annotated");
}
- private static QName getPortQName(Class<?> clazz, String namespace, String name, String portName) {
+ private static QName getPortQName(final Class<?> clazz, final String namespace, final String name, final String portName) {
return new QName(getNamespace(clazz, namespace), getPortName(clazz, name, portName));
}
- public static QName getPortQName(Class<?> clazz) {
- WebService webService = clazz.getAnnotation(WebService.class);
+ public static QName getPortQName(final Class<?> clazz) {
+ final WebService webService = clazz.getAnnotation(WebService.class);
if (webService != null) {
return getPortQName(clazz, webService.targetNamespace(), webService.name(), webService.portName());
}
- WebServiceProvider webServiceProvider = clazz.getAnnotation(WebServiceProvider.class);
+ final WebServiceProvider webServiceProvider = clazz.getAnnotation(WebServiceProvider.class);
if (webServiceProvider != null) {
return getPortQName(clazz, webServiceProvider.targetNamespace(), null, webServiceProvider.portName());
}
@@ -180,22 +180,22 @@ public final class JaxWsUtils {
throw new IllegalArgumentException("The " + clazz.getName() + " is not annotated");
}
- public static String getName(Class<?> clazz) {
- WebService webService = clazz.getAnnotation(WebService.class);
+ public static String getName(final Class<?> clazz) {
+ final WebService webService = clazz.getAnnotation(WebService.class);
if (webService != null) {
- String sei = webService.endpointInterface();
+ final String sei = webService.endpointInterface();
if (sei != null && sei.trim().length() != 0) {
try {
- Class seiClass = clazz.getClassLoader().loadClass(sei.trim());
+ final Class seiClass = clazz.getClassLoader().loadClass(sei.trim());
return getNameFromInterface(seiClass);
- } catch (ClassNotFoundException e) {
+ } catch (final ClassNotFoundException e) {
throw new OpenEJBRuntimeException("Unable to load SEI class: " + sei, e);
}
}
return getName(clazz, webService.name());
}
- WebServiceProvider webServiceProvider = clazz.getAnnotation(WebServiceProvider.class);
+ final WebServiceProvider webServiceProvider = clazz.getAnnotation(WebServiceProvider.class);
if (webServiceProvider != null) {
return clazz.getName();
}
@@ -203,15 +203,15 @@ public final class JaxWsUtils {
throw new IllegalArgumentException("The " + clazz.getName() + " is not annotated");
}
- private static String getNameFromInterface(Class<?> intf) {
- WebService webService = intf.getAnnotation(WebService.class);
+ private static String getNameFromInterface(final Class<?> intf) {
+ final WebService webService = intf.getAnnotation(WebService.class);
if (webService != null) {
return getName(intf, webService.name());
}
throw new IllegalArgumentException("The " + intf.getName() + " is not annotated");
}
- private static String getName(Class clazz, String name) {
+ private static String getName(final Class clazz, String name) {
if (name != null) {
name = name.trim();
if (name.length() > 0) {
@@ -221,22 +221,22 @@ public final class JaxWsUtils {
return clazz.getSimpleName();
}
- private static String getWsdlLocation(Class<?> clazz) {
- WebService webService = clazz.getAnnotation(WebService.class);
+ private static String getWsdlLocation(final Class<?> clazz) {
+ final WebService webService = clazz.getAnnotation(WebService.class);
if (webService != null) {
String wsdlLocation = webService.wsdlLocation().trim();
if (wsdlLocation.length() == 0) wsdlLocation = null;
return wsdlLocation;
}
- WebServiceClient webServiceClient = clazz.getAnnotation(WebServiceClient.class);
+ final WebServiceClient webServiceClient = clazz.getAnnotation(WebServiceClient.class);
if (webServiceClient != null) {
String wsdlLocation = webServiceClient.wsdlLocation().trim();
if (wsdlLocation.length() == 0) wsdlLocation = null;
return wsdlLocation;
}
- WebServiceProvider webServiceProvider = clazz.getAnnotation(WebServiceProvider.class);
+ final WebServiceProvider webServiceProvider = clazz.getAnnotation(WebServiceProvider.class);
if (webServiceProvider != null) {
String wsdlLocation = webServiceProvider.wsdlLocation().trim();
if (wsdlLocation.length() == 0) wsdlLocation = null;
@@ -246,7 +246,7 @@ public final class JaxWsUtils {
return null;
}
- public static String getServiceInterface(Class<?> clazz) {
+ public static String getServiceInterface(final Class<?> clazz) {
WebService webService = clazz.getAnnotation(WebService.class);
String endpointInterface = null;
if (webService != null && webService.endpointInterface() != null) {
@@ -260,7 +260,7 @@ public final class JaxWsUtils {
}
// if the bean implements only one WebService class, that is the SEI
- for (Class<?> intf : clazz.getInterfaces()) {
+ for (final Class<?> intf : clazz.getInterfaces()) {
// interface MUST also have a @WebService
webService = intf.getAnnotation(WebService.class);
if (webService != null) {
@@ -277,31 +277,31 @@ public final class JaxWsUtils {
return endpointInterface;
}
- public static String getServiceWsdlLocation(Class<?> clazz, ClassLoader loader) {
- String wsdlLocation = getWsdlLocation(clazz);
+ public static String getServiceWsdlLocation(final Class<?> clazz, final ClassLoader loader) {
+ final String wsdlLocation = getWsdlLocation(clazz);
if (wsdlLocation != null && !wsdlLocation.equals("")) {
return wsdlLocation;
}
- String serviceInterfaceClassName = getServiceInterface(clazz);
+ final String serviceInterfaceClassName = getServiceInterface(clazz);
if (serviceInterfaceClassName != null && !serviceInterfaceClassName.equals("")) {
try {
- Class serviceInterfaceClass = loader.loadClass(serviceInterfaceClassName);
+ final Class serviceInterfaceClass = loader.loadClass(serviceInterfaceClassName);
return getWsdlLocation(serviceInterfaceClass);
- } catch (Exception e) {
+ } catch (final Exception e) {
// no-op
}
}
return null;
}
- public static boolean containsWsdlLocation(Class<?> clazz, ClassLoader loader) {
- String wsdlLocSEIFromAnnotation = getServiceWsdlLocation(clazz, loader);
+ public static boolean containsWsdlLocation(final Class<?> clazz, final ClassLoader loader) {
+ final String wsdlLocSEIFromAnnotation = getServiceWsdlLocation(clazz, loader);
return wsdlLocSEIFromAnnotation != null && !wsdlLocSEIFromAnnotation.equals("");
}
- public static String getBindingUriFromAnn(Class<?> clazz) {
- BindingType bindingType = clazz.getAnnotation(BindingType.class);
+ public static String getBindingUriFromAnn(final Class<?> clazz) {
+ final BindingType bindingType = clazz.getAnnotation(BindingType.class);
if (bindingType != null) {
return bindingType.value();
}
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/NoAddressingSupport.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/NoAddressingSupport.java?rev=1569795&r1=1569794&r2=1569795&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/NoAddressingSupport.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/NoAddressingSupport.java Wed Feb 19 15:47:58 2014
@@ -28,11 +28,11 @@ public class NoAddressingSupport impleme
public static final NoAddressingSupport INSTANCE = new NoAddressingSupport();
- public EndpointReference getEndpointReference(Element... referenceParameters) {
+ public EndpointReference getEndpointReference(final Element... referenceParameters) {
throw new UnsupportedOperationException("JaxWS 2.1 APIs are not supported.");
}
- public <T extends EndpointReference> T getEndpointReference(Class<T> clazz, Element... referenceParameters) {
+ public <T extends EndpointReference> T getEndpointReference(final Class<T> clazz, final Element... referenceParameters) {
throw new UnsupportedOperationException("JaxWS 2.1 APIs are not supported.");
}
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/PortAddress.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/PortAddress.java?rev=1569795&r1=1569794&r2=1569795&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/PortAddress.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/PortAddress.java Wed Feb 19 15:47:58 2014
@@ -25,7 +25,7 @@ public class PortAddress {
private final String address;
private final String serviceEndpointInterface;
- public PortAddress(String portId, QName serviceQName, QName portQName, String address, String serviceEndpointInterface) {
+ public PortAddress(final String portId, final QName serviceQName, final QName portQName, final String address, final String serviceEndpointInterface) {
this.portId = portId;
this.serviceQName = serviceQName;
this.portQName = portQName;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/PortAddressRegistryImpl.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/PortAddressRegistryImpl.java?rev=1569795&r1=1569794&r2=1569795&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/PortAddressRegistryImpl.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/PortAddressRegistryImpl.java Wed Feb 19 15:47:58 2014
@@ -32,7 +32,7 @@ public class PortAddressRegistryImpl imp
private Map<String, Map<String, PortAddress>> portsByServiceId = new TreeMap<String, Map<String, PortAddress>>();
private Map<QName, Map<String, PortAddress>> portsByServiceQName = new HashMap<QName, Map<String, PortAddress>>();
- public synchronized void addPort(String serviceId, QName serviceQName, String portId, QName portQName, String portInterface, String address) throws OpenEJBException {
+ public synchronized void addPort(final String serviceId, final QName serviceQName, final String portId, final QName portQName, final String portInterface, final String address) throws OpenEJBException {
if (serviceId == null) throw new NullPointerException("serviceId is null");
if (serviceQName == null) throw new NullPointerException("serviceQName is null");
if (portId == null) throw new NullPointerException("portId is null");
@@ -75,13 +75,13 @@ public class PortAddressRegistryImpl imp
ports.put(portId, portAddress);
}
- public synchronized void removePort(String serviceId, QName serviceQName, String portId, String portInterface) {
+ public synchronized void removePort(final String serviceId, final QName serviceQName, final String portId, final String portInterface) {
if (serviceId == null) throw new NullPointerException("serviceId is null");
if (serviceQName == null) throw new NullPointerException("serviceQName is null");
if (portId == null) throw new NullPointerException("portId is null");
// remove from portById
- PortAddress portAddress = portsById.remove(portId);
+ final PortAddress portAddress = portsById.remove(portId);
if (portAddress != null) {
// port was not registered
return;
@@ -119,12 +119,12 @@ public class PortAddressRegistryImpl imp
}
}
- public synchronized Set<PortAddress> getPorts(String id, QName serviceQName, String referenceClassName) {
+ public synchronized Set<PortAddress> getPorts(final String id, final QName serviceQName, final String referenceClassName) {
if (serviceQName == null) throw new NullPointerException("serviceQName is null");
// check if there is a port with the id
if (id != null) {
- PortAddress portAddress = portsById.get(id);
+ final PortAddress portAddress = portsById.get(id);
if (portAddress != null) {
return Collections.singleton(portAddress);
}
@@ -132,27 +132,27 @@ public class PortAddressRegistryImpl imp
// check if there is a unique port with the specifiec interface
if (referenceClassName != null) {
- Map<String, PortAddress> interfacePorts = portsByInterface.get(referenceClassName);
+ final Map<String, PortAddress> interfacePorts = portsByInterface.get(referenceClassName);
if (interfacePorts != null && interfacePorts.size() == 1) {
- PortAddress portAddress = interfacePorts.values().iterator().next();
+ final PortAddress portAddress = interfacePorts.values().iterator().next();
return Collections.singleton(portAddress);
}
}
// find matching ports by id
- Map<String, PortAddress> ports = new TreeMap<String, PortAddress>();
+ final Map<String, PortAddress> ports = new TreeMap<String, PortAddress>();
if (id != null) {
- Map<String, PortAddress> idPorts = portsByServiceId.get(id);
+ final Map<String, PortAddress> idPorts = portsByServiceId.get(id);
if (idPorts != null) ports.putAll(idPorts);
}
// find matching ports by serviceQName
if (ports.isEmpty()) {
- Map<String, PortAddress> qnamePorts = portsByServiceQName.get(serviceQName);
+ final Map<String, PortAddress> qnamePorts = portsByServiceQName.get(serviceQName);
if (qnamePorts != null) ports.putAll(qnamePorts);
}
- Set<PortAddress> portAddresses = new HashSet<PortAddress>(ports.values());
+ final Set<PortAddress> portAddresses = new HashSet<PortAddress>(ports.values());
return portAddresses;
}
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/PortData.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/PortData.java?rev=1569795&r1=1569794&r2=1569795&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/PortData.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/PortData.java Wed Feb 19 15:47:58 2014
@@ -45,7 +45,7 @@ public class PortData implements PortInf
return portId;
}
- public void setPortId(String portId) {
+ public void setPortId(final String portId) {
this.portId = portId;
}
@@ -53,7 +53,7 @@ public class PortData implements PortInf
return serviceName;
}
- public void setServiceName(QName serviceName) {
+ public void setServiceName(final QName serviceName) {
this.serviceName = serviceName;
}
@@ -61,7 +61,7 @@ public class PortData implements PortInf
return portName;
}
- public void setPortName(QName portName) {
+ public void setPortName(final QName portName) {
this.portName = portName;
}
@@ -69,7 +69,7 @@ public class PortData implements PortInf
return bindingId;
}
- public void setBindingID(String bindingId) {
+ public void setBindingID(final String bindingId) {
this.bindingId = bindingId;
}
@@ -77,7 +77,7 @@ public class PortData implements PortInf
return wsdlUrl;
}
- public void setWsdlUrl(URL wsdlUrl) {
+ public void setWsdlUrl(final URL wsdlUrl) {
this.wsdlUrl = wsdlUrl;
}
@@ -93,7 +93,7 @@ public class PortData implements PortInf
return mtomEnabled;
}
- public void setMtomEnabled(boolean mtomEnabled) {
+ public void setMtomEnabled(final boolean mtomEnabled) {
this.mtomEnabled = mtomEnabled;
}
@@ -101,7 +101,7 @@ public class PortData implements PortInf
return wsdlPort;
}
- public void setWsdlPort(QName wsdlPort) {
+ public void setWsdlPort(final QName wsdlPort) {
this.wsdlPort = wsdlPort;
}
@@ -109,7 +109,7 @@ public class PortData implements PortInf
return wsdlService;
}
- public void setWsdlService(QName wsdlService) {
+ public void setWsdlService(final QName wsdlService) {
this.wsdlService = wsdlService;
}
@@ -117,11 +117,11 @@ public class PortData implements PortInf
return location;
}
- public void setLocation(String location) {
+ public void setLocation(final String location) {
this.location = location;
}
- public void setSecure(boolean secure) {
+ public void setSecure(final boolean secure) {
this.secure = secure;
}
@@ -133,7 +133,7 @@ public class PortData implements PortInf
return properties;
}
- public void setProperties(Properties properties) {
+ public void setProperties(final Properties properties) {
this.properties = properties;
}
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/PortRefData.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/PortRefData.java?rev=1569795&r1=1569794&r2=1569795&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/PortRefData.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/PortRefData.java Wed Feb 19 15:47:58 2014
@@ -31,7 +31,7 @@ public class PortRefData {
public PortRefData() {
}
- public PortRefData(PortRefData src) {
+ public PortRefData(final PortRefData src) {
qname = src.qname;
serviceEndpointInterface = src.serviceEndpointInterface;
enableMtom = src.enableMtom;
@@ -43,7 +43,7 @@ public class PortRefData {
return qname;
}
- public void setQName(QName qname) {
+ public void setQName(final QName qname) {
this.qname = qname;
}
@@ -51,7 +51,7 @@ public class PortRefData {
return serviceEndpointInterface;
}
- public void setServiceEndpointInterface(String serviceEndpointInterface) {
+ public void setServiceEndpointInterface(final String serviceEndpointInterface) {
this.serviceEndpointInterface = serviceEndpointInterface;
}
@@ -59,7 +59,7 @@ public class PortRefData {
return enableMtom;
}
- public void setEnableMtom(boolean value) {
+ public void setEnableMtom(final boolean value) {
this.enableMtom = value;
}
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/ProviderWrapper.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/ProviderWrapper.java?rev=1569795&r1=1569794&r2=1569795&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/ProviderWrapper.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/ProviderWrapper.java Wed Feb 19 15:47:58 2014
@@ -313,7 +313,7 @@ public class ProviderWrapper extends Pro
if (portRef.getServiceEndpointInterface() != null) {
try {
intf = proxy.getClass().getClassLoader().loadClass(portRef.getServiceEndpointInterface());
- } catch (Exception e) {
+ } catch (final Exception e) {
// no-op
}
}
@@ -366,19 +366,19 @@ public class ProviderWrapper extends Pro
if (provider != null) {
return provider;
}
- } catch (Exception ignored) {
+ } catch (final Exception ignored) {
// no-op
} finally {
if (in != null) {
try {
in.close();
- } catch (IOException e) {
+ } catch (final IOException e) {
// no-op
}
}
}
}
- } catch (Exception ingored) {
+ } catch (final Exception ingored) {
// no-op
}
@@ -394,7 +394,7 @@ public class ProviderWrapper extends Pro
if (provider != null) {
return provider;
}
- } catch (Exception ignored) {
+ } catch (final Exception ignored) {
// no-op
}
}
@@ -427,7 +427,7 @@ public class ProviderWrapper extends Pro
try {
final Class<? extends Provider> clazz = classLoader.loadClass(providerClass).asSubclass(Provider.class);
return clazz.newInstance();
- } catch (Throwable e) {
+ } catch (final Throwable e) {
logger.warning("Unable to construct provider implementation " + providerClass, e);
}
}
@@ -443,7 +443,7 @@ public class ProviderWrapper extends Pro
File tempFile = null;
try {
tempFile = File.createTempFile("openejb-jaxws-provider", "tmp");
- } catch (Throwable e) {
+ } catch (final Throwable e) {
final File tmp = new File("tmp");
if (!tmp.exists() && !tmp.mkdirs()) {
throw new IOException("Failed to create local tmp directory: " + tmp.getAbsolutePath());
@@ -456,7 +456,7 @@ public class ProviderWrapper extends Pro
out.write(ProviderWrapper.class.getName().getBytes());
out.close();
PROVIDER_URL = tempFile.toURI().toURL();
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new OpenEJBRuntimeException("Cound not create openejb-jaxws-provider file");
}
}
@@ -499,9 +499,9 @@ public class ProviderWrapper extends Pro
}
try {
return method.invoke(delegate, args);
- } catch (IllegalAccessException e) {
+ } catch (final IllegalAccessException e) {
throw new WebServiceException(e);
- } catch (InvocationTargetException e) {
+ } catch (final InvocationTargetException e) {
if (e.getCause() != null) {
throw new WebServiceException(e.getCause());
}
@@ -533,7 +533,7 @@ public class ProviderWrapper extends Pro
List.class,
String.class,
List.class);
- } catch (NoSuchMethodException e) {
+ } catch (final NoSuchMethodException e) {
// no-op
}
createW3CEndpointReference = method;
@@ -544,7 +544,7 @@ public class ProviderWrapper extends Pro
EndpointReference.class,
Class.class,
WebServiceFeature[].class);
- } catch (NoSuchMethodException e) {
+ } catch (final NoSuchMethodException e) {
// no-op
}
providerGetPort = method;
@@ -552,7 +552,7 @@ public class ProviderWrapper extends Pro
method = null;
try {
method = Provider.class.getMethod("readEndpointReference", Source.class);
- } catch (NoSuchMethodException e) {
+ } catch (final NoSuchMethodException e) {
// no-op
}
readEndpointReference = method;
@@ -565,7 +565,7 @@ public class ProviderWrapper extends Pro
JAXBContext.class,
Service.Mode.class,
WebServiceFeature[].class);
- } catch (NoSuchMethodException e) {
+ } catch (final NoSuchMethodException e) {
// no-op
}
createDispatchReferenceJaxB = method;
@@ -577,7 +577,7 @@ public class ProviderWrapper extends Pro
Class.class,
Service.Mode.class,
WebServiceFeature[].class);
- } catch (NoSuchMethodException e) {
+ } catch (final NoSuchMethodException e) {
// no-op
}
createDispatchReferenceClass = method;
@@ -589,7 +589,7 @@ public class ProviderWrapper extends Pro
JAXBContext.class,
Service.Mode.class,
WebServiceFeature[].class);
- } catch (NoSuchMethodException e) {
+ } catch (final NoSuchMethodException e) {
// no-op
}
createDispatchJaxBContext = method;
@@ -601,7 +601,7 @@ public class ProviderWrapper extends Pro
Class.class,
Service.Mode.class,
WebServiceFeature[].class);
- } catch (NoSuchMethodException e) {
+ } catch (final NoSuchMethodException e) {
// no-op
}
createDispatchInterface = method;
@@ -612,7 +612,7 @@ public class ProviderWrapper extends Pro
EndpointReference.class,
Class.class,
WebServiceFeature[].class);
- } catch (NoSuchMethodException e) {
+ } catch (final NoSuchMethodException e) {
// no-op
}
serviceGetPortByEndpointReference = method;
@@ -623,7 +623,7 @@ public class ProviderWrapper extends Pro
QName.class,
Class.class,
WebServiceFeature[].class);
- } catch (NoSuchMethodException e) {
+ } catch (final NoSuchMethodException e) {
// no-op
}
serviceGetPortByQName = method;
@@ -633,7 +633,7 @@ public class ProviderWrapper extends Pro
method = ServiceDelegate.class.getMethod("getPort",
Class.class,
WebServiceFeature[].class);
- } catch (NoSuchMethodException e) {
+ } catch (final NoSuchMethodException e) {
// no-op
}
serviceGetPortByInterface = method;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/ServiceRefData.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/ServiceRefData.java?rev=1569795&r1=1569794&r2=1569795&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/ServiceRefData.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/ServiceRefData.java Wed Feb 19 15:47:58 2014
@@ -26,11 +26,11 @@ import java.util.WeakHashMap;
public class ServiceRefData {
private static final WeakHashMap<Object,ServiceRefData> registry = new WeakHashMap<Object,ServiceRefData>();
- public static ServiceRefData getServiceRefData(Object key) {
+ public static ServiceRefData getServiceRefData(final Object key) {
return registry.get(key);
}
- public static ServiceRefData putServiceRefData(Object key, ServiceRefData value) {
+ public static ServiceRefData putServiceRefData(final Object key, final ServiceRefData value) {
return registry.put(key, value);
}
@@ -43,7 +43,7 @@ public class ServiceRefData {
private final List<HandlerChainData> handlerChains = new ArrayList<HandlerChainData>();
private final List<PortRefData> portRefs = new ArrayList<PortRefData>();
- public ServiceRefData(String id, QName serviceQName, Class<? extends Service> serviceClass, QName portQName, Class<?> referenceClass, URL wsdlURL, List<HandlerChainData> handlerChains, List<PortRefData> portRefs) {
+ public ServiceRefData(final String id, final QName serviceQName, final Class<? extends Service> serviceClass, final QName portQName, final Class<?> referenceClass, final URL wsdlURL, final List<HandlerChainData> handlerChains, final List<PortRefData> portRefs) {
this.id = id;
this.serviceQName = serviceQName;
this.serviceClass = serviceClass;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/UriResolver.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/UriResolver.java?rev=1569795&r1=1569794&r2=1569795&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/UriResolver.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/UriResolver.java Wed Feb 19 15:47:58 2014
@@ -52,15 +52,15 @@ public class UriResolver {
public UriResolver() {
}
- public UriResolver(String path) throws IOException {
+ public UriResolver(final String path) throws IOException {
this("", path);
}
- public UriResolver(String baseUriStr, String uriStr) throws IOException {
+ public UriResolver(final String baseUriStr, final String uriStr) throws IOException {
this(baseUriStr, uriStr, null);
}
- public UriResolver(String baseUriStr, String uriStr, Class calling) throws IOException {
+ public UriResolver(final String baseUriStr, final String uriStr, final Class calling) throws IOException {
this.calling = calling != null ? calling : getClass();
if (uriStr.startsWith("classpath:")) {
tryClasspath(uriStr);
@@ -74,7 +74,7 @@ public class UriResolver {
}
- public void resolve(String baseUriStr, String uriStr, Class callingCls) throws IOException {
+ public void resolve(final String baseUriStr, final String uriStr, final Class callingCls) throws IOException {
this.calling = callingCls != null ? callingCls : getClass();
this.file = null;
this.uri = null;
@@ -94,8 +94,8 @@ public class UriResolver {
- private void tryFileSystem(String baseUriStr, String uriStr) throws IOException, MalformedURLException {
- URI relative;
+ private void tryFileSystem(final String baseUriStr, final String uriStr) throws IOException, MalformedURLException {
+ final URI relative;
File uriFile = new File(uriStr);
uriFile = new File(uriFile.getAbsolutePath());
@@ -110,9 +110,9 @@ public class UriResolver {
url = relative.toURL();
try {
- HttpURLConnection huc = (HttpURLConnection)url.openConnection();
+ final HttpURLConnection huc = (HttpURLConnection)url.openConnection();
- String host = System.getProperty("http.proxyHost");
+ final String host = System.getProperty("http.proxyHost");
if (host != null) {
//comment out unused port to pass pmd check
/*String ports = System.getProperty("http.proxyPort");
@@ -121,16 +121,16 @@ public class UriResolver {
port = Integer.parseInt(ports);
}*/
- String username = System.getProperty("http.proxy.user");
- String password = System.getProperty("http.proxy.password");
+ final String username = System.getProperty("http.proxy.user");
+ final String password = System.getProperty("http.proxy.password");
if (username != null && password != null) {
- String encoded = new String(Base64.encodeBase64((username + ":" + password).getBytes()));
+ final String encoded = new String(Base64.encodeBase64((username + ":" + password).getBytes()));
huc.setRequestProperty("Proxy-Authorization", "Basic " + encoded);
}
}
is = huc.getInputStream();
- } catch (ClassCastException ex) {
+ } catch (final ClassCastException ex) {
is = IO.read(url);
}
} else if (baseUriStr != null) {
@@ -158,7 +158,7 @@ public class UriResolver {
tryClasspath(base.toString().startsWith("file:")
? base.toString().substring(5) : base.toString());
}
- } catch (Throwable th) {
+ } catch (final Throwable th) {
tryClasspath(base.toString().startsWith("file:")
? base.toString().substring(5) : base.toString());
}
@@ -168,7 +168,7 @@ public class UriResolver {
if (uri != null && "file".equals(uri.getScheme())) {
try {
file = new File(uri);
- } catch (IllegalArgumentException iae) {
+ } catch (final IllegalArgumentException iae) {
file = URLs.toFile(uri.toURL());
if (!file.exists()) {
file = null;
@@ -180,7 +180,7 @@ public class UriResolver {
uri = file.toURI();
try {
is = new FileInputStream(file);
- } catch (FileNotFoundException e) {
+ } catch (final FileNotFoundException e) {
throw new OpenEJBRuntimeException("File was deleted! " + uriStr, e);
}
url = file.toURI().toURL();
@@ -189,15 +189,15 @@ public class UriResolver {
}
}
- private void tryJar(String baseStr, String uriStr) throws IOException {
- int i = baseStr.indexOf('!');
+ private void tryJar(final String baseStr, final String uriStr) throws IOException {
+ final int i = baseStr.indexOf('!');
if (i == -1) {
tryFileSystem(baseStr, uriStr);
}
- String jarBase = baseStr.substring(0, i + 1);
- String jarEntry = baseStr.substring(i + 1);
- URI u = URLs.uri(jarEntry).resolve(uriStr);
+ final String jarBase = baseStr.substring(0, i + 1);
+ final String jarEntry = baseStr.substring(i + 1);
+ final URI u = URLs.uri(jarEntry).resolve(uriStr);
tryJar(jarBase + u.toString());
@@ -212,7 +212,7 @@ public class UriResolver {
}
private void tryJar(String uriStr) throws IOException {
- int i = uriStr.indexOf('!');
+ final int i = uriStr.indexOf('!');
if (i == -1) {
return;
}
@@ -222,10 +222,10 @@ public class UriResolver {
is = IO.read(url);
try {
uri = url.toURI();
- } catch (URISyntaxException ex) {
+ } catch (final URISyntaxException ex) {
// ignore
}
- } catch (IOException e) {
+ } catch (final IOException e) {
uriStr = uriStr.substring(i + 1);
tryClasspath(uriStr);
}
@@ -241,11 +241,11 @@ public class UriResolver {
} else {
try {
uri = url.toURI();
- } catch (URISyntaxException e) {
+ } catch (final URISyntaxException e) {
// processing the jar:file:/ type value
- String urlStr = url.toString();
+ final String urlStr = url.toString();
if (urlStr.startsWith("jar:")) {
- int pos = urlStr.indexOf('!');
+ final int pos = urlStr.indexOf('!');
if (pos != -1) {
uri = URLs.uri("classpath:" + urlStr.substring(pos + 1));
}
@@ -256,12 +256,12 @@ public class UriResolver {
}
}
- private void tryRemote(String uriStr) throws IOException {
+ private void tryRemote(final String uriStr) throws IOException {
try {
url = new URL(URLEncoder.encode(uriStr, "UTF-8"));
uri = URLs.uri(url.toString());
is = IO.read(url);
- } catch (MalformedURLException e) {
+ } catch (final MalformedURLException e) {
// do nothing
}
}
@@ -302,7 +302,7 @@ public class UriResolver {
* @param resourceName The name of the resource to load
* @param callingClass The Class object of the calling object
*/
- public static URL getResource(String resourceName, Class callingClass) {
+ public static URL getResource(final String resourceName, final Class callingClass) {
URL url = Thread.currentThread().getContextClassLoader().getResource(resourceName);
if (url == null) {
@@ -310,7 +310,7 @@ public class UriResolver {
}
if (url == null) {
- ClassLoader cl = callingClass.getClassLoader();
+ final ClassLoader cl = callingClass.getClassLoader();
if (cl != null) {
url = cl.getResource(resourceName);
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/WsdlResolver.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/WsdlResolver.java?rev=1569795&r1=1569794&r2=1569795&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/WsdlResolver.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/WsdlResolver.java Wed Feb 19 15:47:58 2014
@@ -31,7 +31,7 @@ public class WsdlResolver implements WSD
private String importedUri;
private InputSource inputSource;
- public WsdlResolver(String baseURI, InputSource is) {
+ public WsdlResolver(final String baseURI, final InputSource is) {
this.baseUri = baseURI;
inputSource = is;
}
@@ -48,23 +48,23 @@ public class WsdlResolver implements WSD
return importedUri;
}
- public InputSource getImportInputSource(String parent, String importLocation) {
+ public InputSource getImportInputSource(final String parent, final String importLocation) {
this.baseUri = parent;
- URL parentUrl;
+ final URL parentUrl;
try {
parentUrl = new URL(parent);
- URL importUrl = new URL(parentUrl, importLocation);
+ final URL importUrl = new URL(parentUrl, importLocation);
if (importUrl != null && !importUrl.getProtocol().startsWith("file")) {
- URLConnection con = importUrl.openConnection();
+ final URLConnection con = importUrl.openConnection();
con.setUseCaches(false);
inputSource = new InputSource(con.getInputStream());
} else {
- File file = new File(importUrl.toURI());
+ final File file = new File(importUrl.toURI());
if (file.exists()) {
- UriResolver resolver = new UriResolver(parent.toString(), importLocation);
+ final UriResolver resolver = new UriResolver(parent.toString(), importLocation);
inputSource = new InputSource(resolver.getInputStream());
} else {
- UriResolver resolver = new UriResolver(importLocation);
+ final UriResolver resolver = new UriResolver(importLocation);
if (resolver.isResolved()) {
inputSource = new InputSource(resolver.getInputStream());
}
@@ -72,11 +72,11 @@ public class WsdlResolver implements WSD
}
importedUri = importUrl.toURI().toString();
- } catch (MalformedURLException e) {
+ } catch (final MalformedURLException e) {
//
- } catch (URISyntaxException e) {
+ } catch (final URISyntaxException e) {
//
- } catch (IOException e) {
+ } catch (final IOException e) {
//
}
@@ -88,7 +88,7 @@ public class WsdlResolver implements WSD
if (inputSource.getByteStream() != null) {
try {
inputSource.getByteStream().close();
- } catch (IOException e) {
+ } catch (final IOException e) {
//
}
}
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/dyni/DynamicSubclass.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/dyni/DynamicSubclass.java?rev=1569795&r1=1569794&r2=1569795&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/dyni/DynamicSubclass.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/dyni/DynamicSubclass.java Wed Feb 19 15:47:58 2014
@@ -50,7 +50,7 @@ public class DynamicSubclass implements
private static final ReentrantLock LOCK = new ReentrantLock();
- public static boolean isDynamic(Class beanClass) {
+ public static boolean isDynamic(final Class beanClass) {
return Modifier.isAbstract(beanClass.getModifiers()) && InvocationHandler.class.isAssignableFrom(beanClass);
}
@@ -59,7 +59,7 @@ public class DynamicSubclass implements
try {
return cl.loadClass(proxyName);
- } catch (Exception e) {
+ } catch (final Exception e) {
// no-op
}
@@ -70,14 +70,14 @@ public class DynamicSubclass implements
try { // Try it again, another thread may have beaten this one...
return cl.loadClass(proxyName);
- } catch (Exception e) {
+ } catch (final Exception e) {
// no-op
}
final byte[] bytes = generateBytes(abstractClass);
return LocalBeanProxyFactory.Unsafe.defineClass(abstractClass, proxyName, bytes);
- } catch (Exception e) {
+ } catch (final Exception e) {
throw new InternalError(DynamicSubclass.class.getSimpleName() + ".createSubclass: " + Debug.printStackTrace(e));
} finally {
lock.unlock();
@@ -100,7 +100,7 @@ public class DynamicSubclass implements
// push InvocationHandler field
cw.visitField(ACC_FINAL + ACC_PRIVATE, "this$handler", "Ljava/lang/reflect/InvocationHandler;", null, null).visitEnd();
- for (Constructor<?> constructor : classToProxy.getConstructors()) {
+ for (final Constructor<?> constructor : classToProxy.getConstructors()) {
if (!Modifier.isPublic(constructor.getModifiers())) continue;
final MethodVisitor mv = visitConstructor(cw, proxyClassFileName, classFileName, constructor);
@@ -127,14 +127,14 @@ public class DynamicSubclass implements
copyMethodAnnotations(classToProxy, visitors);
// This should never be reached, but just in case
- for (MethodVisitor visitor : visitors.values()) {
+ for (final MethodVisitor visitor : visitors.values()) {
visitor.visitEnd();
}
return cw.toByteArray();
}
- private static MethodVisitor visitConstructor(ClassWriter cw, String proxyClassFileName, String classFileName, Constructor<?> constructor) {
+ private static MethodVisitor visitConstructor(final ClassWriter cw, final String proxyClassFileName, final String classFileName, final Constructor<?> constructor) {
final String descriptor = Type.getConstructorDescriptor(constructor);
final String[] exceptions = new String[constructor.getExceptionTypes().length];
@@ -147,7 +147,7 @@ public class DynamicSubclass implements
mv.visitVarInsn(ALOAD, 0);
int index = 1;
- for (Type type : Type.getArgumentTypes(descriptor)) {
+ for (final Type type : Type.getArgumentTypes(descriptor)) {
mv.visitVarInsn(type.getOpcode(ILOAD), index);
index += size(type);
}
@@ -162,7 +162,7 @@ public class DynamicSubclass implements
return mv;
}
- private static String getSubclassName(Class<?> classToProxy) {
+ private static String getSubclassName(final Class<?> classToProxy) {
return classToProxy.getName() + "$$Impl";
}
@@ -205,17 +205,17 @@ public class DynamicSubclass implements
return false;
}
- public static int size(Type type) {
+ public static int size(final Type type) {
if (Type.VOID_TYPE.equals(type)) return 0;
if (Type.LONG_TYPE.equals(type) || Type.DOUBLE_TYPE.equals(type)) return 2;
return 1;
}
- public static byte[] readClassFile(Class clazz) throws IOException {
+ public static byte[] readClassFile(final Class clazz) throws IOException {
return readClassFile(clazz.getClassLoader(), clazz);
}
- public static byte[] readClassFile(ClassLoader classLoader, Class clazz) throws IOException {
+ public static byte[] readClassFile(final ClassLoader classLoader, final Class clazz) throws IOException {
final String internalName = clazz.getName().replace('.', '/') + ".class";
final URL resource = classLoader.getResource(internalName);
@@ -231,7 +231,7 @@ public class DynamicSubclass implements
return out.toByteArray();
}
- private static void copyMethodAnnotations(Class<?> classToProxy, Map<String, MethodVisitor> visitors) throws ProxyGenerationException {
+ private static void copyMethodAnnotations(final Class<?> classToProxy, final Map<String, MethodVisitor> visitors) throws ProxyGenerationException {
// Move all the annotations onto the newly implemented methods
// Ensures CDI and JAX-RS and JAX-WS still work
Class clazz = classToProxy;
@@ -240,19 +240,19 @@ public class DynamicSubclass implements
final ClassReader classReader = new ClassReader(readClassFile(clazz));
final ClassVisitor copyMethodAnnotations = new CopyMethodAnnotations(visitors);
classReader.accept(copyMethodAnnotations, ClassReader.SKIP_CODE);
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new ProxyGenerationException(e);
}
clazz = clazz.getSuperclass();
}
}
- private static void copyClassAnnotations(Class<?> clazz, final ClassVisitor newClass) throws ProxyGenerationException {
+ private static void copyClassAnnotations(final Class<?> clazz, final ClassVisitor newClass) throws ProxyGenerationException {
try {
final ClassReader classReader = new ClassReader(readClassFile(clazz));
final ClassVisitor visitor = new CopyClassAnnotations(newClass);
classReader.accept(visitor, ClassReader.SKIP_CODE);
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new ProxyGenerationException(e);
}
}
@@ -262,18 +262,18 @@ public class DynamicSubclass implements
private MethodVisitor newMethod;
- public MoveAnnotationsVisitor(MethodVisitor movedMethod, MethodVisitor newMethod) {
+ public MoveAnnotationsVisitor(final MethodVisitor movedMethod, final MethodVisitor newMethod) {
super(Opcodes.ASM4, movedMethod);
this.newMethod = newMethod;
}
@Override
- public AnnotationVisitor visitAnnotation(String desc, boolean visible) {
+ public AnnotationVisitor visitAnnotation(final String desc, final boolean visible) {
return newMethod.visitAnnotation(desc, visible);
}
@Override
- public AnnotationVisitor visitParameterAnnotation(int parameter, String desc, boolean visible) {
+ public AnnotationVisitor visitParameterAnnotation(final int parameter, final String desc, final boolean visible) {
return newMethod.visitParameterAnnotation(parameter, desc, visible);
}
@@ -288,13 +288,13 @@ public class DynamicSubclass implements
private static class CopyClassAnnotations extends ClassVisitor {
private final ClassVisitor newClass;
- public CopyClassAnnotations(ClassVisitor newClass) {
+ public CopyClassAnnotations(final ClassVisitor newClass) {
super(Opcodes.ASM4);
this.newClass = newClass;
}
@Override
- public AnnotationVisitor visitAnnotation(String desc, boolean visible) {
+ public AnnotationVisitor visitAnnotation(final String desc, final boolean visible) {
return newClass.visitAnnotation(desc, visible);
}
}
@@ -302,13 +302,13 @@ public class DynamicSubclass implements
private static class CopyMethodAnnotations extends ClassVisitor {
private final Map<String, MethodVisitor> visitors;
- public CopyMethodAnnotations(Map<String, MethodVisitor> visitors) {
+ public CopyMethodAnnotations(final Map<String, MethodVisitor> visitors) {
super(Opcodes.ASM4);
this.visitors = visitors;
}
@Override
- public MethodVisitor visitMethod(int access, String name, String desc, String signature, String[] exceptions) {
+ public MethodVisitor visitMethod(final int access, final String name, final String desc, final String signature, final String[] exceptions) {
final MethodVisitor newMethod = visitors.remove(name + desc);
if (newMethod == null) return null;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/junit/ApplicationComposer.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/junit/ApplicationComposer.java?rev=1569795&r1=1569794&r2=1569795&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/junit/ApplicationComposer.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/junit/ApplicationComposer.java Wed Feb 19 15:47:58 2014
@@ -33,16 +33,16 @@ import java.util.concurrent.Callable;
public class ApplicationComposer extends BlockJUnit4ClassRunner {
private final ApplicationComposers delegate;
- public ApplicationComposer(Class<?> klass) throws InitializationError {
+ public ApplicationComposer(final Class<?> klass) throws InitializationError {
super(klass);
delegate = new ApplicationComposers(klass);
}
@Override
- protected List<MethodRule> rules(Object test) {
+ protected List<MethodRule> rules(final Object test) {
final List<MethodRule> rules = super.rules(test);
rules.add(new MethodRule(){
- public Statement apply(Statement base, FrameworkMethod method, Object target) {
+ public Statement apply(final Statement base, final FrameworkMethod method, final Object target) {
return new DeployApplication(target, base);
}
});
@@ -54,7 +54,7 @@ public class ApplicationComposer extends
private final Object testInstance;
private final Statement next;
- public DeployApplication(Object testInstance, Statement next) {
+ public DeployApplication(final Object testInstance, final Statement next) {
this.testInstance = testInstance;
this.next = next;
}
@@ -66,7 +66,7 @@ public class ApplicationComposer extends
public Void call() throws Exception {
try {
next.evaluate();
- } catch (Throwable throwable) {
+ } catch (final Throwable throwable) {
if (throwable instanceof Exception) {
throw (Exception) throwable;
}
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/ColorFormatter.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/ColorFormatter.java?rev=1569795&r1=1569794&r2=1569795&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/ColorFormatter.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/ColorFormatter.java Wed Feb 19 15:47:58 2014
@@ -46,7 +46,7 @@ public class ColorFormatter extends Sing
}
@Override
- public synchronized String format(LogRecord record) {
+ public synchronized String format(final LogRecord record) {
final boolean exception = record.getThrown() != null;
final Ansi sbuf = prefix(record);
sbuf.a(record.getLevel().getLocalizedName());
@@ -63,7 +63,7 @@ public class ColorFormatter extends Sing
record.getThrown().printStackTrace(pw);
pw.close();
sbuf.a(sw.toString());
- } catch (Exception ex) {
+ } catch (final Exception ex) {
// no-op
} finally {
suffix(sbuf, record);
@@ -75,7 +75,7 @@ public class ColorFormatter extends Sing
private Ansi.Color color(final String lvl, final String aDefault) {
try {
return Ansi.Color.valueOf(SystemInstance.get().getProperty(OPENEJB_LOG_COLOR_PREFIX + lvl, aDefault));
- } catch (IllegalArgumentException iae) {
+ } catch (final IllegalArgumentException iae) {
return Ansi.Color.valueOf(aDefault);
}
}
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/FileHandler.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/FileHandler.java?rev=1569795&r1=1569794&r2=1569795&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/FileHandler.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/FileHandler.java Wed Feb 19 15:47:58 2014
@@ -90,7 +90,7 @@ public class FileHandler
}
- public FileHandler(String directory, String prefix, String suffix) {
+ public FileHandler(final String directory, final String prefix, final String suffix) {
this.directory = directory;
this.prefix = prefix;
this.suffix = suffix;
@@ -160,16 +160,16 @@ public class FileHandler
* @param record description of the log event
*/
@Override
- public void publish(LogRecord record) {
+ public void publish(final LogRecord record) {
if (!isLoggable(record)) {
return;
}
// Construct the timestamp we will use, if requested
- Timestamp ts = new Timestamp(System.currentTimeMillis());
- String tsString = ts.toString().substring(0, 19);
- String tsDate = tsString.substring(0, 10);
+ final Timestamp ts = new Timestamp(System.currentTimeMillis());
+ final String tsString = ts.toString().substring(0, 19);
+ final String tsDate = tsString.substring(0, 10);
try {
writerLock.readLock().lock();
@@ -197,7 +197,7 @@ public class FileHandler
String result = null;
try {
result = getFormatter().format(record);
- } catch (Exception e) {
+ } catch (final Exception e) {
reportError(null, e, ErrorManager.FORMAT_FAILURE);
return;
}
@@ -211,7 +211,7 @@ public class FileHandler
} else {
reportError("FileHandler is closed or not yet initialized, unable to log ["+result+"]", null, ErrorManager.WRITE_FAILURE);
}
- } catch (Exception e) {
+ } catch (final Exception e) {
reportError(null, e, ErrorManager.WRITE_FAILURE);
return;
}
@@ -243,7 +243,7 @@ public class FileHandler
writer.close();
writer = null;
date = "";
- } catch (Exception e) {
+ } catch (final Exception e) {
reportError(null, e, ErrorManager.CLOSE_FAILURE);
} finally {
writerLock.writeLock().unlock();
@@ -262,7 +262,7 @@ public class FileHandler
if (writer == null)
return;
writer.flush();
- } catch (Exception e) {
+ } catch (final Exception e) {
reportError(null, e, ErrorManager.FLUSH_FAILURE);
} finally {
writerLock.readLock().unlock();
@@ -276,13 +276,13 @@ public class FileHandler
*/
private void configure() {
- Timestamp ts = new Timestamp(System.currentTimeMillis());
- String tsString = ts.toString().substring(0, 19);
+ final Timestamp ts = new Timestamp(System.currentTimeMillis());
+ final String tsString = ts.toString().substring(0, 19);
date = tsString.substring(0, 10);
- String className = this.getClass().getName(); //allow classes to override
+ final String className = this.getClass().getName(); //allow classes to override
- ClassLoader cl = Thread.currentThread().getContextClassLoader();
+ final ClassLoader cl = Thread.currentThread().getContextClassLoader();
// Retrieve configuration of logging file name
rotatable = Boolean.parseBoolean(getProperty(className + ".rotatable", "true"));
@@ -292,18 +292,18 @@ public class FileHandler
prefix = getProperty(className + ".prefix", "juli.");
if (suffix == null)
suffix = getProperty(className + ".suffix", ".log");
- String sBufferSize = getProperty(className + ".bufferSize", String.valueOf(bufferSize));
+ final String sBufferSize = getProperty(className + ".bufferSize", String.valueOf(bufferSize));
try {
bufferSize = Integer.parseInt(sBufferSize);
- } catch (NumberFormatException ignore) {
+ } catch (final NumberFormatException ignore) {
//no op
}
// Get encoding for the logging file
- String encoding = getProperty(className + ".encoding", null);
+ final String encoding = getProperty(className + ".encoding", null);
if (encoding != null && encoding.length() > 0) {
try {
setEncoding(encoding);
- } catch (UnsupportedEncodingException ex) {
+ } catch (final UnsupportedEncodingException ex) {
// Ignore
}
}
@@ -312,21 +312,21 @@ public class FileHandler
setLevel(Level.parse(getProperty(className + ".level", "" + Level.ALL)));
// Get filter configuration
- String filterName = getProperty(className + ".filter", null);
+ final String filterName = getProperty(className + ".filter", null);
if (filterName != null) {
try {
setFilter((Filter) cl.loadClass(filterName).newInstance());
- } catch (Exception e) {
+ } catch (final Exception e) {
// Ignore
}
}
// Set formatter
- String formatterName = getProperty(className + ".formatter", null);
+ final String formatterName = getProperty(className + ".formatter", null);
if (formatterName != null) {
try {
setFormatter((Formatter) cl.loadClass(formatterName).newInstance());
- } catch (Exception e) {
+ } catch (final Exception e) {
// Ignore and fallback to defaults
setFormatter(new SimpleFormatter());
}
@@ -340,7 +340,7 @@ public class FileHandler
}
- private String getProperty(String name, String defaultValue) {
+ private String getProperty(final String name, final String defaultValue) {
String value = LogManager.getLogManager().getProperty(name);
if (value == null) {
value = defaultValue;
@@ -361,7 +361,7 @@ public class FileHandler
protected void openWriter() {
// Create the directory if necessary
- File dir = new File(directory);
+ final File dir = new File(directory);
if (!dir.mkdirs() && !dir.isDirectory()) {
reportError("Unable to create [" + dir + "]", null,
ErrorManager.OPEN_FAILURE);
@@ -372,23 +372,23 @@ public class FileHandler
// Open the current log file
writerLock.writeLock().lock();
try {
- File pathname = new File(dir.getAbsoluteFile(), prefix
+ final File pathname = new File(dir.getAbsoluteFile(), prefix
+ (rotatable ? date : "") + suffix);
- File parent = pathname.getParentFile();
+ final File parent = pathname.getParentFile();
if (!parent.mkdirs() && !parent.isDirectory()) {
reportError("Unable to create [" + parent + "]", null,
ErrorManager.OPEN_FAILURE);
writer = null;
return;
}
- String encoding = getEncoding();
- FileOutputStream fos = new FileOutputStream(pathname, true);
- OutputStream os = bufferSize>0?new BufferedOutputStream(fos,bufferSize):fos;
+ final String encoding = getEncoding();
+ final FileOutputStream fos = new FileOutputStream(pathname, true);
+ final OutputStream os = bufferSize>0?new BufferedOutputStream(fos,bufferSize):fos;
writer = new PrintWriter(
encoding != null ? new OutputStreamWriter(os, encoding)
: new OutputStreamWriter(os), false);
writer.write(getFormatter().getHead(this));
- } catch (Exception e) {
+ } catch (final Exception e) {
reportError(null, e, ErrorManager.OPEN_FAILURE);
writer = null;
} finally {
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/JULUtil.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/JULUtil.java?rev=1569795&r1=1569794&r2=1569795&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/JULUtil.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/JULUtil.java Wed Feb 19 15:47:58 2014
@@ -32,9 +32,9 @@ public final class JULUtil {
final String propLevel = SystemInstance.get().getProperty(OPENEJB_LOG_LEVEL, DEFAULT_LOG_LEVEL).toUpperCase();
try {
return (Level) Level.class.getDeclaredField(propLevel).get(null);
- } catch (IllegalAccessException e) {
+ } catch (final IllegalAccessException e) {
return Level.INFO;
- } catch (NoSuchFieldException e) {
+ } catch (final NoSuchFieldException e) {
return Level.INFO;
}
}
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/LoggerCreator.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/LoggerCreator.java?rev=1569795&r1=1569794&r2=1569795&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/LoggerCreator.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/LoggerCreator.java Wed Feb 19 15:47:58 2014
@@ -40,7 +40,7 @@ public class LoggerCreator implements Ca
if (levelName != null) {
try {
call();
- } catch (Exception e) {
+ } catch (final Exception e) {
// no-op
}
}
@@ -53,7 +53,7 @@ public class LoggerCreator implements Ca
if (logger == null) {
try {
logger = Logger.getLogger(name);
- } catch (Exception e) {
+ } catch (final Exception e) {
logger = Logger.getLogger(name); // try again
}
@@ -62,7 +62,7 @@ public class LoggerCreator implements Ca
final String levelName = p.getProperty("logging.level." + logger.getName());
if (levelName != null) {
final Level level = Level.parse(levelName);
- for (Handler handler : logger.getHandlers()) {
+ for (final Handler handler : logger.getHandlers()) {
handler.setLevel(level);
}
}
@@ -109,7 +109,7 @@ public class LoggerCreator implements Ca
final Logger l;
try {
l = lc.call();
- } catch (Exception e) {
+ } catch (final Exception e) {
return;
}
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/SingleLineFormatter.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/SingleLineFormatter.java?rev=1569795&r1=1569794&r2=1569795&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/SingleLineFormatter.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/SingleLineFormatter.java Wed Feb 19 15:47:58 2014
@@ -25,7 +25,7 @@ public class SingleLineFormatter extends
private static final String SEP = System.getProperty("line.separator", "\n");
@Override
- public synchronized String format(LogRecord record) {
+ public synchronized String format(final LogRecord record) {
final boolean exception = record.getThrown() != null;
final StringBuilder sbuf = new StringBuilder();
sbuf.append(record.getLevel().getLocalizedName());
@@ -39,7 +39,7 @@ public class SingleLineFormatter extends
record.getThrown().printStackTrace(pw);
pw.close();
sbuf.append(sw.toString());
- } catch (Exception ex) {
+ } catch (final Exception ex) {
// no-op
}
}
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/commonslogging/OpenEJBCommonsLog.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/commonslogging/OpenEJBCommonsLog.java?rev=1569795&r1=1569794&r2=1569795&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/commonslogging/OpenEJBCommonsLog.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/commonslogging/OpenEJBCommonsLog.java Wed Feb 19 15:47:58 2014
@@ -65,62 +65,62 @@ public class OpenEJBCommonsLog implement
}
@Override
- public void trace(Object message) {
+ public void trace(final Object message) {
logger.debug(message + "");
}
@Override
- public void trace(Object message, Throwable t) {
+ public void trace(final Object message, final Throwable t) {
logger.debug(message + "", t);
}
@Override
- public void debug(Object message) {
+ public void debug(final Object message) {
logger.debug(message + "");
}
@Override
- public void debug(Object message, Throwable t) {
+ public void debug(final Object message, final Throwable t) {
logger.debug(message + "", t);
}
@Override
- public void info(Object message) {
+ public void info(final Object message) {
logger.info(message + "");
}
@Override
- public void info(Object message, Throwable t) {
+ public void info(final Object message, final Throwable t) {
logger.info(message + "", t);
}
@Override
- public void warn(Object message) {
+ public void warn(final Object message) {
logger.warning(message + "");
}
@Override
- public void warn(Object message, Throwable t) {
+ public void warn(final Object message, final Throwable t) {
logger.warning(message + "", t);
}
@Override
- public void error(Object message) {
+ public void error(final Object message) {
logger.error(message + "");
}
@Override
- public void error(Object message, Throwable t) {
+ public void error(final Object message, final Throwable t) {
logger.error(message + "", t);
}
@Override
- public void fatal(Object message) {
+ public void fatal(final Object message) {
logger.fatal(message + "");
}
@Override
- public void fatal(Object message, Throwable t) {
+ public void fatal(final Object message, final Throwable t) {
logger.fatal(message + "", t);
}