[GitHub] [hive] pvary commented on a diff in pull request #3302: HIVE-26239 Shutdown Hash table load executor service threads when the…

[GitBox <gi...@apache.org>]

pvary commented on code in PR #3302:
URL: https://github.com/apache/hive/pull/3302#discussion_r880123001


##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -312,13 +312,11 @@ public void load(MapJoinTableContainer[] mapJoinTables,
                   inputName, cacheKey, receivedEntries, delta);
         }
       } catch (InterruptedException e) {
+        loadExecService.shutdownNow();

Review Comment:
   should this be `finally`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org