[GitHub] [helix] kaisun2000 commented on a change in pull request #1438: Fix TaskGarbageCollectionStage rebalance trigger when job purge interval is negative

[GitBox <gi...@apache.org>]

kaisun2000 commented on a change in pull request #1438:
URL: https://github.com/apache/helix/pull/1438#discussion_r500507981



##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/TaskGarbageCollectionStage.java
##########
@@ -73,9 +73,12 @@ public void process(ClusterEvent event) throws Exception {
           continue;
         }
         long purgeInterval = workflowConfig.getJobPurgeInterval();
+        if (purgeInterval <= 0) {
+          continue;
+        }
         long currentTime = System.currentTimeMillis();
         long nextPurgeTime = workflowContext.getLastJobPurgeTime() + purgeInterval;
-        if (purgeInterval > 0 && nextPurgeTime <= currentTime) {

Review comment:
       why the previous way has a bug?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org