You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Tony Wu (JIRA)" <ji...@apache.org> on 2007/06/06 08:36:26 UTC
[jira] Created: (HARMONY-4059) [classlib][luni][java6]new
constructors of java.io.PipedInputStream
[classlib][luni][java6]new constructors of java.io.PipedInputStream
-------------------------------------------------------------------
Key: HARMONY-4059
URL: https://issues.apache.org/jira/browse/HARMONY-4059
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Tony Wu
constructor java.io.PipedInputStream(int)
constructor java.io.PipedInputStream(java.io.PipedOutputStream, int)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4059) [classlib][luni][java6]new
constructors of java.io.PipedInputStream
Posted by "Tony Wu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502228 ]
Tony Wu commented on HARMONY-4059:
----------------------------------
The fix in PipedOuputStream is not a bug at java5 level since there is no construct with buf size in PipedInputStream. The buffer will always be initialized in PipedOutputStream only.
But in java6 if one creates a PipedInputStream with buf size, it will be initialized by PipedInputStream itself, so that it is not necessary to init it again in PipedOutputStream.
> [classlib][luni][java6]new constructors of java.io.PipedInputStream
> -------------------------------------------------------------------
>
> Key: HARMONY-4059
> URL: https://issues.apache.org/jira/browse/HARMONY-4059
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Tony Wu
> Assignee: Paulex Yang
> Attachments: harmony-4059.diff
>
>
> constructor java.io.PipedInputStream(int)
> constructor java.io.PipedInputStream(java.io.PipedOutputStream, int)
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4059) [classlib][luni][java6]new
constructors of java.io.PipedInputStream
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502200 ]
Paulex Yang commented on HARMONY-4059:
--------------------------------------
Tony, the update on PipedOutputStream as below seems a bug fixing? If so, maybe it should go to Java 5 trunk at first?
- stream.buffer = new byte[PipedInputStream.PIPE_SIZE];
+ if (stream.buffer == null) {
+ stream.buffer = new byte[PipedInputStream.PIPE_SIZE];
+ }
> [classlib][luni][java6]new constructors of java.io.PipedInputStream
> -------------------------------------------------------------------
>
> Key: HARMONY-4059
> URL: https://issues.apache.org/jira/browse/HARMONY-4059
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Tony Wu
> Assignee: Paulex Yang
> Attachments: harmony-4059.diff
>
>
> constructor java.io.PipedInputStream(int)
> constructor java.io.PipedInputStream(java.io.PipedOutputStream, int)
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4059) [classlib][luni][java6]new
constructors of java.io.PipedInputStream
Posted by "Tony Wu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tony Wu updated HARMONY-4059:
-----------------------------
Attachment: harmony-4059.diff
> [classlib][luni][java6]new constructors of java.io.PipedInputStream
> -------------------------------------------------------------------
>
> Key: HARMONY-4059
> URL: https://issues.apache.org/jira/browse/HARMONY-4059
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Tony Wu
> Attachments: harmony-4059.diff
>
>
> constructor java.io.PipedInputStream(int)
> constructor java.io.PipedInputStream(java.io.PipedOutputStream, int)
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-4059) [classlib][luni][java6]new
constructors of java.io.PipedInputStream
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paulex Yang reassigned HARMONY-4059:
------------------------------------
Assignee: Paulex Yang
> [classlib][luni][java6]new constructors of java.io.PipedInputStream
> -------------------------------------------------------------------
>
> Key: HARMONY-4059
> URL: https://issues.apache.org/jira/browse/HARMONY-4059
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Tony Wu
> Assignee: Paulex Yang
> Attachments: harmony-4059.diff
>
>
> constructor java.io.PipedInputStream(int)
> constructor java.io.PipedInputStream(java.io.PipedOutputStream, int)
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-4059) [classlib][luni][java6]new
constructors of java.io.PipedInputStream
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess closed HARMONY-4059.
---------------------------------
Closing as this seems to have been applied correctly in the current code.
> [classlib][luni][java6]new constructors of java.io.PipedInputStream
> -------------------------------------------------------------------
>
> Key: HARMONY-4059
> URL: https://issues.apache.org/jira/browse/HARMONY-4059
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Tony Wu
> Assignee: Paulex Yang
> Attachments: harmony-4059.diff
>
>
> constructor java.io.PipedInputStream(int)
> constructor java.io.PipedInputStream(java.io.PipedOutputStream, int)
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-4059) [classlib][luni][java6]new
constructors of java.io.PipedInputStream
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paulex Yang resolved HARMONY-4059.
----------------------------------
Resolution: Fixed
Tony, thanks for the explanation, patch applied at r545077, thanks a lot, please verify.
> [classlib][luni][java6]new constructors of java.io.PipedInputStream
> -------------------------------------------------------------------
>
> Key: HARMONY-4059
> URL: https://issues.apache.org/jira/browse/HARMONY-4059
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Tony Wu
> Assignee: Paulex Yang
> Attachments: harmony-4059.diff
>
>
> constructor java.io.PipedInputStream(int)
> constructor java.io.PipedInputStream(java.io.PipedOutputStream, int)
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4059) [classlib][luni][java6]new
constructors of java.io.PipedInputStream
Posted by "Tony Wu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tony Wu updated HARMONY-4059:
-----------------------------
Attachment: harmony-4059.diff
would you please try this patch? thanks a lot!
> [classlib][luni][java6]new constructors of java.io.PipedInputStream
> -------------------------------------------------------------------
>
> Key: HARMONY-4059
> URL: https://issues.apache.org/jira/browse/HARMONY-4059
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Tony Wu
> Attachments: harmony-4059.diff
>
>
> constructor java.io.PipedInputStream(int)
> constructor java.io.PipedInputStream(java.io.PipedOutputStream, int)
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4059) [classlib][luni][java6]new
constructors of java.io.PipedInputStream
Posted by "Tony Wu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tony Wu updated HARMONY-4059:
-----------------------------
Attachment: (was: harmony-4059.diff)
> [classlib][luni][java6]new constructors of java.io.PipedInputStream
> -------------------------------------------------------------------
>
> Key: HARMONY-4059
> URL: https://issues.apache.org/jira/browse/HARMONY-4059
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Tony Wu
>
> constructor java.io.PipedInputStream(int)
> constructor java.io.PipedInputStream(java.io.PipedOutputStream, int)
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.