You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/09/24 19:02:44 UTC
[GitHub] [iceberg] miR172 opened a new pull request #3177: POC of v2 JdbcCatalog.
miR172 opened a new pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177
The code shows a POC of JdbcCatalog V2. It is intended for review and discussion only.
Therefore, dependencies like jooq and tomcat were not added.
The POC also uses Jooq auto-generated code in "org.apache.iceberg.jdbc.v2.jooqgenerated.*", which is not included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] miR172 closed pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
miR172 closed pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-928884168
@miR172 I think we can tackle the incompatibilities one by one. Based on the list of features you described in the mailing list, it does not seem to be a lot of differences, maybe some are just mismatches or misunderstandings. The namespace one would be a good start, since it's a missing feature in the current `JdbcCatalog` anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nssalian commented on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
nssalian commented on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-930705197
Thanks @jackye1995, agree with what you said. How do you suggest to proceed? Should I open an issue/PR for the changes to the JdbcCatalog with the initial implementation of Namespace properties?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] miR172 commented on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
miR172 commented on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-942606395
@nssalian is working on splitting sql tables #3274.
Followed that change I would address the following based on the code here:
1. Create an interface for JdbcCatalog to use a database. This allows implementations to use different SQL dialects and advanced jdbc-driver wrapper (like Jooq, or Spanner).
2. The existing plain text queries will be packed into a default impl because it requires no extra dependency.
I've created #3291
@jackye1995 @rdblue Please comment. If this sounds reasonable I'll open this PR (make it non-draft) with another code change. All jooq and S3 code will be removed out.
After that, we can work on adding createNamespace to the default impl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] miR172 commented on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
miR172 commented on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-929420364
@nssalian what are the pieces you want to add? I might have done it locally. Using a separated component (CatalogDb.java) to deal with the database? So that you could switch between JDBC-plain-query-impl and jooq-impl.
And that namespace had better be another table, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nssalian edited a comment on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
nssalian edited a comment on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-933097948
Thanks @rdblue and @jackye1995. I'm going to open a PR in the upcoming days on adding the changes we discussed.
Update: Working on this at the moment. Getting the tests to work correctly. It seems they were all written to skip createNamespace and other unsupported methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nssalian commented on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
nssalian commented on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-929388754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] miR172 commented on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
miR172 commented on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-929420364
@nssalian what are the pieces you want to add? I might have done it locally. Using a separated component (CatalogDb.java) to deal with the database? So that you could switch between JDBC-plain-query-impl and jooq-impl.
And that namespace had better be another table, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] miR172 edited a comment on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
miR172 edited a comment on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-942606395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nssalian commented on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
nssalian commented on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-933097948
Thanks @rdblue and @jackye1995. I'm going to open a PR in the upcoming days on adding the changes we discussed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-932997218
I agree with @jackye1995 that it makes the most sense to keep specific properties separate. And we should not have Iceberg creating buckets. That's a task that is up to the user. It should be easy enough to create a subclass of the JDBC catalog that can hook into `createNamespace` and create the bucket if that's needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nssalian edited a comment on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
nssalian edited a comment on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-929388754
@rdblue and I were discussing this offline and this POC has some good pieces that could help extend the existing the current JdbcCatalog. @miR172 , is it alright if I can work on adding some of those pieces to the JdbcCatalog? I don't wish to proceed without making sure you are ok with it. I can work with you on what extensions make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nssalian commented on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
nssalian commented on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-930653744
Some observations from looking at the POC and the current JdbcCatalog.
Caveat: I'm new to Iceberg, so apologies if I missed something in this.
Overall:
1. @miR172 is using jooq to generate the sql objects vs java.sql for the sql operations on the JdbcCatalog.
2. To avoid a double implementation and refactor, we should combine the differences of the POC and the current catalog to make sure we can capture the features missing in the current.
Feature changes:
1. Tables in the current catalog could definitely improve with timestamp fields. Adding more timestamp and possible ownership fields can help.
2. Schemas of the Table and Namespace can be clearer.
3. Namespace properties has methods but unsupported in the current. I propose creating a `JdbcNamespaceOperations` to allow more flexibility of methods for namespaces. We can have a more deliberate schema (fields supported for namespace).
@rdblue , @jackye1995 how can I help here? Shall we open a different issue to help incorporate changes? If there are changes I missed, please correct me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] miR172 commented on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
miR172 commented on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-940395263
Agree that S3 should not be known by Catalog. I'll move it out in our code.
I have some change locally to the existing Catalog, which make it compatible with both plain-JDBC and Jooq impl.
We can keep Jooq in our own code and contribute the common interfaces.
@nssalian let's chat on slack and coordinate the work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nssalian commented on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
nssalian commented on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-942612084
Nit in your comment: @miR172 the PR for the sql table is https://github.com/apache/iceberg/pull/3275.
https://github.com/apache/iceberg/pull/3274 is all the changes we need but need to be split.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nssalian commented on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
nssalian commented on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-929474936
@miR172 , let me take some time to understand your implementation. It's different from the JdbcCatalog's current implementation.
I see namespace properties being one of the pieces to start with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-927161511
Thanks for working on this and publishing the POC!
I'd like to first know if it is possible to just extend our current `JdbcCatalog` implementation to support namespace operations, instead of introducing all the new classes here as a v2. Because from open source maintenance perspective, it's not possible for us to maintain 2 copies of the same class, that is just going to give a lot of confusion to the end users. Given we already have that `JdbcCatalog` implementation, it would be really appreciated if we can just work together to make it better. I think that is an area that we can start fist to work towards an actual implementation PR that can be merged, and have more focused discussions there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] miR172 commented on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
miR172 commented on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-927907668
Thanks for the quick reply.
I fully understand and agree that we would only maintain one JdbcCatalog in the open source project.
We started the development before the existing JdbcCatalog was available, therefore, it is not compatible with the existing catalog.
I'll see if I can integrate these two in the following weeks and update the pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-928884168
@miR172 I think we can tackle the incompatibilities one by one. Based on the list of features you described in the mailing list, it does not seem to be a lot of differences, maybe some are just mismatches or misunderstandings. The namespace one would be a good start, since it's a missing feature in the current `JdbcCatalog` anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-931524289
@nssalian yeah, as long as you and @miR172 have coordinated the work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nssalian commented on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
nssalian commented on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-931526042
Thanks @jackye1995 I'll wait to hear back from @miR172 on how to proceed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-930702601
@nssalian agree, namespace property seems to be the most valuable thing to add as the first step. To achieve that, we basically need a namespace table. This PR already shows its schema design:
```
NamespacesRecord namespacesRecord = new NamespacesRecord();
namespacesRecord.setNamespaceName(namespaceName);
Timestamp timestamp = new Timestamp(System.currentTimeMillis());
namespacesRecord.setCreatedTimestamp(timestamp);
namespacesRecord.setLastUpdatedTimestamp(timestamp);
// TODO: set up permissions properly
namespacesRecord.setOwnerGroup("test_group");
namespacesRecord.setCreatedByUser("test_user");
namespacesRecord.setLastUpdatedByUser("test_user");
namespacesRecord.setLocation(location.toASCIIString());
namespacesRecord.setProperties(convertMapToJSONString(namespaceProperties));
```
Which looks mostly good to me, it's just a mapping of name -> location + properties.
Because it's a SQL table, we can also support nested namespace.
I think we can treat things like timestamp and owner as just a part of the table/namespace properties, an external user of `JdbcCatalog` can always set them if necessary, as along as they can retrieve this information later through Iceberg API. There is no reason to add special handling for that just to keep things generic, because there is no "owner" concept in Iceberg yet, and we should not introduce it too quickly.
For the use of `jooq`, my perspective is that the namespace table will be very simple, and I don't see much value in introducing a full suite of dependencies plus generated code just for that.
For the functionalities around creating bucket when creating namespace with location, it feels a bit hacky to me. A person who has create namespace permission at catalog user level might not have create S3 bucket permission at cloud permission level. It also makes the `createNamespace` method hard to revert when creation fails, you will also need delete bucket permission to revert the change, which makes the story much more complicated. So I would suggest hold on that feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nssalian commented on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
nssalian commented on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-929388754
@rdblue and I were discussing this offline and this POC has some good pieces that could help extend the existing the current JdbcCatalog. @miR172 , is it alright if I can work on adding some of those pieces to the JdbcCatalog? I don't wish to proceed without making sure you are ok with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nssalian edited a comment on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
nssalian edited a comment on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-929388754
@rdblue and I were discussing this offline and this POC has some good pieces that could help extend the existing the current JdbcCatalog. @miR172 , is it alright if I can work on adding some of those pieces to the JdbcCatalog? I don't wish to proceed without making sure you are ok with it. I can work with you on what extensions make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] miR172 commented on pull request #3177: POC of v2 JdbcCatalog.
Posted by GitBox <gi...@apache.org>.
miR172 commented on pull request #3177:
URL: https://github.com/apache/iceberg/pull/3177#issuecomment-946732931
Thanks for the discussion. Closing this pull request and issuing follow up changes in steps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org