[GitHub] [hive] zhangbutao commented on a diff in pull request #3276: HIVE-26046: MySQL's bit datatype is default to void datatype in hive

[GitBox <gi...@apache.org>]

zhangbutao commented on code in PR #3276:
URL: https://github.com/apache/hive/pull/3276#discussion_r950656597


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/MySQLConnectorProvider.java:
##########
@@ -90,10 +90,20 @@ protected String getDataType(String dbDataType, int size) {
     // map any db specific types here.
     switch (dbDataType.toLowerCase())
     {
+    case "bit":
+      return toHiveBitType(size);
     default:
       mappedType = ColumnType.VOID_TYPE_NAME;
       break;
     }
     return mappedType;
   }
+
+  private String toHiveBitType(int size) {
+    if (size <= 1) {
+      return ColumnType.BOOLEAN_TYPE_NAME;
+    } else {
+      return ColumnType.BIGINT_TYPE_NAME;

Review Comment:
   @nrg4878 I agree option 1 is the best and native way to handle datasouce specific datatype. But there is need to explore more info about JdbcStorageHandler, e.g. Jdbc pushdown or sth else.
   Anyway, I will try to research and implement option 1.  I will update here if there is any progress. Thx.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org