You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/28 11:06:54 UTC
[GitHub] [arrow-rs] alamb opened a new pull request #726: Add a note on rust compiler testing and compatibility
alamb opened a new pull request #726:
URL: https://github.com/apache/arrow-rs/pull/726
# Rationale for this change
@jhorstmann noticed a change that was introduced in https://github.com/apache/arrow-rs/pull/714#discussion_r696837777 (and included in the arrow 5.3.0 RC0) that is incompatible with rust 1.52.1 (rust is currently on 1.54.0).
# What changes are included in this PR?
Propose explicitly document that arrow and parquet are only tested with the latest stable version of Rust.
Though this maybe also should serve as a way to solicit opinions about how important compatibility with older versions of Rust is (and if anyone would be willing to spend the time to setup CI to make sure that happens)
# Are there any user-facing changes?
Different readme
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #726: Add a note on rust compiler testing and compatibility
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #726:
URL: https://github.com/apache/arrow-rs/pull/726#issuecomment-907612484
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/726?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#726](https://codecov.io/gh/apache/arrow-rs/pull/726?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3b47a9d) into [master](https://codecov.io/gh/apache/arrow-rs/commit/5a12d9749aa088e7abc4020e30238cf556499617?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a12d97) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 3b47a9d differs from pull request most recent head 9b48216. Consider uploading reports for the commit 9b48216 to get more accurate results
[](https://codecov.io/gh/apache/arrow-rs/pull/726?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #726 +/- ##
=======================================
Coverage 82.50% 82.50%
=======================================
Files 168 168
Lines 47589 47589
=======================================
Hits 39261 39261
Misses 8328 8328
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/726?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/726?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5a12d97...9b48216](https://codecov.io/gh/apache/arrow-rs/pull/726?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] houqp merged pull request #726: Add a note on rust compiler testing and compatibility
Posted by GitBox <gi...@apache.org>.
houqp merged pull request #726:
URL: https://github.com/apache/arrow-rs/pull/726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #726: Add a note on rust compiler testing and compatibility
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #726:
URL: https://github.com/apache/arrow-rs/pull/726#issuecomment-907612484
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/726?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#726](https://codecov.io/gh/apache/arrow-rs/pull/726?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c924015) into [master](https://codecov.io/gh/apache/arrow-rs/commit/5a12d9749aa088e7abc4020e30238cf556499617?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a12d97) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-rs/pull/726?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #726 +/- ##
==========================================
+ Coverage 82.50% 82.51% +0.01%
==========================================
Files 168 168
Lines 47589 47631 +42
==========================================
+ Hits 39261 39301 +40
- Misses 8328 8330 +2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/726?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [parquet\_derive\_test/src/lib.rs](https://codecov.io/gh/apache/arrow-rs/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmVfdGVzdC9zcmMvbGliLnJz) | `100.00% <0.00%> (ø)` | |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `68.86% <0.00%> (+2.69%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/726?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/726?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5a12d97...c924015](https://codecov.io/gh/apache/arrow-rs/pull/726?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org