You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/29 08:17:10 UTC
[GitHub] [kafka] chia7712 opened a new pull request #10791: MINOR: replace by org.junit.jupiter.api.Tag by net.jqwik.api.Tag for …
chia7712 opened a new pull request #10791:
URL: https://github.com/apache/kafka/pull/10791
The command `./gradlew raft:integrationTest` can't run any integration test since `org.junit.jupiter.api.Tag` does not work for jqwik engine (see https://github.com/jlink/jqwik/issues/36#issuecomment-436535760).
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 merged pull request #10791: MINOR: replace by org.junit.jupiter.api.Tag by net.jqwik.api.Tag for …
Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #10791:
URL: https://github.com/apache/kafka/pull/10791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #10791: MINOR: replace by org.junit.jupiter.api.Tag by net.jqwik.api.Tag for …
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #10791:
URL: https://github.com/apache/kafka/pull/10791#issuecomment-851271639
> The build definition doesn't require changes to mention this annotation?
The doc (https://jqwik.net/docs/current/user-guide.html#tagging-tests) explains how to tag a test but it does not mention the package of this annotation. I filed a PR for that (https://github.com/jlink/jqwik/pull/193)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #10791: MINOR: replace by org.junit.jupiter.api.Tag by net.jqwik.api.Tag for …
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #10791:
URL: https://github.com/apache/kafka/pull/10791#issuecomment-851797315
> I was asking if our build has to change. Looks like it's string based, so it doesn't?
Sorry for my incorrect response :(
> Have we tested?
yes.
*BEFORE*
<img width="705" alt="截圖 2021-06-01 下午12 32 25" src="https://user-images.githubusercontent.com/6234750/120266901-6e57c300-c2d5-11eb-9df2-90ebbc209bd8.png">
*AFTER*
<img width="1095" alt="截圖 2021-06-01 下午12 35 03" src="https://user-images.githubusercontent.com/6234750/120267072-cd1d3c80-c2d5-11eb-9802-46007dacdd5d.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #10791: MINOR: replace by org.junit.jupiter.api.Tag by net.jqwik.api.Tag for …
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10791:
URL: https://github.com/apache/kafka/pull/10791#issuecomment-851538731
I was asking if our build has to change. Looks like it's string based, so it doesn't?
https://github.com/apache/kafka/blob/trunk/build.gradle#L404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma edited a comment on pull request #10791: MINOR: replace by org.junit.jupiter.api.Tag by net.jqwik.api.Tag for …
Posted by GitBox <gi...@apache.org>.
ijuma edited a comment on pull request #10791:
URL: https://github.com/apache/kafka/pull/10791#issuecomment-851538731
I was asking if our build has to change. Looks like it's string based, so it doesn't?
https://github.com/apache/kafka/blob/trunk/build.gradle#L404
Have we tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #10791: MINOR: replace by org.junit.jupiter.api.Tag by net.jqwik.api.Tag for …
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10791:
URL: https://github.com/apache/kafka/pull/10791#issuecomment-850871754
Good catch. The build definition doesn't require changes to mention this annotation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org