[GitHub] [kafka] ableegoldman commented on a change in pull request #10411: KAFKA-7606: Remove deprecated options from StreamsResetter

[GitBox <gi...@apache.org>]

ableegoldman commented on a change in pull request #10411:
URL: https://github.com/apache/kafka/pull/10411#discussion_r603626513



##########
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##########
@@ -247,14 +246,10 @@ private void parseArguments(final String[] args) {
             .describedAs("file name");
         forceOption = optionParser.accepts("force", "Force the removal of members of the consumer group (intended to remove stopped members if a long session timeout was used). " +
                 "Make sure to shut down all stream applications when this option is specified to avoid unexpected rebalances.");
-        executeOption = optionParser.accepts("execute", "Execute the command.");

Review comment:
       Hmm...awkward. Yeah I think we should probably not remove it yet in that case. I'll add the deprecation note in this PR, and then we can remove it in 4.0 (is 4.0 coming after 3.0 or will we have 3.1?)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org